Add option to configure dnsDomain in kubeAdm

[nanikjava]

Fixes #4963

Following are the file changes:

kubeadm.go --> Add DNSDomain as one the field
kubeadm_test.go --> Add new test case to test the dns changes
templates.go --> Add the new DNSDomain into the template

Add new testdata for the kubeadm_test.go

[k8s-ci-robot]

Hi @nanikjava. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-bot]

Can one of the admins verify this patch?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nanikjava
To complete the pull request process, please assign tstromberg
You can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-io]

Codecov Report

Merging #5566 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5566      +/-   ##
==========================================
+ Coverage   36.63%   36.64%   +0.01%     
==========================================
  Files         102      102              
  Lines        7346     7348       +2     
==========================================
+ Hits         2691     2693       +2     
  Misses       4298     4298              
  Partials      357      357

Impacted Files	Coverage Δ
pkg/minikube/bootstrapper/kubeadm/templates.go	100% <ø> (ø)	⬆️
pkg/minikube/bootstrapper/kubeadm/kubeadm.go	19.85% <100%> (+0.39%)	⬆️

[medyagh]

Thanks for this PR and also adding unit tests ! could you add something in the website, either documentation or a tutorial that shows how to use this feature?

[tstromberg]

@minikube-bot OK to test

[nanikjava]

Thanks for this PR and also adding unit tests ! could you add something in the website, either documentation or a tutorial that shows how to use this feature?

@medyagh Sure can do that, is the website in the docs/ folder of the minikube project ?. Thanks

[k8s-ci-robot]

Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

• 2be8778 Use configured DNS domain in bootstrapper kubeadm templates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[nanikjava]

Thanks for this PR and also adding unit tests ! could you add something in the website, either documentation or a tutorial that shows how to use this feature?

@medyagh Sure can do that, is the website in the docs/ folder of the minikube project ?. Thanks

Never mind found the folder for the website and added a new file called dns.md under Networking/ folder. Thanks

[medyagh]

Awesome thanks

[nanikjava]

/assign