Upgrade dashboard to 2.0.0b4 #5403

tstromberg · 2019-09-19T00:24:36Z

Required for compatibility with Kubernetes v1.16.

Sadly, there is no non-beta release of the dashboard that works well enough with v1.16 to show the front page.

Tested for backwards compat all the way to v1.11.7 - seems fine.

k8s-ci-robot · 2019-09-19T00:25:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tstromberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

TravisBuddy · 2019-09-19T00:32:29Z

Travis tests have failed

Hey @tstromberg,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
./test.sh
= go mod ================================================================
ok
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.18.0'
golangci/golangci-lint info found version: 1.18.0 for v1.18.0/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
cmd/minikube/cmd/start.go:299:9: elseif: can replace 'else {if cond {}}' with 'else if cond {}' (gocritic)
	} else {
	       ^
Makefile:335: recipe for target 'lint-ci' failed
make[1]: *** [lint-ci] Error 1
= boilerplate ===========================================================
ok
= schema_check ==========================================================
ok
= go test ===============================================================
ok  	k8s.io/minikube/cmd/minikube/cmd	0.088s	coverage: 16.0% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.050s	coverage: 18.7% of statements
ok  	k8s.io/minikube/pkg/drivers	0.015s	coverage: 13.4% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.064s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/assets	0.036s	coverage: 61.5% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	2.545s	coverage: 73.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/kubeadm	0.056s	coverage: 30.6% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.580s	coverage: 53.0% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.022s	coverage: 76.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.008s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.009s	coverage: 56.7% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.053s	coverage: 75.9% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.053s	coverage: 1.4% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	0.033s	coverage: 11.3% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.053s	coverage: 78.6% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.021s	coverage: 70.3% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.022s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.014s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.024s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.038s	coverage: 35.9% of statements
--- FAIL: TestNewSSHClient (1.23s)
    ssh_mock.go:173: Listening on 127.0.0.1:43333
    ssh_mock.go:83: Accepting...
    ssh_mock.go:83: Accepting...
    ssh_mock.go:132: exec request received: &{Type:exec WantReply:true Payload:[0 0 0 3 102 111 111] ch:0xc00010c0c0 mux:<nil>}
    sshutil_test.go:60: Error running "foo": wait: remote command exited without exit status or exit signal
    ssh_mock.go:189: Stopping
FAIL
coverage: 75.0% of statements
FAIL	k8s.io/minikube/pkg/minikube/sshutil	1.241s
ok  	k8s.io/minikube/pkg/minikube/translate	0.004s	coverage: 8.4% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	2.113s	coverage: 64.5% of statements
ok  	k8s.io/minikube/pkg/util	1.231s	coverage: 62.0% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.012s	coverage: 59.1% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.002s	coverage: 0.0% of statements
Makefile:232: recipe for target 'test' failed
make: *** [test] Error 20

TravisBuddy Request Identifier: f1637780-da74-11e9-a83c-6d8e6b7d4c6a

TravisBuddy · 2019-09-19T00:34:14Z

Travis tests have failed

Hey @tstromberg,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
./test.sh
= go mod ================================================================
ok
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.18.0'
golangci/golangci-lint info found version: 1.18.0 for v1.18.0/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
cmd/minikube/cmd/start.go:299:9: elseif: can replace 'else {if cond {}}' with 'else if cond {}' (gocritic)
	} else {
	       ^
Makefile:335: recipe for target 'lint-ci' failed
make[1]: *** [lint-ci] Error 1
= boilerplate ===========================================================
ok
= schema_check ==========================================================
ok
= go test ===============================================================
ok  	k8s.io/minikube/cmd/minikube/cmd	0.092s	coverage: 16.0% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.064s	coverage: 18.7% of statements
ok  	k8s.io/minikube/pkg/drivers	0.015s	coverage: 13.4% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.059s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/assets	0.030s	coverage: 61.5% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	2.859s	coverage: 73.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/kubeadm	0.095s	coverage: 30.6% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.248s	coverage: 53.0% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.022s	coverage: 76.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.014s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.016s	coverage: 56.7% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.053s	coverage: 75.9% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.065s	coverage: 1.4% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	0.049s	coverage: 11.3% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.031s	coverage: 78.6% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.009s	coverage: 70.3% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.010s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.010s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.014s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.047s	coverage: 35.9% of statements
ok  	k8s.io/minikube/pkg/minikube/sshutil	0.518s	coverage: 75.0% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.007s	coverage: 8.4% of statements
ok
Makefile:232: recipe for target 'test' failed
make: *** [test] Error 4

TravisBuddy Request Identifier: 337d0190-da75-11e9-a83c-6d8e6b7d4c6a

tstromberg · 2019-09-19T01:02:46Z

This addon now works with "kubectl apply", but need to split file up to make it work with addons.

TravisBuddy · 2019-09-19T01:09:56Z

Travis tests have failed

Hey @tstromberg,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
./test.sh
= go mod ================================================================
ok
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.18.0'
golangci/golangci-lint info found version: 1.18.0 for v1.18.0/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
cmd/minikube/cmd/start.go:299:9: elseif: can replace 'else {if cond {}}' with 'else if cond {}' (gocritic)
	} else {
	       ^
Makefile:335: recipe for target 'lint-ci' failed
make[1]: *** [lint-ci] Error 1
= boilerplate ===========================================================
ok
= schema_check ==========================================================
ok
= go test ===============================================================
ok  	k8s.io/minikube/cmd/minikube/cmd	0.096s	coverage: 16.0% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.045s	coverage: 18.7% of statements
ok  	k8s.io/minikube/pkg/drivers	0.019s	coverage: 13.4% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.056s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/assets	0.026s	coverage: 61.5% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	3.292s	coverage: 73.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/kubeadm	0.057s	coverage: 30.6% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	1.153s	coverage: 53.0% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.021s	coverage: 76.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.009s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.007s	coverage: 56.7% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.056s	coverage: 75.9% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.023s	coverage: 1.4% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	0.029s	coverage: 11.3% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.023s	coverage: 78.6% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.012s	coverage: 70.3% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.007s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.012s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.014s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.048s	coverage: 35.9% of statements
ok  	k8s.io/minikube/pkg/minikube/sshutil	0.181s	coverage: 75.0% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.004s	coverage: 8.4% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	2.018s	coverage: 64.5% of statements
ok  	k8s.io/minikube/pkg/util	1.364s	coverage: 62.0% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.004s	coverage: 59.1% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.002s	coverage: 0.0% of statements
ok
Makefile:232: recipe for target 'test' failed
make: *** [test] Error 4

TravisBuddy Request Identifier: 2ef16cb0-da7a-11e9-a83c-6d8e6b7d4c6a

Upgrade dashboard to 2.0.0b4

6bd8978

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2019

k8s-ci-robot requested review from afbjorklund and sharifelgamal September 19, 2019 00:25

tstromberg added 2 commits September 18, 2019 17:25

Add missing YAML file

0c484a5

Remove extra YAML file

ee53775

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2019

Grant cluster-admin rights to dashboard

cf1444c

tstromberg added 2 commits September 18, 2019 21:41

Split and add reconcile tags

060028e

Add new dashboard assets

b3c3ca5

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 19, 2019

tstromberg changed the title ~~WIP: Upgrade dashboard to 2.0.0b4 for Kubernetes v1.16 compat~~ Upgrade dashboard to 2.0.0b4 Sep 19, 2019

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2019

josedonizetti approved these changes Sep 19, 2019

View reviewed changes

tstromberg merged commit e195922 into kubernetes:master Sep 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade dashboard to 2.0.0b4 #5403

Upgrade dashboard to 2.0.0b4 #5403

tstromberg commented Sep 19, 2019 •

edited

Loading

k8s-ci-robot commented Sep 19, 2019

TravisBuddy commented Sep 19, 2019

TravisBuddy commented Sep 19, 2019

tstromberg commented Sep 19, 2019

TravisBuddy commented Sep 19, 2019

Upgrade dashboard to 2.0.0b4 #5403

Upgrade dashboard to 2.0.0b4 #5403

Conversation

tstromberg commented Sep 19, 2019 • edited Loading

k8s-ci-robot commented Sep 19, 2019

TravisBuddy commented Sep 19, 2019

Travis tests have failed

1st Build

TravisBuddy Request Identifier: f1637780-da74-11e9-a83c-6d8e6b7d4c6a

TravisBuddy commented Sep 19, 2019

Travis tests have failed

1st Build

TravisBuddy Request Identifier: 337d0190-da75-11e9-a83c-6d8e6b7d4c6a

tstromberg commented Sep 19, 2019

TravisBuddy commented Sep 19, 2019

Travis tests have failed

1st Build

TravisBuddy Request Identifier: 2ef16cb0-da7a-11e9-a83c-6d8e6b7d4c6a

tstromberg commented Sep 19, 2019 •

edited

Loading