Re-Added time synchronization between host/VM

[reegnz]

This commit attempts to add back the missing time synchronization feature
to Minikube that was removed earlier with #3476.

As mentioned in #1378 we have an alternative solution for time
synchronization for Oracle VirtualBox, so there we don't want to enable
systemd-timesyncd.

We are using systemd conditional activation on systemd-timesyncd and
exclude systems that have an oracle hypervisor hosting the vm (currently
that's virtualbox for our purposes).

Fixes #1378

[k8s-ci-robot]

Hi @reegnz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-bot]

Can one of the admins verify this patch?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: reegnz
To complete the pull request process, please assign ra489
You can assign the PR to them by writing /assign @ra489 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[reegnz]

I didn't manage to rebuild the ISO and test with it, maybe someone could help out with that though.

[reegnz]

Does the CI build the ISO? In that case it would make it much more easy for me to test it out. On my machine I built the ISO for more than an hour when I gave up on it.

[afbjorklund]

Looks reasonable, never understood why systemd spells virtualbox as "oracle"

[reegnz]

OOOKAY, I waited for the full iso build to finish now (pretty brutal time-wise).

I found a mistake I made with the drop-in folder name that I fixed (systemd-timesync.d -> systemd-timesyncd.service.d).

Running in virtualbox, displaying the drop-in and the condition failed text is what we want here. The timedatectl command output is a bit confusing though, but the key there is 'System clock synchronized': no:

➜ minikube ssh
                         _             _
            _         _ ( )           ( )
  ___ ___  (_)  ___  (_)| |/')  _   _ | |_      __
/' _ ` _ `\| |/' _ `\| || , <  ( ) ( )| '_`\  /'__`\
| ( ) ( ) || || ( ) || || |\`\ | (_) || |_) )(  ___/
(_) (_) (_)(_)(_) (_)(_)(_) (_)`\___/'(_,__/'`\____)

$ systemctl status systemd-timesyncd
● systemd-timesyncd.service - Network Time Synchronization
   Loaded: loaded (/usr/lib/systemd/system/systemd-timesyncd.service; enabled; vendor preset: enabled)
  Drop-In: /etc/systemd/system/systemd-timesyncd.service.d
           └─disable-virtualbox.conf
   Active: inactive (dead)
Condition: start condition failed at Wed 2019-08-07 09:20:31 UTC; 43s ago
     Docs: man:systemd-timesyncd.service(8)
$ timedatectl
                      Local time: Wed 2019-08-07 09:21:19 UTC
                  Universal time: Wed 2019-08-07 09:21:19 UTC
                        RTC time: Wed 2019-08-07 09:21:18
                       Time zone: Etc/UTC (UTC, +0000)
       System clock synchronized: no
systemd-timesyncd.service active: yes
                 RTC in local TZ: no
$

Running in a different hypervisor, for me it was hyperkit. Displays drop-in file and unit activates properly, timedatectl shows expected output:

➜ minikube ssh
                         _             _
            _         _ ( )           ( )
  ___ ___  (_)  ___  (_)| |/')  _   _ | |_      __
/' _ ` _ `\| |/' _ `\| || , <  ( ) ( )| '_`\  /'__`\
| ( ) ( ) || || ( ) || || |\`\ | (_) || |_) )(  ___/
(_) (_) (_)(_)(_) (_)(_)(_) (_)`\___/'(_,__/'`\____)

$ systemctl status systemd-timesyncd
● systemd-timesyncd.service - Network Time Synchronization
   Loaded: loaded (/usr/lib/systemd/system/systemd-timesyncd.service; enabled; vendor preset: enabled)
  Drop-In: /etc/systemd/system/systemd-timesyncd.service.d
           └─disable-virtualbox.conf
   Active: active (running) since Wed 2019-08-07 09:23:05 UTC; 1min 59s ago
     Docs: man:systemd-timesyncd.service(8)
 Main PID: 1609 (systemd-timesyn)
   Status: "Synchronized to time server 216.239.35.8:123 (time3.google.com)."
    Tasks: 2 (limit: 4915)
   CGroup: /system.slice/systemd-timesyncd.service
           └─1609 /usr/lib/systemd/systemd-timesyncd

Aug 07 09:24:07 minikube systemd-timesyncd[1609]: Network configuration changed, trying to establish connection.
Aug 07 09:24:07 minikube systemd-timesyncd[1609]: Synchronized to time server 216.239.35.8:123 (time3.google.com).
Aug 07 09:24:07 minikube systemd-timesyncd[1609]: Network configuration changed, trying to establish connection.
Aug 07 09:24:07 minikube systemd-timesyncd[1609]: Synchronized to time server 216.239.35.8:123 (time3.google.com).
Aug 07 09:24:07 minikube systemd-timesyncd[1609]: Network configuration changed, trying to establish connection.
Aug 07 09:24:07 minikube systemd-timesyncd[1609]: Synchronized to time server 216.239.35.8:123 (time3.google.com).
Aug 07 09:24:07 minikube systemd-timesyncd[1609]: Network configuration changed, trying to establish connection.
Aug 07 09:24:07 minikube systemd-timesyncd[1609]: Synchronized to time server 216.239.35.8:123 (time3.google.com).
Aug 07 09:24:09 minikube systemd-timesyncd[1609]: Network configuration changed, trying to establish connection.
Aug 07 09:24:09 minikube systemd-timesyncd[1609]: Synchronized to time server 216.239.35.8:123 (time3.google.com).
$ timedatectl
                      Local time: Wed 2019-08-07 09:25:12 UTC
                  Universal time: Wed 2019-08-07 09:25:12 UTC
                        RTC time: Wed 2019-08-07 09:25:12
                       Time zone: Etc/UTC (UTC, +0000)
       System clock synchronized: yes
systemd-timesyncd.service active: yes
                 RTC in local TZ: no

Seems like a success to me. @afbjorklund what do you think?

[RA489]

@minikube-bot OK to test

[medyagh]

@reegnz Thank you so much for creating this issue ! this fixes one of the complains we had for minikube and I believe closes many issues !

thank you so much

[reegnz]

@medyagh Good to know this is such an important contribution. :) Always glad to help.