Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Docker, from 18.09.6 to 18.09.7 #4657

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Upgrade Docker, from 18.09.6 to 18.09.7 #4657

merged 1 commit into from
Jul 11, 2019

Conversation

afbjorklund
Copy link
Collaborator 

runc v1.0.0-rc8-0-g425e105

containerd v1.2.6

@afbjorklund
Upgrade Docker, from 18.09.6 to 18.09.7
8bea8e7 
    runc v1.0.0-rc8-0-g425e105

    containerd v1.2.6
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 1, 2019
@afbjorklund afbjorklund added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2019
@afbjorklund
Copy link
Collaborator Author

Currently this doesn't build properly with go1.10, so might need to upgrade Buildroot to get go1.12 ?

# runtime/internal/sys
../../../../../../../host/lib/go/src/runtime/internal/sys/stubs.go:11:7: const initializer 1 * (1 - GoarchArm64) + 16 * GoarchArm64 is not a constant
../../../../../../../host/lib/go/src/runtime/internal/sys/stubs.go:11:22: undefined: GoarchArm64
Makefile:173: receptet för målet ”bin/containerd-shim” misslyckades

@afbjorklund
Copy link
Collaborator Author

Hmm, must be something else - because containerd v1.2.5 is also failing, with the same build error...

@afbjorklund afbjorklund removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2019
@afbjorklund
Copy link
Collaborator Author

Rebuilding both the host go packages fixed it, so just something about the local out/buildroot...

@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Jul 2, 2019 •
edited
Loading

The Jenkins build failed due to #4345 (cri-o)

@RA489
Copy link

RA489 commented Jul 3, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, RA489

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@afbjorklund afbjorklund mentioned this pull request Jul 7, 2019
Closed
@tstromberg tstromberg merged commit 5ac8f12 into kubernetes:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@balopat balopat Awaiting requested review from balopat

@medyagh medyagh Awaiting requested review from medyagh

Assignees

@RA489 RA489

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afbjorklund @RA489 @k8s-ci-robot @tstromberg