-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for registry proxy addon #4539
Conversation
Hi @kumarom. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kumarom The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
This commit adds documentation on how to use minikube addon registry. Related to kubernetes#4341 and kubernetes#4529 This addresses kubernetes#4531 and kubernetes#4242
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for adding documentation, just small nit picks
|
||
Another approach is to enable minikube registry addons and then push images directly into registry. Steps for this approach is as follows: | ||
|
||
Ensure that docker is configured to use `192.168.39.0/24` as insecure registry. Refer [here](https://docs.docker.com/registry/insecure/) for instructions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this IP same on windows, mac on different drivers ... ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will explain how to decide what subnet to use here.
docs/reusing_the_docker_daemon.md
Outdated
@@ -31,3 +37,39 @@ The fix is to update /etc/sysconfig/docker to ensure that minikube's environment | |||
``` | |||
|
|||
Remember to turn off the _imagePullPolicy:Always_, as otherwise Kubernetes won't use images you built locally. | |||
|
|||
Another approach is to enable minikube registry addons and then push images directly into registry. Steps for this approach is as follows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please make a heading so it is clear at the first look that this is the second method ?
maybe have the following headiings:
Reusing the Docker daemon
Method 1 : using ...
method: 2 : using...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do..
Explain how to decide what subnet to use. Split into two headings.
Now run it in minikube: | ||
|
||
```shell | ||
kubectl run test-img --image=$(minikube ip):5000/test-img |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubectl run a Deployment is deprecated, maybe you can use kubectl create or kubectl run a Pod
The "registry host" is indeed easy to misunderstand,this PR is very useful,thinks for you work! |
This commit adds documentation on how to use minikube addon registry.
Related to #4341 and #4529
This addresses #4531 and #4242