Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically add extra options for none driver on ubuntu #4465

Merged
merged 5 commits into from
Jun 13, 2019
Merged

Automatically add extra options for none driver on ubuntu #4465

merged 5 commits into from
Jun 13, 2019

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Jun 10, 2019

To fix this issue, #3511

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 10, 2019
@medyagh medyagh requested a review from tstromberg June 10, 2019 21:01
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 10, 2019
@k8s-ci-robot k8s-ci-robot requested a review from RA489 June 10, 2019 21:02
@medyagh
Copy link
Member Author

medyagh commented Jun 10, 2019

@minikube-bot okay to test.

tstromberg
tstromberg suggested changes Jun 10, 2019
View reviewed changes
cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved
cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved
cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved
cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2019
@medyagh medyagh added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 10, 2019
@medyagh
Copy link
Member Author

medyagh commented Jun 11, 2019

@minikube-bot okay to test

@medyagh
Copy link
Member Author

medyagh commented Jun 11, 2019

/retest

@medyagh
Copy link
Member Author

medyagh commented Jun 12, 2019

DNS test failure is related to this issue : #4475

@RA489
Copy link

RA489 commented Jun 13, 2019 •
edited
Loading

@medyagh Please squash the commits to one rest LGTM.

@medyagh medyagh merged commit 6ecc105 into kubernetes:master Jun 13, 2019
@medyagh medyagh deleted the 3511_resolv_conf branch June 13, 2019 22:14
This was referenced Jun 13, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RA489 RA489 Awaiting requested review from RA489

@tstromberg tstromberg Awaiting requested review from tstromberg

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@medyagh @k8s-ci-robot @RA489 @tstromberg