Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean vendor on make clean #4382

Merged
merged 1 commit into from
May 30, 2019
Merged

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented May 30, 2019

To fix the build issue when there is there a vendor folder conflicting with gomod

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@medyagh medyagh requested a review from tstromberg May 30, 2019 19:45
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 30, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @medyagh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 30, 2019
@k8s-ci-robot k8s-ci-robot requested a review from balopat May 30, 2019 19:45
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: medyagh
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sharifelgamal

If they are not already assigned, you can assign the PR to them by writing /assign @sharifelgamal in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sharifelgamal
Copy link
Collaborator

The vendor directory should never exist if you merge master into your branch.

@medyagh
Copy link
Member Author

medyagh commented May 30, 2019

ah you are right, I guess this would be useful only to people who had checked pre-gomodule minikube and had a global .gitignore for vendor.

@tstromberg tstromberg merged commit eff89d3 into kubernetes:master May 30, 2019
@medyagh medyagh deleted the cleanvendor branch May 31, 2019 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants