Sync guest system clock if desynchronized from host #4283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
tstromberg
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
WIP because I would like to write a decent test for this. |
tstromberg
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
tstromberg
changed the title
tstromberg
changed the title
tstromberg
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RA489, tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sharifelgamal
approved these changes
May 29, 2019
|
Test failure is unrelated to this change. |
medyagh
reviewed
May 29, 2019
| return nil | ||
| } | ||
|
|
||
| // systemClockDelta returns the approximate difference between the host and guest system clock |
There was a problem hiding this comment.
wrong func name in the comment "systemClockDelta" should be "guestClockDelta"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1378 and #4264