Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make hyperkit driver more robust: detect crashing, misinstallation, other process names #3660

Merged
merged 11 commits into from
Feb 15, 2019
Merged

Make hyperkit driver more robust: detect crashing, misinstallation, other process names #3660

merged 11 commits into from
Feb 15, 2019

Conversation

tstromberg
Copy link
Contributor

Things I ran into today when I had an older hyperkit driver installed and tried to update it, badly.

Also adds logging for DHCP lease discovery.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 12, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 13, 2019
@tstromberg tstromberg changed the title Improve VM re-use reliability: detect crashing and/or badly installed hyperkit hyperkit: Improve reliability and debuggability when re-using an existing VM Feb 13, 2019
@tstromberg tstromberg changed the title hyperkit: Improve reliability and debuggability when re-using an existing VM hyperkit: Make VM re-use more robust, allow com.docker.hyper process name. Feb 13, 2019
@tstromberg tstromberg changed the title hyperkit: Make VM re-use more robust, allow com.docker.hyper process name. Make hyperkit driver more robust: detect crashing, misinstallation, other process names Feb 13, 2019
@tstromberg
Copy link
Contributor Author

@minikube-bot OK to test

donmccasland
donmccasland approved these changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@donmccasland donmccasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I HIGHLY approve of adding more log.Info messages around tricky start up moments like this

@tstromberg
Copy link
Contributor Author

@minikube-bot OK to test

balopat
balopat approved these changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you
As discussed, one more suggestion for even better debuggability:

in driver.go, Start()

	logger := log.New(os.Stdout, "hyperkit server - ", 0)
	h.SetLogger(logger)

@tstromberg tstromberg merged commit ceb324b into kubernetes:master Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@donmccasland donmccasland donmccasland approved these changes

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tstromberg @k8s-ci-robot @balopat @donmccasland