Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Podman 1.0.0 #3584

Merged
merged 5 commits into from
Jan 25, 2019
Merged

Podman 1.0.0 #3584

merged 5 commits into from
Jan 25, 2019

Conversation

afbjorklund
Copy link
Collaborator

Closes #3568

Some trickiness was required, with compiling against varlink and making sure GitCommit is correct...

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 24, 2019
@tstromberg tstromberg self-assigned this Jan 24, 2019
@tstromberg
Copy link
Contributor

Thanks!

@tstromberg
Copy link
Contributor

tstromberg commented Jan 24, 2019 •
edited
Loading

KVM test looks unrelated, but will retest just in case.

@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@RA489
Copy link

RA489 commented Jan 25, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

@RA489: changing LGTM is restricted to assignees, and only kubernetes/minikube repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: afbjorklund, RA489
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: tstromberg

If they are not already assigned, you can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tstromberg tstromberg merged commit 0d02609 into kubernetes:master Jan 25, 2019
joestringer referenced this pull request Jul 1, 2020
@tstromberg
Sync err_map, add HideCreateLink option to problem map
5024fce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@balopat balopat Awaiting requested review from balopat

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@tstromberg tstromberg

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afbjorklund @tstromberg @RA489 @k8s-ci-robot