Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-remove kube-dns addon #3556

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Re-remove kube-dns addon #3556

merged 1 commit into from
Jan 24, 2019

Conversation

robrich
Copy link
Contributor

@robrich robrich commented Jan 19, 2019

2091f8c on 11/13/18 removed kube-dns addon
3c3b736 on 8/8/18 added back in the reference in addons.go (accidentally?) but didn't add deploy/addons/kube-dns/* files referenced
8bc8816 on 1/15/19 merged in PR #3521

Now when running minikube addons list I see:

...snip...
- kube-dns: disabled
...snip

and when I run minikube addons enable kube-dns I see:

Property name kube-dns not found

This PR attempts to re-remove kube-dns from the addons list.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: robrich
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: balopat

If they are not already assigned, you can assign the PR to them by writing /assign @balopat in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 19, 2019
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 19, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@robrich
Copy link
Contributor Author

robrich commented Jan 19, 2019

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 19, 2019
@tstromberg
Copy link
Contributor

Thank you for the patch!

@tstromberg tstromberg merged commit dc66ca5 into kubernetes:master Jan 24, 2019
@robrich
Copy link
Contributor Author

robrich commented Jan 24, 2019

Glad to help. What's the release cadence? (This definitely doesn't deserve it's own release.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants