Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove both the CoreDNS and KubeDNS addons. Let Kubeadm install the c… #3332

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Remove both the CoreDNS and KubeDNS addons. Let Kubeadm install the c… #3332

merged 1 commit into from
Dec 4, 2018

Conversation

dlorenc
Copy link
Contributor

@dlorenc dlorenc commented Nov 13, 2018

…orrect DNS addon.

Ref #3080
#2808

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 13, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2018
rajansandeep
rajansandeep reviewed Nov 13, 2018
View reviewed changes
Copy link
Contributor

@rajansandeep rajansandeep left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also mean that we no longer require to maintain the yaml files for kube-dns and CoreDNS?

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 13, 2018
@rajansandeep
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2018
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2018
@dlorenc
Copy link
Contributor Author

dlorenc commented Nov 13, 2018

Does this also mean that we no longer require to maintain the yaml files for kube-dns and CoreDNS?

Yup, removed these!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2018
rajansandeep
rajansandeep approved these changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@rajansandeep rajansandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dlorenc
Copy link
Contributor Author

dlorenc commented Nov 15, 2018

After some discussion yesterday we realized we can delete even more code, and not specify the DNS addon to kubeadm at all. Added that change as well.

With k8s 1.10, we get kube-dns, with 1.11 we get coredns.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2018
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@dlorenc dlorenc mentioned this pull request Nov 15, 2018
Merged
balopat
balopat approved these changes Nov 16, 2018
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlorenc
Copy link
Contributor Author

dlorenc commented Nov 16, 2018

@minikube-bot test this please

@RA489
Copy link

RA489 commented Nov 23, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

@RA489: changing LGTM is restricted to assignees, and only kubernetes/minikube repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlorenc, RA489, rajansandeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@tstromberg tstromberg merged commit bc67a32 into kubernetes:master Dec 4, 2018
This was referenced Dec 4, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@balopat balopat balopat approved these changes

@rajansandeep rajansandeep rajansandeep approved these changes

@aaron-prindle aaron-prindle Awaiting requested review from aaron-prindle

Assignees

@rajansandeep rajansandeep

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dlorenc @rajansandeep @k8s-ci-robot @RA489 @tstromberg @balopat