Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write /etc/crictl.yaml when starting #3194

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Write /etc/crictl.yaml when starting #3194

merged 1 commit into from
Jan 17, 2019

Conversation

afbjorklund
Copy link
Collaborator

This cannot be done by the provisioner (buildroot), since it only knows docker

And it needs to be done before the bootstrapper (kubeadm), as a pre-requisite

Closes #3043

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 1, 2018
@afbjorklund afbjorklund mentioned this pull request Oct 2, 2018
Closed
tstromberg
tstromberg suggested changes Oct 4, 2018
View reviewed changes
cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved
cmd/minikube/cmd/start.go Show resolved Hide resolved
cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved
cmd/util/util.go Show resolved Hide resolved
cmd/util/util.go Show resolved Hide resolved
@afbjorklund afbjorklund mentioned this pull request Nov 4, 2018
Closed
@afbjorklund afbjorklund mentioned this pull request Dec 20, 2018
Closed
@afbjorklund afbjorklund mentioned this pull request Jan 11, 2019
Merged
@tstromberg
Copy link
Contributor

@minikube-bot OK to test

1 similar comment
@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2019
@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@tstromberg
Copy link
Contributor

Please address the merge conflicts. Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: afbjorklund
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jimmidyson

If they are not already assigned, you can assign the PR to them by writing /assign @jimmidyson in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2019
@tstromberg tstromberg merged commit 56f8142 into kubernetes:master Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@aaron-prindle aaron-prindle Awaiting requested review from aaron-prindle

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afbjorklund @tstromberg @k8s-ci-robot