Fix Kubernetes 1.11 builds #2943
Conversation
Add a versioned flag for the enable-admission-control flags Add a second step to call "kubeadm alpha phase addon all" which seems to be required now to get coredns running. I tested this all the way back to 1.9.0.
k8s-ci-robot
added
cncf-cla: yes
| @@ -205,8 +205,17 @@ var versionSpecificOpts = []VersionedExtraOption{ | |||
| Key: "admission-control", | |||
| Value: strings.Join(util.DefaultAdmissionControllers, ","), | |||
| }, | |||
| LessThanOrEqual: semver.MustParse("1.10.10"), | |||
There was a problem hiding this comment.
Won't this break when there's a 1.10.11 ? Does semver.MustParse("1.10.*") not work?
There was a problem hiding this comment.
The semver library doesn't support *'s :(
panic: semver: Parse(1.10.*): Invalid character(s) found in patch number "*"I'll change to something like 1000
| { | ||
| Option: util.ExtraOption{ | ||
| Component: Apiserver, | ||
| Key: "enable-admission-plugins", |
There was a problem hiding this comment.
Is this necessary? I got a working cluster with just removing the admission-control line from /var/lib/kubeadm.yaml, so the rest of the default manifest was fine without needing any more overrides.
There was a problem hiding this comment.
It's not necessary, but we pass some different defaults than kubeadm.
|
@minikube-bot test this please |
…needed since 1.8 but the build required it to be set
|
Hope you don't mind @dlorenc but in a bid to get this merged I've just fixed up tests (and added a change to Makefile to work for devs - like me - that have no explicit GOPATH env var set). |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlorenc, jimmidyson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add a versioned flag for the enable-admission-control flags
Add a second step to call "kubeadm alpha phase addon all" which seems to be required now to get coredns running.
I tested this all the way back to 1.9.0.
This should fix #2942