Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Docker, from 17.09 to 17.12 #2597

Merged
merged 1 commit into from
Mar 12, 2018
Merged

Conversation

afbjorklund
Copy link
Collaborator

The reason that 17.12.0 didn't work (in #2427) was because DOCKER_RAMDISK stopped working in containerd: moby/moby#35957 But now that 17.12.1 has been released as "stable", it should be OK ?

17.12.1-ce (2018-02-27)
- Honor DOCKER_RAMDISK with containerd 1.0 moby/moby#35957

Alternatively, one could upgrade from 17.09.0 to 17.09.1 if there is an issue - or wanting to play it safe...

Kubernetes still doesn't "support" anything beyond Docker 17.03, as pointed out so nicely by kubeadm:

WARNING: docker version is greater than the most recently validated version.

So let's go with the latest (stable), unless there is a reason to stick with the earlier (stable) Sep version ?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: afbjorklund
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dlorenc

Assign the PR to them by writing /assign @dlorenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@r2d4
Copy link
Contributor

r2d4 commented Mar 11, 2018

@praveenkumar should we be concerned about failing minishift test?

@praveenkumar
Copy link
Contributor

should we be concerned about failing minishift test?

@r2d4 No, I went through the logs and not able to find what causes the failure, minishift start happen successfully and even other stuff worked. If you can retrigger this job that would be great.

@r2d4
Copy link
Contributor

r2d4 commented Mar 12, 2018

@minikube-bot retest this please

@r2d4 r2d4 merged commit 6ccc019 into kubernetes:master Mar 12, 2018
@afbjorklund afbjorklund deleted the docker branch March 24, 2018 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants