Mo hit hyperkit mount fix #2337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
I merged in recent changes here, and updated godeps. Not sure the easiest way to go forward here. |
|
@dlorenc thanks for doing this.. what seems to be the issue? |
|
Sorry, hit some godep issues. I have a big change here #2343 that would conflict, I'll get back to this one right after that goes in. |
|
@dlorenc ahh okay, cool. Stoked for k8s 1.9 🤗 |
dlorenc
force-pushed
the
mo-hit-hyperkit-mount-fix
branch
from
df678a6
to
bb1d6c5
Compare
|
OK, I think I got this now. |
dlorenc
force-pushed
the
mo-hit-hyperkit-mount-fix
branch
from
bb1d6c5
to
fefa15c
Compare
k8s-ci-robot
added
size/L
|
@mo-hit ok, actually got it for real this time :) |
|
@minikube-bot test this please |
dlorenc
force-pushed
the
mo-hit-hyperkit-mount-fix
branch
from
f9e6b37
to
04c127a
Compare
…ll with time and fix vendoring issue
The build constraints in vmnet.go cause issues.
dlorenc
force-pushed
the
mo-hit-hyperkit-mount-fix
branch
from
04c127a
to
919fee1
Compare
r2d4
reviewed
Jan 2, 2018
| @@ -52,6 +52,8 @@ const ( | |||
| humanReadableDiskSize = "disk-size" | |||
| vmDriver = "vm-driver" | |||
| xhyveDiskDriver = "xhyve-disk-driver" | |||
| NFSSharesRoot = "nfs-shares-root" | |||
There was a problem hiding this comment.
This needs some indicator that its macOS specific
@dlorenc
dlorenc
commented
Jan 2, 2018
pkg/drivers/hyperkit/driver.go
Outdated
| } | ||
|
|
||
| func (d *Driver) nfsExportIdentifier(path string) string { | ||
| return fmt.Sprintf("docker-machine-driver-hyperkit %s-%s", d.MachineName, path) |
There was a problem hiding this comment.
I should change this string to something minikube related instead of hyperkit.
r2d4
approved these changes
Jan 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.