Update ingress controller, and fix integration test #2292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
Can one of the admins verify this patch? |
|
@minikube-bot ok to test |
dlorenc
reviewed
Dec 11, 2017
pkg/minikube/constants/constants.go
Outdated
| @@ -170,6 +170,11 @@ var LocalkubeCachedImages = []string{ | |||
| // Dashboard | |||
| "gcr.io/google_containers/kubernetes-dashboard-amd64:v1.6.3", | |||
|
|
|||
| // Ingress Controller | |||
There was a problem hiding this comment.
These images get cached on all systems - I don't think we want to add them here.
@r2d4 where do you think we should add these? Maybe in common.sh using the minikube cache command in a list?
There was a problem hiding this comment.
Hi @r2d4 Could you please help to check this?
|
Hi @dlorenc, I revert cache because of the cache image should not add them here. |
dlorenc
approved these changes
Dec 13, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the recent observation, I found the ingress integration test failed in some environment, I think the reason that test fails is that ingress pod not ready yet, so this commit use
Retry()to make sure that the test not only run once.In addition update image for Ingress controller.
/cc @r2d4 @dlorenc