Add deprecation notices for kvm and xhyve. #2227
Conversation
k8s-ci-robot
added
cncf-cla: yes
Codecov Report
@@ Coverage Diff @@
## master #2227 +/- ##
==========================================
- Coverage 27.75% 27.69% -0.06%
==========================================
Files 82 82
Lines 5541 5556 +15
==========================================
+ Hits 1538 1539 +1
- Misses 3807 3821 +14
Partials 196 196
Continue to review full report at Codecov.
|
| @@ -206,9 +206,17 @@ func createHost(api libmachine.API, config MachineConfig) (*host.Host, error) { | |||
| driver = createVirtualboxHost(config) | |||
| case "vmwarefusion": | |||
| driver = createVMwareFusionHost(config) | |||
| case "kvm", "kvm2": | |||
| case "kvm": | |||
There was a problem hiding this comment.
It may be good to allow a user to suppress these messages so we don't break any automated scripts? I think that was an issue with some of the other warning messages we've added. We might be able to reuse one of our env vars or config values for it.
k8s-ci-robot
added
size/M
| if viper.GetBool(cfg.ShowDriverDeprecationNotification) { | ||
| fmt.Fprintln(os.Stderr, `WARNING: The kvm driver is now deprecated and support for it will be removed in a future release. | ||
| Please consider switching to the kvm2 driver, which is intended to replace the kvm driver. | ||
| See https://github.com/kubernetes/minikube/blob/master/docs/drivers.md#kvm2-driver for more information. |
There was a problem hiding this comment.
I do not see a topic in the docs related to kvm2
There was a problem hiding this comment.
Nice catch. We'll get that in today too.
|
Ref #2231 |
No description provided.