-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix headlamp addon instructions to use new k8s way of generating a token #20440
base: master
Are you sure you want to change the base?
docs: fix headlamp addon instructions to use new k8s way of generating a token #20440
Conversation
…g a token Signed-off-by: adwait-godbole <adwaitngodbole@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: adwait-godbole The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @adwait-godbole! |
Hi @adwait-godbole. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Can one of the admins verify this patch? |
export SECRET=$(kubectl get secrets --namespace headlamp -o custom-columns=":metadata.name" | grep "headlamp-token") | ||
kubectl get secret $SECRET --namespace headlamp --template=\{\{.data.token\}\} | base64 --decode | ||
``` | ||
kubectl create token headlamp --duration 24h -n headlamp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it should be 24h. For a development system this is a bit tedious to have to create a new token every day.
kubectl create token headlamp-admin -n kube-system
If leaving it without an expiry is too much, what about a line telling the users about removing the duration if their minikube is just for development?
Hi. We give similar instructions for creating a token for headlamp addon with Kubernetes 1.24+ here: https://headlamp.dev/docs/latest/installation/ |
Fixes headlamp-k8s/headlamp#2923