-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp minikube website footer #18062
Revamp minikube website footer #18062
Conversation
Skipping CI for Draft Pull Request. |
Can one of the admins verify this patch? |
@sandipanpanda I know it's in draft so if you're aware and still working on this ignore this, but I'm not seeing your change in the footer https://deploy-preview-18062--kubernetes-sigs-minikube.netlify.app/ |
@spowelljr I was following the documentation for the footer you shared in the issue. I think it is for a custom hugo theme, not the one minikube uses. |
9f87750
to
efff3bd
Compare
Changes seem to work now: https://deploy-preview-18062--kubernetes-sigs-minikube.netlify.app/docs/ |
Great work! Could you also style it to white so it matches the rest of the footer? |
efff3bd
to
804c762
Compare
Done! |
Awesome @sandipanpanda, this looks great! One last request if you're willing, to match the rest of the links on our site it would be nice if it changed color on hover to help the users know it's a link. I was thinking something around |
@spowelljr what do you think about keeping them the default blue to indicate they are clickable links? |
/cc @medyagh |
I don't think the contrast of the blue on a gray background visually goes together. I think having them change shade on hover would be enough. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
@sandipanpanda do you mind addressing steven's review so we could merge this pr |
804c762
to
989f4a0
Compare
Add terms, privacy, website, license info in footer
989f4a0
to
fecc16b
Compare
/cc @medyagh @spowelljr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the PR!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sandipanpanda, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: #18055