Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp minikube website footer #18062

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

sandipanpanda
Copy link
Member

Fixes: #18055

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 30, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 30, 2024
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@spowelljr
Copy link
Member

@sandipanpanda I know it's in draft so if you're aware and still working on this ignore this, but I'm not seeing your change in the footer

https://deploy-preview-18062--kubernetes-sigs-minikube.netlify.app/

@sandipanpanda
Copy link
Member Author

Here's link to the Hugo config

https://www.zerostatic.io/docs/hugo-shard/global-config/footer/

@spowelljr I was following the documentation for the footer you shared in the issue. I think it is for a custom hugo theme, not the one minikube uses.

@sandipanpanda sandipanpanda force-pushed the add-trademark-disclaimer branch from 9f87750 to efff3bd Compare January 31, 2024 17:13
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 31, 2024
@sandipanpanda
Copy link
Member Author

@sandipanpanda sandipanpanda marked this pull request as ready for review January 31, 2024 17:17
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2024
@sandipanpanda sandipanpanda changed the title Add trademark disclaimer in website footer Revamp minikube website footer Jan 31, 2024
@spowelljr
Copy link
Member

Great work! Could you also style it to white so it matches the rest of the footer?

@sandipanpanda sandipanpanda force-pushed the add-trademark-disclaimer branch from efff3bd to 804c762 Compare February 2, 2024 15:09
@sandipanpanda
Copy link
Member Author

Done!

@spowelljr
Copy link
Member

Awesome @sandipanpanda, this looks great! One last request if you're willing, to match the rest of the links on our site it would be nice if it changed color on hover to help the users know it's a link. I was thinking something around #b5b1b1 maybe?

@sandipanpanda
Copy link
Member Author

@spowelljr what do you think about keeping them the default blue to indicate they are clickable links?

@sandipanpanda
Copy link
Member Author

/cc @medyagh

@spowelljr
Copy link
Member

spowelljr commented Apr 5, 2024

@spowelljr what do you think about keeping them the default blue to indicate they are clickable links?

I don't think the contrast of the blue on a gray background visually goes together. I think having them change shade on hover would be enough.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 4, 2024
@medyagh
Copy link
Member

medyagh commented Jul 11, 2024

@sandipanpanda do you mind addressing steven's review so we could merge this pr

@sandipanpanda sandipanpanda force-pushed the add-trademark-disclaimer branch from 804c762 to 989f4a0 Compare July 12, 2024 14:48
Add terms, privacy, website, license info in footer
@sandipanpanda sandipanpanda force-pushed the add-trademark-disclaimer branch from 989f4a0 to fecc16b Compare July 12, 2024 15:00
@sandipanpanda
Copy link
Member Author

/cc @medyagh @spowelljr
PTAL

Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR!

@spowelljr spowelljr merged commit 6e07a9a into kubernetes:master Jul 15, 2024
6 of 7 checks passed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sandipanpanda, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2024
@sandipanpanda sandipanpanda deleted the add-trademark-disclaimer branch July 16, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website does not have the correct trademark disclaimer
6 participants