Fixed flags to use 9p syntax for uid and gid #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1643 +/- ##
==========================================
+ Coverage 38.62% 38.66% +0.03%
==========================================
Files 51 51
Lines 2664 2664
==========================================
+ Hits 1029 1030 +1
+ Misses 1454 1453 -1
Partials 181 181
Continue to review full report at Codecov.
|
dlorenc
approved these changes
Jun 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that 9p uses a different syntax for the UID and GID than other protocols. With this change, the mounted directories correctly owned by the docker user in the VM and not "none". The GID value does not appear to be respected though (still "none"), this might require additional tweaks to the server.