[Addon] Update Kong Ingress Controller Addon to 2.9.x/Kong 3.2.x

[gAmUssA]

Updated existing Kong Ingress Controller addon to the latest versions.

[k8s-ci-robot]

Hi @gAmUssA. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gAmUssA]

@sharifelgamal, it's me again (Viktor from #13326 )
I updated the kong addon to the latest version. Kindly allow to test

[minikube-bot]

Can one of the admins verify this patch?

[gAmUssA]

Also, how can I assign myself as the official maintainer of this addon?

[shaneutt]

Also, how can I assign myself as the official maintainer of this addon?

If I'm reading the repo configuration right, so far it's just reviewers and approvers, not owners of specific files?

But maybe Steven would know better?

/cc @spowelljr

[gAmUssA]

Also, how can I assign myself as the official maintainer of this addon?

thanks @shaneutt for this comment.
the reason I brought this up is when one does enable addons minikube says

❱ minikube addons enable kong
❗  kong is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.
❗  kong does not currently have an associated maintainer.

so I would love to give some assurance that this addon is maintained.

Hope it does make sense. Thank you

[spowelljr]

Hi @gAmUssA, thanks for updating the addon!

Just a heads up that @sharifelgamal no longer actively works on the minikube project.

As for adding yourself as the maintainer for the kong addon:

minikube/pkg/minikube/assets/addons.go

Line 296 in 795b706

}, false, "kong", "3rd party (Kong HQ)", "", "https://minikube.sigs.k8s.io/docs/handbook/addons/kong-ingress/", map[string]string{

You can put your GitHub username in the empty string after 3rd party (Kong HQ).

Thanks for nominating yourself as the maintainer for the addon!

After you make the maintainer change I'll run the tests against your PR

[gAmUssA]

@spowelljr awesome, thank you!
it's done

[spowelljr]

/ok-to-test

[minikube-pr-bot]

timing minikube failed, please try again

[gAmUssA]

are those flaky tests or something is required from me to fix it?

[spowelljr]

are those flaky tests or something is required from me to fix it?

All the failed tests are flaky, PR looks good to me

[spowelljr]

I just tried to enable the addon on my machine (arm64 macOS) and the kong pods aren't coming up

NAMESPACE     NAME                               READY   STATUS    RESTARTS      AGE
kong          ingress-kong-668c4bd5bb-jpvcm      0/1     Running   0             2m10s
kong          proxy-kong-6dfdc945-4tmc2          0/1     Running   1 (59s ago)   2m10s
kong          proxy-kong-6dfdc945-79l7q          0/1     Running   1 (59s ago)   2m10s

  Type     Reason             Age                From               Message
  ----     ------             ----               ----               -------
  Normal   Scheduled          104s               default-scheduler  Successfully assigned kong/proxy-kong-6dfdc945-79l7q to minikube
  Normal   Pulling            104s               kubelet            Pulling image "docker.io/kong:3.2@sha256:f5f51af49fa1f5a7600e60bb51ebd760b16fd020bb16bba2b70d36a54f3d6ac8"
  Normal   Pulled             97s                kubelet            Successfully pulled image "docker.io/kong:3.2@sha256:f5f51af49fa1f5a7600e60bb51ebd760b16fd020bb16bba2b70d36a54f3d6ac8" in 7.077919212s (7.078009254s including waiting)
  Normal   Killing            64s                kubelet            Container proxy failed liveness probe, will be restarted
  Warning  FailedPreStopHook  62s                kubelet            PreStopHook failed
  Normal   Created            33s (x2 over 96s)  kubelet            Created container proxy
  Normal   Started            33s (x2 over 96s)  kubelet            Started container proxy
  Normal   Pulled             33s                kubelet            Container image "docker.io/kong:3.2@sha256:f5f51af49fa1f5a7600e60bb51ebd760b16fd020bb16bba2b70d36a54f3d6ac8" already present on machine
  Warning  Unhealthy          4s (x10 over 84s)  kubelet            Readiness probe failed: Get "http://10.244.0.2:8100/status": dial tcp 10.244.0.2:8100: connect: connection refused
  Warning  Unhealthy          4s (x6 over 84s)   kubelet            Liveness probe failed: Get "http://10.244.0.2:8100/status": dial tcp 10.244.0.2:8100: connect: connection refused

[spowelljr]

Looks like that resolved it:

NAMESPACE     NAME                               READY   STATUS    RESTARTS      AGE
kong          ingress-kong-668c4bd5bb-ghnds      1/1     Running   0             55s
kong          proxy-kong-6dfdc945-cq8kb          1/1     Running   0             55s

[gAmUssA]

Apologies.. just pushed e23ee80 with fix, tested on macosx (m1, arm64)

❱ kgpn kong
NAME                            READY   STATUS    RESTARTS   AGE
ingress-kong-668c4bd5bb-b5vdm   1/1     Running   0          40s
proxy-kong-6dfdc945-s6mf2       1/1     Running   0          40s

[spowelljr]

/retest-this-please

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16424) |
+----------------+----------+---------------------+
| minikube start | 52.1s    | 52.1s               |
| enable ingress | 28.2s    | 28.4s               |
+----------------+----------+---------------------+

Times for minikube start: 53.3s 50.2s 52.6s 51.9s 52.3s
Times for minikube (PR 16424) start: 50.9s 51.6s 53.4s 53.0s 51.6s

Times for minikube ingress: 27.7s 28.3s 28.2s 28.7s 28.2s
Times for minikube (PR 16424) ingress: 27.7s 29.2s 28.2s 28.7s 28.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16424) |
+----------------+----------+---------------------+
| minikube start | 23.5s    | 23.5s               |
| enable ingress | 21.0s    | 21.1s               |
+----------------+----------+---------------------+

Times for minikube ingress: 20.9s 20.9s 20.4s 21.9s 20.9s
Times for minikube (PR 16424) ingress: 20.9s 20.4s 21.4s 20.9s 21.9s

Times for minikube start: 25.4s 25.7s 22.1s 22.2s 22.4s
Times for minikube (PR 16424) start: 25.6s 23.3s 23.4s 22.8s 22.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16424) |
+----------------+----------+---------------------+
| minikube start | 20.8s    | 21.6s               |
| enable ingress | 37.8s    | 31.4s               |
+----------------+----------+---------------------+

Times for minikube start: 21.6s 20.1s 20.8s 21.4s 20.4s
Times for minikube (PR 16424) start: 21.4s 20.7s 20.6s 23.5s 21.7s

Times for minikube ingress: 31.4s 31.4s 47.4s 31.4s 47.4s
Times for minikube (PR 16424) ingress: 31.4s 31.4s 31.4s 31.4s 31.4s

[minikube-pr-bot]

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux	TestFunctional/parallel/MountCmd/specific-port (gopogh)	0.60 (chart)
Docker_Windows	TestStartStop/group/default-k8s-diff-port/serial/Pause (gopogh)	6.96 (chart)

To see the flake rates of all tests by environment, click here.

[spowelljr]

Thanks for the PR!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gAmUssA, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment