Don't treat stopping stopped hosts as error #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `minikube stop` while nothing is running results in a crash. This patch makes `cluster.StopHost()` swallow the stop-while-stopped error libmachine returns.
k8s-ci-robot
added
the
cncf-cla: yes
|
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #1606 +/- ##
==========================================
- Coverage 38.74% 38.66% -0.09%
==========================================
Files 51 51
Lines 2604 2607 +3
==========================================
- Hits 1009 1008 -1
- Misses 1417 1421 +4
Partials 178 178
Continue to review full report at Codecov.
|
|
@minikube-bot ok to test |
|
LGTM. Thanks for the PR! |
aaron-prindle
approved these changes
Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
minikube stopwhile nothing is running results in a crash. This patch makescluster.StopHost()swallow the stop-while-stopped error libmachine returns.There are couple of other ways to do this, namely catching the error in cmd and changing
libmachineitself. I figured this is the best place to make the change. Please let me know if the other options are better,