Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow control of user and group ids for mount #1596

Merged
merged 1 commit into from
Jun 22, 2017

Conversation

tmc
Copy link
Contributor

@tmc tmc commented Jun 15, 2017

Fixes #1595

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 15, 2017
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #1596 into master will decrease coverage by 0.08%.
The diff coverage is 18.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1596      +/-   ##
==========================================
- Coverage   38.78%   38.69%   -0.09%     
==========================================
  Files          51       51              
  Lines        2604     2610       +6     
==========================================
  Hits         1010     1010              
- Misses       1417     1422       +5     
- Partials      177      178       +1
Impacted Files Coverage Δ
pkg/minikube/cluster/cluster.go 44.44% <0%> (ø) ⬆️
pkg/minikube/cluster/commands.go 55.55% <0%> (-2.34%) ⬇️
cmd/minikube/cmd/mount.go 7.31% <50%> (+2.31%) ⬆️
pkg/minikube/kubeconfig/config.go 51.42% <0%> (-1.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 084eeaf...0580cc0. Read the comment docs.

@r2d4
Copy link
Contributor

r2d4 commented Jun 15, 2017

@minikube-bot ok to test

@tmc
Copy link
Contributor Author

tmc commented Jun 15, 2017

Failures appear to be name resolution related.

@tmc
Copy link
Contributor Author

tmc commented Jun 19, 2017

@r2d4 can we run these again?

@r2d4
Copy link
Contributor

r2d4 commented Jun 19, 2017

@minikube-bot retest this please

@r2d4
Copy link
Contributor

r2d4 commented Jun 19, 2017

the two test failures are OK - the kvm-alt driver is a problem I need to debug with the integration test machine itself and the other looks like a flake

@dlorenc dlorenc merged commit c5becb3 into kubernetes:master Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants