Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO: Update conmon from v2.0.24 to v2.1.2 #14545

Merged
merged 2 commits into from
Jul 29, 2022
Merged

ISO: Update conmon from v2.0.24 to v2.1.2 #14545

merged 2 commits into from
Jul 29, 2022

Conversation

spowelljr
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 11, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2022
@spowelljr spowelljr changed the title Update conmon from v2.0.24 to v2.1.2 ISO: Update conmon from v2.0.24 to v2.1.2 Jul 12, 2022
@spowelljr
Copy link
Member Author

ok-to-build-iso

medyagh
medyagh reviewed Jul 12, 2022
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once the test results look sane, the code looks good to me

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, building a new ISO failed.
See the logs at: https://storage.cloud.google.com/minikube-builds/logs/14545/73f231c/iso_build.txt

@spowelljr
Copy link
Member Author

spowelljr commented Jul 12, 2022 •
edited
Loading

gluster-fs returning 404, will rebuild tomorrow

@spowelljr
Copy link
Member Author

ok-to-build-iso

2 similar comments
@spowelljr
Copy link
Member Author

ok-to-build-iso

@spowelljr
Copy link
Member Author

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 16, 2022
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 18, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14545) |
+----------------+----------+---------------------+
| minikube start | 57.1s    | 57.0s               |
| enable ingress | 26.6s    | 27.5s               |
+----------------+----------+---------------------+

Times for minikube ingress: 26.1s 26.0s 26.6s 25.1s 29.0s
Times for minikube (PR 14545) ingress: 25.6s 25.6s 28.6s 28.5s 29.1s

Times for minikube start: 55.7s 56.9s 60.4s 58.6s 54.0s
Times for minikube (PR 14545) start: 56.8s 56.5s 55.9s 58.3s 57.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14545) |
+----------------+----------+---------------------+
| minikube start | 28.2s    | 28.5s               |
| enable ingress | 22.8s    | 24.0s               |
+----------------+----------+---------------------+

Times for minikube start: 28.3s 28.1s 27.8s 29.1s 27.6s
Times for minikube (PR 14545) start: 28.5s 27.4s 28.7s 29.6s 28.3s

Times for minikube ingress: 23.0s 23.9s 21.4s 22.9s 22.9s
Times for minikube (PR 14545) ingress: 24.4s 22.9s 23.4s 22.9s 26.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14545) |
+----------------+----------+---------------------+
| minikube start | 23.5s    | 23.6s               |
| enable ingress | 30.8s    | 27.3s               |
+----------------+----------+---------------------+

Times for minikube start: 23.8s 23.4s 23.2s 23.9s 23.1s
Times for minikube (PR 14545) start: 23.0s 23.9s 23.7s 23.2s 24.0s

Times for minikube ingress: 27.4s 32.4s 39.4s 27.4s 27.4s
Times for minikube (PR 14545) ingress: 27.4s 27.0s 27.4s 27.4s 27.4s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestDownloadOnlyKic (gopogh) 0.65 (chart)
Docker_macOS TestDownloadOnly/v1.24.2/preload-exists (gopogh) 0.65 (chart)
Hyperkit_macOS TestNoKubernetes/serial/StartWithStopK8s (gopogh) 1.99 (chart)
Docker_macOS TestNetworkPlugins/group/calico/Start (gopogh) 5.44 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/DeployApp (gopogh) 12.93 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/FirstStart (gopogh) 12.93 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh) 12.93 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/SecondStart (gopogh) 14.41 (chart)
Hyperkit_macOS TestPause/serial/SecondStartNoReconfiguration (gopogh) 19.46 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 29.31 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 29.31 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 29.31 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 30.51 (chart)
KVM_Linux TestPause/serial/SecondStartNoReconfiguration (gopogh) 31.37 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 41.38 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 41.38 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 41.38 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 42.37 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 46.85 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 72.22 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 73.98 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 79.47 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 81.46 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 81.46 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 82.12 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/DNS (gopogh) 82.12 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 95.30 (chart)
KVM_Linux TestMultiNode/serial/ValidateNameConflict (gopogh) 98.46 (chart)
Docker_Linux_containerd TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestDownloadOnly/v1.16.0/preload-exists (gopogh) 100.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klaases, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit 26254bc into kubernetes:master Jul 29, 2022
@spowelljr spowelljr deleted the updateConmon branch July 29, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh left review comments

@klaases klaases klaases approved these changes

@blueelvis blueelvis Awaiting requested review from blueelvis

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@spowelljr @minikube-bot @minikube-pr-bot @k8s-ci-robot @medyagh @klaases