Show the container runtime when running without kubernetes #13432 #14200

Gimb0 · 2022-05-20T14:03:26Z

fixes #13432
In summary it is to show the runtime used when --no-kubernetes option is used to start minikube.
Also improves the readability of the sentence "Starting minikube without Kubernetes {machine name} in cluster {cluster}" by removing the machine name.

Changes to UI
Before:

After:

Create a showNotK8sVersionInfo func to output the runtime and runtime version

When minikube is started without kubernetes, check runtime is compatible and if so call func to output runtime and runtime version

"Starting minikube without Kubernetes {Machine Name} in cluster {cluster}" doesn't make sense so removing the Machine name var from output.

linux-foundation-easycla · 2022-05-20T14:03:30Z

The committers listed above are authorized under a signed CLA.

✅ login: Gimb0 (123c2bb, b8b62b9, 71baac3)

k8s-ci-robot · 2022-05-20T14:03:34Z

Welcome @Gimb0!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-05-20T14:03:34Z

Hi @Gimb0. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

minikube-bot · 2022-05-20T14:05:05Z

Can one of the admins verify this patch?

Gimb0 · 2022-05-25T10:37:13Z

@afbjorklund - Can you please review this PR and give me any feedback you may have?

afbjorklund

Output (and code) looks good to me, thanks for fixing!

afbjorklund · 2022-05-25T20:11:02Z

/ok-to-test

minikube-pr-bot · 2022-05-25T21:34:46Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14200) |
+----------------+----------+---------------------+
| minikube start | 51.8s    | 50.8s               |
| enable ingress | 29.4s    | 29.1s               |
+----------------+----------+---------------------+

Times for minikube start: 53.0s 51.3s 51.7s 52.0s 51.1s
Times for minikube (PR 14200) start: 51.1s 51.2s 50.4s 50.5s 50.6s

Times for minikube ingress: 29.6s 29.1s 29.6s 29.6s 29.2s
Times for minikube (PR 14200) ingress: 29.6s 29.1s 29.6s 28.6s 28.6s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14200) |
+-------------------+----------+---------------------+
| minikube start    | 26.0s    | 25.2s               |
| ⚠️  enable ingress | 22.4s    | 34.8s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 29.2s 25.1s 26.0s 24.5s 25.2s
Times for minikube (PR 14200) start: 25.7s 25.3s 24.6s 25.3s 24.9s

Times for minikube ingress: 22.4s 21.9s 22.9s 22.9s 21.9s
Times for minikube (PR 14200) ingress: 22.9s 23.0s 23.0s 21.9s 82.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14200) |
+----------------+----------+---------------------+
| minikube start | 30.1s    | 32.5s               |
| enable ingress | 23.6s    | 23.5s               |
+----------------+----------+---------------------+

Times for minikube ingress: 18.9s 21.9s 22.4s 32.4s 22.4s
Times for minikube (PR 14200) ingress: 22.0s 18.9s 21.9s 32.4s 22.4s

Times for minikube start: 35.3s 29.2s 28.8s 28.3s 28.7s
Times for minikube (PR 14200) start: 29.4s 32.9s 30.3s 40.4s 29.3s

minikube-pr-bot · 2022-05-25T22:38:40Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Cloud_Shell	TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/ImageCommands/Setup (gopogh)	0.00 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh)	0.00 (chart)
Docker_macOS	TestPause/serial/VerifyStatus (gopogh)	0.00 (chart)
Docker_macOS	TestPreload (gopogh)	0.00 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/bridge/Localhost (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestNetworkPlugins/group/custom-weave/NetCatPod (gopogh)	0.00 (chart)
Docker_macOS	TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh)	1.00 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh)	1.01 (chart)
Hyper-V_Windows	TestStartStop/group/embed-certs/serial/Pause (gopogh)	3.26 (chart)
Docker_macOS	TestRunningBinaryUpgrade (gopogh)	9.09 (chart)
Docker_Linux_containerd	TestNoKubernetes/serial/StartNoArgs (gopogh)	10.20 (chart)
Docker_macOS	TestMissingContainerUpgrade (gopogh)	12.12 (chart)
Docker_macOS	TestFunctional/parallel/DashboardCmd (gopogh)	15.00 (chart)
Docker_macOS	TestKubernetesUpgrade (gopogh)	16.16 (chart)
Docker_macOS	TestStoppedBinaryUpgrade/Upgrade (gopogh)	18.56 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/custom-weave/Start (gopogh)	23.46 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh)	29.49 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh)	29.49 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh)	30.77 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh)	34.15 (chart)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/DeployApp (gopogh)	35.90 (chart)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/FirstStart (gopogh)	36.71 (chart)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh)	37.18 (chart)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/SecondStart (gopogh)	38.75 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

pkg/minikube/node/config.go

sharifelgamal · 2022-05-27T20:51:51Z

There's also a lint issue: pkg/minikube/node/start.go:105: File is not gofmt-ed with -s (gofmt)

Correct lint with gofmt -s pkg/minikube/node/start.go

Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>

minikube-pr-bot · 2022-05-30T12:23:59Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14200) |
+----------------+----------+---------------------+
| minikube start | 51.7s    | 50.5s               |
| enable ingress | 29.5s    | 26.7s               |
+----------------+----------+---------------------+

Times for minikube start: 54.3s 50.0s 50.6s 52.0s 51.3s
Times for minikube (PR 14200) start: 49.0s 50.2s 50.7s 51.4s 51.4s

Times for minikube (PR 14200) ingress: 25.0s 26.0s 27.5s 29.0s 26.0s
Times for minikube ingress: 29.1s 30.1s 29.0s 30.1s 29.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14200) |
+----------------+----------+---------------------+
| minikube start | 24.6s    | 24.1s               |
| enable ingress | 23.6s    | 23.0s               |
+----------------+----------+---------------------+

Times for minikube start: 29.0s 24.0s 23.0s 23.4s 23.8s
Times for minikube (PR 14200) start: 23.6s 24.2s 23.8s 24.7s 24.3s

Times for minikube ingress: 22.4s 22.9s 23.4s 26.4s 22.9s
Times for minikube (PR 14200) ingress: 21.9s 23.4s 23.9s 22.9s 22.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14200) |
+----------------+----------+---------------------+
| minikube start | 32.1s    | 30.4s               |
| enable ingress | 23.7s    | 22.9s               |
+----------------+----------+---------------------+

Times for minikube ingress: 22.4s 22.4s 22.4s 32.4s 18.9s
Times for minikube (PR 14200) ingress: 18.9s 22.0s 32.4s 18.9s 22.4s

Times for minikube (PR 14200) start: 32.2s 29.7s 28.9s 32.5s 28.5s
Times for minikube start: 30.4s 29.1s 40.2s 28.8s 32.1s

minikube-pr-bot · 2022-05-30T13:26:56Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh)	0.00 (chart)
Docker_macOS	TestPause/serial/VerifyStatus (gopogh)	0.00 (chart)
Docker_macOS	TestPreload (gopogh)	0.00 (chart)
Hyperkit_macOS	TestNoKubernetes/serial/Stop (gopogh)	0.00 (chart)
Docker_macOS	TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh)	1.00 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh)	1.01 (chart)
Docker_macOS	TestRunningBinaryUpgrade (gopogh)	9.09 (chart)
Docker_Linux_containerd	TestStoppedBinaryUpgrade/Upgrade (gopogh)	9.73 (chart)
Docker_macOS	TestMissingContainerUpgrade (gopogh)	12.12 (chart)
Docker_macOS	TestKubernetesUpgrade (gopogh)	16.16 (chart)
Docker_macOS	TestStoppedBinaryUpgrade/Upgrade (gopogh)	18.56 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh)	29.49 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh)	29.49 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh)	30.77 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh)	34.15 (chart)
Docker_Linux	TestNetworkPlugins/group/false/DNS (gopogh)	39.00 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/FirstStart (gopogh)	42.31 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/SecondStart (gopogh)	42.31 (chart)
Docker_macOS	TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/newest-cni/serial/Pause (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/no-preload/serial/Pause (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh)	42.86 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/DeployApp (gopogh)	43.04 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh)	43.75 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/Pause (gopogh)	44.90 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

pkg/minikube/node/config.go

pkg/minikube/node/start.go

minikube-pr-bot · 2022-06-18T00:11:16Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14200) |
+----------------+----------+---------------------+
| minikube start | 50.5s    | 51.4s               |
| enable ingress | 29.3s    | 29.4s               |
+----------------+----------+---------------------+

Times for minikube ingress: 29.6s 25.1s 28.1s 34.6s 29.1s
Times for minikube (PR 14200) ingress: 29.0s 28.6s 29.6s 30.0s 29.6s

Times for minikube start: 49.5s 50.7s 52.2s 51.1s 49.0s
Times for minikube (PR 14200) start: 52.7s 50.7s 51.4s 51.4s 50.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14200) |
+----------------+----------+---------------------+
| minikube start | 24.3s    | 24.5s               |
| enable ingress | 23.4s    | 23.1s               |
+----------------+----------+---------------------+

Times for minikube start: 23.8s 24.0s 23.9s 25.1s 24.9s
Times for minikube (PR 14200) start: 24.7s 24.0s 24.5s 24.5s 24.9s

Times for minikube ingress: 23.9s 23.9s 22.9s 22.4s 23.9s
Times for minikube (PR 14200) ingress: 23.9s 23.9s 23.0s 22.4s 22.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14200) |
+----------------+----------+---------------------+
| minikube start | 38.7s    | 34.8s               |
| enable ingress | 23.2s    | 23.1s               |
+----------------+----------+---------------------+

Times for minikube start: 40.3s 43.8s 43.8s 32.2s 33.1s
Times for minikube (PR 14200) start: 29.4s 33.3s 40.0s 39.5s 32.1s

Times for minikube ingress: 22.4s 17.9s 28.4s 18.9s 28.4s
Times for minikube (PR 14200) ingress: 23.4s 18.0s 22.9s 32.4s 18.9s

spowelljr

Thanks for the PR

k8s-ci-robot · 2022-07-01T18:08:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, Gimb0, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [afbjorklund,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Gimb0 added 3 commits May 20, 2022 23:29

Create showNotK8sVersionInfo function

123c2bb

Create a showNotK8sVersionInfo func to output the runtime and runtime version

Check compatibility and call func to output runtime

b8b62b9

When minikube is started without kubernetes, check runtime is compatible and if so call func to output runtime and runtime version

Remove machine name from output

71baac3

"Starting minikube without Kubernetes {Machine Name} in cluster {cluster}" doesn't make sense so removing the Machine name var from output.

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 20, 2022

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 20, 2022

k8s-ci-robot requested review from afbjorklund and medyagh May 20, 2022 14:03

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 20, 2022

klaases mentioned this pull request May 25, 2022

Show the container runtime when running without kubernetes #13432

Closed

afbjorklund approved these changes May 25, 2022

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2022

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 25, 2022

spowelljr reviewed May 27, 2022

View reviewed changes

pkg/minikube/node/config.go Outdated Show resolved Hide resolved

Gimb0 and others added 3 commits May 30, 2022 21:25

Correct lint with gofmt -s

5b80336

Correct lint with gofmt -s pkg/minikube/node/start.go

Rename func showNotK8sVersionInfo to showNoK8sVersionInfo

3e984c3

Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>

Renamed func showNotK8sVersionInfo to showNoK8sVersionInfo

09c1891

spowelljr requested changes May 31, 2022

View reviewed changes

pkg/minikube/node/config.go Outdated Show resolved Hide resolved

pkg/minikube/node/start.go Outdated Show resolved Hide resolved

Gimb0 added 2 commits June 18, 2022 08:28

Move CR compatibility check and add error logging

8c4f6e8

Move CR Check Compatibility to showNoK8sVersionInfo

1c2d4f4

spowelljr approved these changes Jul 1, 2022

View reviewed changes

spowelljr merged commit 6935287 into kubernetes:master Jul 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show the container runtime when running without kubernetes #13432 #14200

Show the container runtime when running without kubernetes #13432 #14200

Gimb0 commented May 20, 2022

linux-foundation-easycla bot commented May 20, 2022 •

edited

Loading

k8s-ci-robot commented May 20, 2022

k8s-ci-robot commented May 20, 2022

minikube-bot commented May 20, 2022

Gimb0 commented May 25, 2022

afbjorklund left a comment

afbjorklund commented May 25, 2022

minikube-pr-bot commented May 25, 2022

minikube-pr-bot commented May 25, 2022

sharifelgamal commented May 27, 2022 •

edited

Loading

minikube-pr-bot commented May 30, 2022

minikube-pr-bot commented May 30, 2022

minikube-pr-bot commented Jun 18, 2022

spowelljr left a comment

k8s-ci-robot commented Jul 1, 2022

Show the container runtime when running without kubernetes #13432 #14200

Show the container runtime when running without kubernetes #13432 #14200

Conversation

Gimb0 commented May 20, 2022

linux-foundation-easycla bot commented May 20, 2022 • edited Loading

k8s-ci-robot commented May 20, 2022

k8s-ci-robot commented May 20, 2022

minikube-bot commented May 20, 2022

Gimb0 commented May 25, 2022

afbjorklund left a comment

Choose a reason for hiding this comment

afbjorklund commented May 25, 2022

minikube-pr-bot commented May 25, 2022

minikube-pr-bot commented May 25, 2022

sharifelgamal commented May 27, 2022 • edited Loading

minikube-pr-bot commented May 30, 2022

minikube-pr-bot commented May 30, 2022

minikube-pr-bot commented Jun 18, 2022

spowelljr left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jul 1, 2022

linux-foundation-easycla bot commented May 20, 2022 •

edited

Loading

sharifelgamal commented May 27, 2022 •

edited

Loading