Fix: "Your cgroup does not allow setting memory"

[kadern0]

Fixes issue #12842

This fix seems to be working, at least for me and a few others (please see the discussion within the issue URL). So far Ubuntu, Arch and Pop!_OS are working but additional testing would be good.

[k8s-ci-robot]

Hi @kadern0. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kadern0
To complete the pull request process, please assign prezha after the PR has been reviewed.
You can assign the PR to them by writing /assign @prezha in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-bot]

Can one of the admins verify this patch?

[kadern0]

I cannot find anywhere this function is being used func IsCgroup2UnifiedMode(). Maybe it could be removed.

[medyagh]

/ok-to-test

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14115) |
+----------------+----------+---------------------+
| minikube start | 52.2s    | 52.0s               |
| enable ingress | 30.5s    | 28.6s               |
+----------------+----------+---------------------+

Times for minikube ingress: 31.1s 30.1s 28.6s 31.0s 31.6s
Times for minikube (PR 14115) ingress: 26.1s 29.1s 30.1s 29.1s 28.6s

Times for minikube start: 52.6s 51.7s 52.0s 53.1s 51.7s
Times for minikube (PR 14115) start: 52.0s 52.6s 50.5s 52.7s 52.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14115) |
+----------------+----------+---------------------+
| minikube start | 25.4s    | 25.1s               |
| enable ingress | 22.3s    | 23.4s               |
+----------------+----------+---------------------+

Times for minikube start: 25.4s 26.6s 24.9s 24.8s 25.3s
Times for minikube (PR 14115) start: 24.8s 24.8s 25.3s 24.9s 25.6s

Times for minikube ingress: 22.4s 21.4s 23.0s 22.9s 21.9s
Times for minikube (PR 14115) ingress: 21.9s 22.9s 23.9s 25.9s 22.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14115) |
+----------------+----------+---------------------+
| minikube start | 41.8s    | 41.1s               |
| enable ingress | 20.6s    | 21.5s               |
+----------------+----------+---------------------+

Times for minikube start: 40.0s 44.1s 43.8s 40.7s 40.6s
Times for minikube (PR 14115) start: 39.8s 40.2s 44.6s 40.5s 40.3s

Times for minikube ingress: 22.5s 17.9s 17.9s 22.4s 22.5s
Times for minikube (PR 14115) ingress: 22.4s 22.4s 18.4s 22.4s 22.0s

[minikube-pr-bot]

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Windows	TestNetworkPlugins/group/kubenet/NetCatPod (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestNoKubernetes/serial/ProfileList (gopogh)	3.81 (chart)
Docker_Windows	TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh)	11.11 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh)	29.49 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh)	29.49 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh)	30.77 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh)	34.15 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/FirstStart (gopogh)	42.31 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/SecondStart (gopogh)	42.31 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/DeployApp (gopogh)	43.04 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh)	43.75 (chart)
Docker_macOS	TestNetworkPlugins/group/kindnet/DNS (gopogh)	48.00 (chart)
Docker_Windows	TestNetworkPlugins/group/auto/Start (gopogh)	49.52 (chart)
Docker_Windows	TestPause/serial/Start (gopogh)	51.43 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/kindnet/Start (gopogh)	54.32 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh)	55.13 (chart)
Docker_Windows	TestNetworkPlugins/group/enable-default-cni/Start (gopogh)	56.19 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh)	56.25 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh)	56.25 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh)	56.79 (chart)
Docker_Windows	TestNoKubernetes/serial/Start (gopogh)	58.25 (chart)
Docker_Windows	TestKubernetesUpgrade (gopogh)	65.71 (chart)
Docker_Windows	TestNetworkPlugins/group/kindnet/Start (gopogh)	65.71 (chart)
Docker_macOS	TestNetworkPlugins/group/calico/Start (gopogh)	66.67 (chart)
Docker_macOS	TestNetworkPlugins/group/kubenet/DNS (gopogh)	67.50 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/calico/Start (gopogh)	71.60 (chart)
Docker_macOS	TestNetworkPlugins/group/bridge/DNS (gopogh)	74.51 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	76.47 (chart)
Docker_macOS	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	77.59 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/bridge/DNS (gopogh)	79.07 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

[kadern0]

@medyagh , thanks for merging. I think #12842 can be closed. What do you think about removing the function IsCgroup2UnifiedMode()?

[spowelljr]

Hi @kadern0, if that function is not used anywhere then feel free to create a PR removing it. I can close #12842, just as a heads up for next time, if you put Fixes #12842 instead of Fixes issue #12842 it will auto close that issue on PR merge.