Get latest valid tag for each image during cacheing #14006
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @ckannon. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
@spowelljr this is the fix we talked about |
|
Can one of the admins verify this patch? |
ckannon
force-pushed
the
fixes/13136
branch
3 times, most recently
from
c4bcb5e to
3f458b4
Compare
Wouldn't this be wrong for if the user wants to use an old kubernetes version ? |
|
Hey Medya, No, earlier versions are drawn from a map of kubernetes version to image version (constants.KubeadmImages[majorMinorVersion][imageName]). This is just the fallback version if the map does not contain the selected k8s version (for example if you use a beta or nightly). In the past, this version was just randomly hardcoded (if you look at the diffs you can see where it was hardcoded to 1.8.4 for coredns, which isn't even a valid version, v1.8.4 is the correct version number). |
|
@spowelljr @medyagh can I snag an ok-to-test please? |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
thank you for clarifying |
|
kvm2 driver with docker runtime Times for minikube ingress: 29.0s 29.5s 27.1s 25.6s 26.5s Times for minikube start: 51.6s 50.6s 51.1s 50.6s 51.3s docker driver with docker runtime |
|
kvm2 driver with docker runtime Times for minikube start: 52.6s 53.2s 50.7s 51.2s 50.2s Times for minikube (PR 14006) ingress: 26.6s 28.5s 29.5s 28.5s 30.1s docker driver with docker runtime Times for minikube start: 28.2s 25.0s 25.4s 24.4s 24.4s Times for minikube ingress: 22.9s 22.9s 23.9s 22.9s 25.9s docker driver with containerd runtime Times for minikube ingress: 31.9s 22.4s 31.9s 22.4s 22.4s Times for minikube start: 29.7s 39.9s 39.5s 39.6s 39.6s |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
|
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
|
kvm2 driver with docker runtime Times for minikube ingress: 28.5s 26.1s 29.5s 28.5s 30.1s Times for minikube start: 52.8s 50.5s 50.1s 51.2s 51.9s docker driver with docker runtime Times for minikube start: 26.6s 25.0s 25.0s 24.5s 25.2s Times for minikube ingress: 22.9s 22.9s 22.9s 22.4s 22.5s docker driver with containerd runtime Times for minikube ingress: 18.9s 18.0s 19.9s 18.0s 17.9s Times for minikube start: 34.1s 33.2s 43.5s 43.5s 44.0s |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
|
/retest-this-please |
|
/retest-this-please |
|
kvm2 driver with docker runtime Times for minikube start: 53.6s 50.1s 50.6s 49.5s 51.0s Times for minikube ingress: 29.6s 28.5s 28.1s 29.6s 27.5s docker driver with docker runtime Times for minikube ingress: 22.9s 25.4s 20.9s 20.4s 25.4s Times for minikube start: 41.7s 24.6s 23.8s 23.8s 24.7s docker driver with containerd runtime Times for minikube start: 34.0s 31.7s 38.1s 38.5s 28.9s Times for minikube ingress: 17.9s 18.9s 22.5s 22.5s 32.4s |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
k8s-ci-robot
added
size/L
|
kvm2 driver with docker runtime Times for minikube start: 52.2s 53.2s 52.8s 54.0s 51.9s Times for minikube ingress: 30.2s 29.2s 30.2s 29.2s 30.2s docker driver with docker runtime Times for minikube ingress: 23.0s 22.0s 22.5s 22.4s 22.0s Times for minikube start: 43.3s 26.1s 25.8s 25.5s 26.3s docker driver with containerd runtime Times for minikube ingress: 22.0s 18.0s 31.0s 52.0s 22.0s Times for minikube (PR 14006) start: 29.6s 32.6s 30.2s 32.2s 29.0s |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
|
kvm2 driver with docker runtime Times for minikube ingress: 28.6s 25.0s 29.6s 25.5s 30.1s Times for minikube start: 52.0s 50.8s 51.4s 51.5s 50.3s docker driver with docker runtime Times for minikube start: 25.3s 23.8s 24.0s 23.9s 24.4s Times for minikube ingress: 20.4s 24.0s 21.4s 22.9s 26.9s docker driver with containerd runtime Times for minikube start: 30.3s 39.7s 44.1s 28.8s 31.8s Times for minikube ingress: 22.4s 22.4s 17.9s 22.4s 18.9s |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckannon, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Nope, earlier versions are drawn from a map of kubernetes version to image
version. This is just the fallback version if the map does not contain the
selected k8s version (for example if you use a beta or nightly). In the
past, this version was just randomly hardcoded (if you look at the diffs
you can see where)
…On Thu, Apr 21, 2022, 5:33 p.m. Medya Ghazizadeh ***@***.***> wrote:
fixes #13136 <#13136> Get
tags from k8s.gcr.io, fall back to hard coded tag if cannot get
Wouldn't this be wrong for if the user wants to use an old kubernetes
version ?
for example minikube start --kubernetes-version=1.17.1 ? in that case is
this PR gonna try to use Latest Pause image for that kuberentes version
first ? If yes then the PR is wrong
—
Reply to this email directly, view it on GitHub
<#14006 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AS2EZY65H44OMILOXJVSS2TVGHCTVANCNFSM5UAKZNSA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
fixes #13136
Get tags from k8s.gcr.io, fall back to hard coded tag if cannot get