Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON output to minikube delete #13979

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Apr 18, 2022

Closes #13961

  1. Added -o or --output flag to minikube delete
  2. Removed duplicate Deleting register step from Deleting action
  3. Add Purging register step to Deleting action
  4. Changed repeat steps from Step to Styled
$ minikube delete --all --purge -o json
{"specversion":"1.0","id":"2d0d5bff-5a3b-4958-a0f8-3da6d4a2cefb","source":"https://minikube.sigs.k8s.io/","type":"io.k8s.sigs.minikube.info","datacontenttype":"application/json","data":{"message":"Removed all traces of the \"minikube\" cluster."}}
{"specversion":"1.0","id":"c1c41195-092d-47d6-a089-5771b87e2f82","source":"https://minikube.sigs.k8s.io/","type":"io.k8s.sigs.minikube.step","datacontenttype":"application/json","data":{"currentstep":"2","message":"Successfully deleted all profiles","name":"Done","totalsteps":"3"}}
{"specversion":"1.0","id":"f6f04a5e-1d22-446d-8199-9ddb81b9c355","source":"https://minikube.sigs.k8s.io/","type":"io.k8s.sigs.minikube.step","datacontenttype":"application/json","data":{"currentstep":"3","message":"Successfully purged minikube directory located at - [/Users/powellsteven/.minikube]","name":"Puring home dir","totalsteps":"3"}}

Why was Step replaced to Styled?
Steps are supposed to be distinct, the problem arises with delete --all. Multiple profiles may be deleted with a single command, causing duplicates of the same step to be logged.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2022
@medyagh
Copy link
Member

medyagh commented Apr 19, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 19, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13979) |
+----------------+----------+---------------------+
| minikube start | 51.1s    | 50.6s               |
| enable ingress | 29.6s    | 29.5s               |
+----------------+----------+---------------------+

Times for minikube start: 51.7s 51.1s 51.1s 49.8s 51.7s
Times for minikube (PR 13979) start: 50.8s 49.3s 50.4s 51.8s 51.0s

Times for minikube ingress: 29.5s 30.0s 30.5s 29.6s 28.5s
Times for minikube (PR 13979) ingress: 29.5s 30.0s 29.6s 30.0s 28.5s

docker driver with docker runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10
docker driver with containerd runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10

@medyagh medyagh merged commit e77e17b into kubernetes:master Apr 21, 2022
@spowelljr spowelljr deleted the deleteJSON branch April 21, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add JSON output option to minikube delete
4 participants