Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --disable-metrics flag #13802

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Conversation

spowelljr
Copy link
Member

Fixes #13656

Problem:
Implemented #13189 which increased the housekeeping interval to help alleviate CPU usage. However, this has seemed to completely disable metrics reporting and we have been getting numerous reports such as #13620.

Solution:
Removed increasing the housekeeping interval by default. Added a --disable-metrics (false by default) flag which will increase the housekeeping interval again and disable the metrics reporting for people that want to do so for CPU usage improvements.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 16, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2022
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 16, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13802) |
+----------------+----------+---------------------+
| minikube start | 52.8s    | 52.6s               |
| enable ingress | 29.2s    | 27.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 26.6s 29.0s 30.0s 30.1s 30.1s
Times for minikube (PR 13802) ingress: 28.6s 25.1s 29.6s 27.1s 26.1s

Times for minikube start: 54.4s 51.7s 53.8s 51.5s 52.6s
Times for minikube (PR 13802) start: 52.4s 52.4s 53.0s 52.3s 52.7s

docker driver with docker runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10
docker driver with containerd runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10

Copy link
Contributor

@klaases klaases left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klaases, sharifelgamal, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [sharifelgamal,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestPause/serial/PauseAgain (gopogh) 6.76 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/VerifyKubernetesImages (gopogh) 7.79 (chart)
Docker_macOS TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 8.97 (chart)
Docker_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 8.97 (chart)
Hyperkit_macOS TestFunctional/parallel/DashboardCmd (gopogh) 9.49 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 9.66 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/SecondStart (gopogh) 10.13 (chart)
Docker_macOS TestPause/serial/Start (gopogh) 11.03 (chart)
Docker_macOS TestNoKubernetes/serial/StartWithK8s (gopogh) 11.72 (chart)
Docker_macOS TestNoKubernetes/serial/StartWithStopK8s (gopogh) 11.81 (chart)
Docker_macOS TestNoKubernetes/serial/ProfileList (gopogh) 11.85 (chart)
Docker_macOS TestNoKubernetes/serial/StartNoArgs (gopogh) 11.85 (chart)
Docker_macOS TestNoKubernetes/serial/Stop (gopogh) 11.85 (chart)
Docker_macOS TestNetworkPlugins/group/auto/Start (gopogh) 12.40 (chart)
Docker_macOS TestNetworkPlugins/group/cilium/Start (gopogh) 12.40 (chart)
Docker_macOS TestNetworkPlugins/group/false/Start (gopogh) 12.40 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 14.73 (chart)
Docker_macOS TestNoKubernetes/serial/Start (gopogh) 16.78 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/custom-weave/Start (gopogh) 22.40 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/Start (gopogh) 24.81 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh) 27.12 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/EnableAddonAfterStop (gopogh) 27.12 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/EnableAddonWhileActive (gopogh) 27.12 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 27.12 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/Stop (gopogh) 27.12 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 27.12 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/VerifyKubernetesImages (gopogh) 27.12 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 27.12 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 27.12 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/EnableAddonAfterStop (gopogh) 27.12 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit 535d0b6 into kubernetes:master Mar 16, 2022
@spowelljr spowelljr deleted the removeHousekeeping branch March 16, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minikube upper than 1.24 fail to generate metrics container_cpu_system_seconds_total as a counter
5 participants