Upgrade cri-dockerd to fix the socket path #13563
Conversation
The v0.2.0 had the socket as cri-docker.sock, while the installer are using cri-dockerd.sock Also fix the output of cri-dockerd --version, to use the git commit instead of just "HEAD".
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
|
ok-to-build-iso |
|
ok-to-build-image |
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
@sharifelgamal : I verified this locally, using ❗ Specified Kubernetes version 1.24.0-alpha.2 is newer than the newest supported version: v1.23.4-rc.0 🐳 Preparing Kubernetes v1.24.0-alpha.2 on Docker 20.10.12 ... 🏄 Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default $ minikube ssh -- sudo crictl version
Version: 0.1.0
RuntimeName: docker
RuntimeVersion: 20.10.12
RuntimeApiVersion: 1.41.0
$ minikube ssh -- sudo crictl --version
crictl version v1.21.0You can still start e.g. The only difference is in the contents of the This is because it is still using the "docker" container runtime. Only thing that happened was that the CRI proxy moved a bit.
|
|
Currently there is some confusion in the upstream documentation: https://kubernetes.io/docs/tasks/administer-cluster/migrating-from-dockershim/ But it is being fixed: KIC output: ISO output: The container runtime is the same, independent on the Kubernetes version:
|
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Hi @afbjorklund, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
|
Hi @afbjorklund, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further. |
|
kvm2 driver with docker runtime Times for minikube ingress: 29.7s 29.2s 29.7s 31.2s 29.2s Times for minikube (PR 13563) start: 55.1s 54.5s 54.3s 55.2s 54.4s docker driver with docker runtime Times for minikube ingress: 24.0s 23.0s 23.0s 23.5s 23.1s Times for minikube start: 33.0s 28.0s 28.1s 28.7s 29.4s docker driver with containerd runtime Times for minikube start: 39.0s 44.0s 43.9s 44.0s 45.2s Times for minikube ingress: 20.5s 24.0s 24.0s 23.0s 51.0s |
|
kvm2 driver with docker runtime Times for minikube start: 53.9s 52.0s 53.3s 52.3s 52.6s Times for minikube ingress: 29.6s 29.6s 25.6s 29.6s 29.1s docker driver with docker runtime Times for minikube start: 43.8s 27.1s 26.0s 26.8s 26.2s Times for minikube ingress: 22.0s 23.0s 21.9s 22.4s 22.4s docker driver with containerd runtime Times for minikube start: 44.2s 46.5s 45.5s 45.8s 42.0s Times for minikube ingress: 23.4s 19.0s 21.0s 19.0s 23.0s |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, sharifelgamal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The v0.2.0 had the socket as cri-docker.sock,
while the installer are using cri-dockerd.sock
Also fix the output of cri-dockerd --version,
to use the git commit instead of just "HEAD".
Closes #13545