Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --disable-optimizations flag #13340

Merged
merged 6 commits into from
Jan 25, 2022
Merged

Add --disable-optimizations flag #13340

merged 6 commits into from
Jan 25, 2022

Conversation

spowelljr
Copy link
Member

Related #13325

Added --disable-optimizations flag that disables setting kubelet.housekeeping-interval=5m and disables scaling down CoreDNS from default 2 to 1 replicas.

Fixed extra configs not being set on restart if another extra config flag set in Cloud Shell environment.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 12, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2022
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 12, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13340) |
+----------------+----------+---------------------+
| minikube start | 44.2s    | 44.1s               |
| enable ingress | 29.2s    | 29.0s               |
+----------------+----------+---------------------+

Times for minikube ingress: 30.1s 29.0s 28.5s 29.6s 29.0s
Times for minikube (PR 13340) ingress: 29.0s 29.1s 29.6s 28.5s 28.6s

Times for minikube start: 44.2s 44.5s 43.6s 43.5s 45.0s
Times for minikube (PR 13340) start: 43.8s 45.6s 44.2s 43.9s 43.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13340) |
+----------------+----------+---------------------+
| minikube start | 26.1s    | 25.9s               |
| enable ingress | 23.1s    | 22.9s               |
+----------------+----------+---------------------+

Times for minikube start: 26.3s 26.0s 26.0s 26.2s 26.3s
Times for minikube (PR 13340) start: 25.9s 26.0s 25.7s 25.9s 25.9s

Times for minikube ingress: 22.4s 24.9s 22.9s 22.4s 23.0s
Times for minikube (PR 13340) ingress: 24.4s 21.9s 22.4s 22.9s 22.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13340) |
+----------------+----------+---------------------+
| minikube start | 42.9s    | 43.5s               |
| enable ingress | 23.7s    | 23.3s               |
+----------------+----------+---------------------+

Times for minikube start: 41.2s 45.7s 41.2s 40.9s 45.5s
Times for minikube (PR 13340) start: 42.3s 43.4s 44.7s 40.8s 46.2s

Times for minikube ingress: 22.9s 28.9s 23.5s 23.4s 19.9s
Times for minikube (PR 13340) ingress: 22.9s 22.9s 28.9s 22.9s 18.9s

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13340) |
+----------------+----------+---------------------+
| minikube start | 45.5s    | 44.1s               |
| enable ingress | 29.2s    | 28.4s               |
+----------------+----------+---------------------+

Times for minikube start: 49.3s 45.2s 43.7s 44.8s 44.4s
Times for minikube (PR 13340) start: 44.2s 44.9s 43.9s 43.9s 43.5s

Times for minikube ingress: 28.1s 28.6s 30.1s 30.1s 29.1s
Times for minikube (PR 13340) ingress: 28.6s 28.6s 25.0s 30.1s 29.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13340) |
+----------------+----------+---------------------+
| minikube start | 27.1s    | 26.8s               |
| enable ingress | 22.7s    | 22.1s               |
+----------------+----------+---------------------+

Times for minikube start: 30.3s 26.3s 26.6s 26.0s 26.3s
Times for minikube (PR 13340) start: 27.1s 26.7s 26.2s 26.9s 27.0s

Times for minikube (PR 13340) ingress: 21.4s 22.9s 21.5s 22.9s 21.9s
Times for minikube ingress: 22.4s 22.9s 21.9s 23.0s 23.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13340) |
+----------------+----------+---------------------+
| minikube start | 42.3s    | 43.6s               |
| enable ingress | 23.1s    | 21.5s               |
+----------------+----------+---------------------+

Times for minikube (PR 13340) ingress: 22.9s 22.9s 19.9s 18.9s 22.9s
Times for minikube ingress: 19.9s 23.4s 29.4s 23.4s 19.4s

Times for minikube start: 35.9s 42.7s 45.7s 41.0s 46.0s
Times for minikube (PR 13340) start: 42.6s 41.4s 45.1s 46.3s 42.7s

@klaases
Copy link
Contributor

klaases commented Jan 24, 2022

Hi @spowelljr, is this PR ready for review / merge?

@spowelljr
Copy link
Member Author

Hi @spowelljr, is this PR ready for review / merge?

@klaases It's ready for review

medyagh
medyagh requested changes Jan 25, 2022
View reviewed changes
cmd/minikube/cmd/start_flags.go Outdated Show resolved Hide resolved
spowelljr and others added 2 commits January 24, 2022 17:07
@spowelljr @medyagh
Update cmd/minikube/cmd/start_flags.go
3eaf0f6 
Co-authored-by: Medya Ghazizadeh <medyagh@users.noreply.github.com>
@spowelljr
generate-docs
398906e
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13340) |
+----------------+----------+---------------------+
| minikube start | 65.2s    | 64.9s               |
| enable ingress | 28.7s    | 28.0s               |
+----------------+----------+---------------------+

Times for minikube start: 70.0s 64.4s 63.3s 64.6s 63.5s
Times for minikube (PR 13340) start: 65.4s 64.5s 65.6s 64.5s 64.5s

Times for minikube ingress: 30.1s 29.1s 25.5s 29.5s 29.5s
Times for minikube (PR 13340) ingress: 26.0s 29.1s 29.1s 30.1s 25.6s

docker driver with docker runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10
docker driver with containerd runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube start --driver=docker --container-runtime=containerd]: waiting for minikube: exit status 81

@spowelljr spowelljr merged commit fa5f67c into kubernetes:master Jan 25, 2022
@spowelljr spowelljr deleted the addDisableOptimization branch January 25, 2022 02:51
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestDownloadOnly/v1.16.0/cached-images (gopogh) n/a
Docker_macOS TestDownloadOnly/v1.23.2/cached-images (gopogh) n/a
Docker_macOS TestDownloadOnly/v1.23.3-rc.0/cached-images (gopogh) n/a
KVM_Linux_containerd TestNoKubernetes/serial/Start (gopogh) n/a
Docker_Cloud_Shell TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Docker_macOS TestDownloadOnlyKic (gopogh) 0.00 (chart)
Docker_macOS TestErrorSpam/setup (gopogh) 0.00 (chart)
Docker_macOS TestNetworkPlugins/group/custom-weave/Start (gopogh) 0.00 (chart)
Docker_macOS TestSkaffold (gopogh) 0.00 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/VerifyKubernetesImages (gopogh) 0.00 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/VerifyKubernetesImages (gopogh) 0.00 (chart)
Docker_macOS TestStartStop/group/newest-cni/serial/VerifyKubernetesImages (gopogh) 0.00 (chart)
Docker_macOS TestStartStop/group/no-preload/serial/VerifyKubernetesImages (gopogh) 0.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/VerifyKubernetesImages (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/serial/LogsFileCmd (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/custom-weave/Start (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 0.00 (chart)
Hyperkit_macOS TestSkaffold (gopogh) 0.00 (chart)
Hyperkit_macOS TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Hyperkit_macOS TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 0.00 (chart)
Hyperkit_macOS TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Hyperkit_macOS TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 0.00 (chart)
KVM_Linux_containerd TestNetworkPlugins/group/custom-weave/Start (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/embed-certs/serial/EnableAddonWhileActive (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStoppedBinaryUpgrade/Upgrade (gopogh) 0.00 (chart)
Docker_Cloud_Shell TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 100.00 (chart)
Docker_Cloud_Shell TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh) 100.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@prasadkatti prasadkatti Awaiting requested review from prasadkatti

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spowelljr @minikube-pr-bot @klaases @k8s-ci-robot @medyagh