Support mounting with the --no-kubernetes flag #13144
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
kvm2 driver with docker runtime Times for minikube start: 47.8s 47.3s 46.6s 45.4s 46.8s Times for minikube ingress: 30.3s 30.3s 30.7s 30.3s 29.8s docker driver with docker runtime Times for minikube (PR 13144) start: 21.6s 22.5s 22.1s 22.4s 21.4s Times for minikube ingress: 26.9s 26.4s 33.9s 82.0s 26.4s docker driver with containerd runtime Times for minikube start: 26.2s 43.1s 42.2s 42.7s 42.6s Times for minikube ingress: 31.4s 31.4s 31.4s 31.4s 31.4s |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
k8s-ci-robot
added
the
needs-rebase
spowelljr
force-pushed
the
noK8sMount
branch
from
9272ae5
to
57f8c5d
Compare
k8s-ci-robot
removed
the
needs-rebase
|
kvm2 driver with docker runtime Times for minikube (PR 13144) start: 47.9s 48.8s 48.2s 47.9s 47.2s Times for minikube ingress: 30.9s 31.3s 31.8s 30.9s 30.3s docker driver with docker runtime Times for minikube start: 25.4s 23.0s 23.5s 23.5s 23.3s Times for minikube ingress: 33.0s 27.0s 26.0s 26.0s 25.5s docker driver with containerd runtime Times for minikube (PR 13144) start: 43.0s 42.6s 43.4s 42.7s 43.1s Times for minikube ingress: 33.0s 31.0s 31.0s 17.5s 31.0s |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
test/integration/mount_start_test.go
Outdated
| @@ -81,7 +81,7 @@ func TestMountStart(t *testing.T) { | |||
| func validateStartWithMount(ctx context.Context, t *testing.T, profile string) { | |||
| defer PostMortemLogs(t, profile) | |||
|
|
|||
| args := []string{"start", "-p", profile, "--memory=2048", "--mount", "--mount-gid", mountGID, "--mount-msize", mountMSize, "--mount-port", mountPort, "--mount-uid", mountUID} | |||
| args := []string{"start", "-p", profile, "--memory=2048", "--mount", "--mount-gid", mountGID, "--mount-msize", mountMSize, "--mount-port", mountPort, "--mount-uid", mountUID, "--no-kubernetes"} | |||
There was a problem hiding this comment.
are we changing this test to only test with no-kubernetes ? if yes why
There was a problem hiding this comment.
I was going to change it to only test with --no-kubernetes since we're just checking that the start --mount flags are being respected so having k8s running is not important, this will also speed up the test since we're starting two minikube instances and they'll start much faster with --no-kubernetes.
|
Seems some mount tests are failing, going to take a look |
k8s-ci-robot
added
the
needs-rebase
spowelljr
force-pushed
the
noK8sMount
branch
from
57f8c5d
to
2c324b7
Compare
k8s-ci-robot
removed
the
needs-rebase
|
The failing mount tests should be fixed with #13183 |
|
kvm2 driver with docker runtime Times for minikube start: 46.6s 46.7s 48.6s 46.2s 46.4s Times for minikube ingress: 32.3s 29.7s 31.3s 30.7s 40.3s docker driver with docker runtime Times for minikube ingress: 31.9s 28.4s 34.9s 26.9s 26.9s Times for minikube start: 22.1s 22.4s 23.5s 23.6s 22.9s docker driver with containerd runtime Times for minikube start: 47.3s 43.3s 44.1s 43.1s 42.3s Times for minikube ingress: 60.9s 27.9s 23.4s 22.9s 19.4s |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
spowelljr
force-pushed
the
noK8sMount
branch
from
9303747
to
71394a4
Compare
|
kvm2 driver with docker runtime Times for minikube start: 49.8s 46.2s 46.2s 47.5s 46.3s Times for minikube ingress: 30.7s 30.8s 31.4s 31.3s 31.2s docker driver with docker runtime Times for minikube ingress: 25.9s 26.9s 34.0s 26.4s 25.9s Times for minikube start: 24.5s 23.0s 22.2s 22.7s 21.6s docker driver with containerd runtime Times for minikube ingress: 33.5s 29.9s 29.0s 21.9s 21.9s Times for minikube start: 25.8s 41.7s 42.7s 41.6s 42.0s |
|
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
Fixes #13003
Problem:
If the
--no-kubernetesflag is used, file mounting is skipped.Solution:
Make sure mounting occurs whether
--no-kubernetesis passed or not.