Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically set kubernetes config for btrfs storage driver #12990

Merged
merged 6 commits into from
Dec 4, 2021

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Nov 19, 2021

Related #7923
Fixes #11932

Add advice if user is using btrfs storage driver to pass the --feature-gates="LocalStorageCapacityIsolation=false" flag to their start command.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 19, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 30, 2021
pkg/minikube/driver/driver.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 2, 2021
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 2, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12990) |
+----------------+----------+---------------------+
| minikube start | 47.1s    | 46.3s               |
| enable ingress | 31.6s    | 31.7s               |
+----------------+----------+---------------------+

Times for minikube start: 49.5s 45.4s 46.8s 46.8s 47.1s
Times for minikube (PR 12990) start: 46.1s 45.8s 46.4s 46.0s 47.2s

Times for minikube ingress: 32.2s 31.9s 31.3s 31.8s 30.8s
Times for minikube (PR 12990) ingress: 31.8s 32.3s 31.3s 31.3s 31.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12990) |
+----------------+----------+---------------------+
| minikube start | 22.0s    | 21.3s               |
| enable ingress | 29.9s    | 30.9s               |
+----------------+----------+---------------------+

Times for minikube (PR 12990) ingress: 33.9s 28.9s 27.9s 35.9s 28.0s
Times for minikube ingress: 26.9s 34.4s 26.9s 26.9s 34.4s

Times for minikube start: 23.0s 21.8s 21.4s 22.0s 21.7s
Times for minikube (PR 12990) start: 21.3s 21.4s 21.2s 21.4s 21.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12990) |
+----------------+----------+---------------------+
| minikube start | 37.3s    | 40.3s               |
| enable ingress | 30.0s    | 29.8s               |
+----------------+----------+---------------------+

Times for minikube (PR 12990) start: 42.1s 36.4s 41.6s 40.4s 40.9s
Times for minikube start: 24.8s 41.6s 37.5s 42.0s 40.5s

Times for minikube ingress: 32.0s 31.9s 24.1s 29.9s 32.4s
Times for minikube (PR 12990) ingress: 29.9s 25.4s 33.4s 27.9s 32.4s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/EnableAddonWhileActive (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 0.00 (chart)
KVM_Linux_containerd TestCertOptions (gopogh) 0.96 (chart)
KVM_Linux_containerd TestNetworkPlugins/group/cilium/Start (gopogh) 0.96 (chart)
KVM_Linux_containerd TestStartStop/group/no-preload/serial/DeployApp (gopogh) 0.97 (chart)
KVM_Linux_containerd TestStartStop/group/no-preload/serial/EnableAddonWhileActive (gopogh) 0.97 (chart)
KVM_Linux_containerd TestStartStop/group/no-preload/serial/FirstStart (gopogh) 0.97 (chart)
Docker_Windows TestRunningBinaryUpgrade (gopogh) 6.00 (chart)
Hyperkit_macOS TestMountStart/serial/VerifyMountFirst (gopogh) 6.30 (chart)
Hyperkit_macOS TestMountStart/serial/VerifyMountPostDelete (gopogh) 6.30 (chart)
Hyperkit_macOS TestMountStart/serial/VerifyMountSecond (gopogh) 6.30 (chart)
Hyperkit_macOS TestMountStart/serial/VerifyMountPostStop (gopogh) 6.35 (chart)
Docker_macOS TestJSONOutput/pause/Command (gopogh) 8.39 (chart)
Hyper-V_Windows TestNoKubernetes/serial/Start (gopogh) 9.49 (chart)
Docker_Windows TestPause/serial/PauseAgain (gopogh) 11.11 (chart)
Docker_Windows TestKubernetesUpgrade (gopogh) 20.00 (chart)
Docker_Windows TestNetworkPlugins/group/calico/NetCatPod (gopogh) 20.00 (chart)
Hyperkit_macOS TestFunctional/serial/ComponentHealth (gopogh) 26.77 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/DNS (gopogh) 42.19 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 55.81 (chart)
Hyper-V_Windows TestMultiNode/serial/CopyFile (gopogh) 63.50 (chart)
Docker_Windows TestNetworkPlugins/group/custom-weave/Start (gopogh) 70.00 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 73.68 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/DNS (gopogh) 73.74 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/DNS (gopogh) 75.00 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 76.79 (chart)
Docker_macOS TestNetworkPlugins/group/calico/Start (gopogh) 77.44 (chart)
Docker_Windows TestFunctional/parallel/DryRun (gopogh) 82.00 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 82.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr
Copy link
Member Author

User tested it and confirmed it works
#11932 (comment)

@medyagh medyagh merged commit f1d63df into kubernetes:master Dec 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr deleted the btrfsErrorMessage branch December 4, 2021 00:36
@medyagh medyagh changed the title Add advice if user using btrfs storage driver Automatically set kubernetes config for btrfs storage driver Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exiting due to K8S_KUBELET_NOT_RUNNING
4 participants