Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker-env with new PowerShell versions #12870

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

spowelljr
Copy link
Member

Fixes #12860

Implements machine-drivers/machine#37

Using the latest version of PowerShell from https://github.com/PowerShell/PowerShell resulted in me getting the error There are no more files. when running shell.Detect().

The error is coming from https://github.com/machine-drivers/machine/blob/master/libmachine/shell/shell_windows.go#L34 after being called from https://github.com/machine-drivers/machine/blob/master/libmachine/shell/shell_windows.go#L67.

The reason it's even hitting those parts of the code is because the .exe file of the new PowerShell is pwsh.exe while we're only checking for powershell.

Added a mapping from pwsh to powershell.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2021
@sharifelgamal
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 9, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12870) |
+----------------+----------+---------------------+
| minikube start | 47.0s    | 46.7s               |
| enable ingress | 30.4s    | 31.0s               |
+----------------+----------+---------------------+

Times for minikube ingress: 30.3s 30.7s 30.3s 30.3s 30.2s
Times for minikube (PR 12870) ingress: 30.3s 30.8s 30.7s 31.7s 31.3s

Times for minikube start: 49.4s 46.1s 48.1s 45.5s 45.9s
Times for minikube (PR 12870) start: 47.1s 46.1s 47.4s 46.1s 47.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12870) |
+----------------+----------+---------------------+
| minikube start | 22.1s    | 21.3s               |
| enable ingress | 26.6s    | 30.3s               |
+----------------+----------+---------------------+

Times for minikube start: 22.5s 20.9s 22.8s 21.1s 23.2s
Times for minikube (PR 12870) start: 20.5s 20.4s 21.5s 22.8s 21.2s

Times for minikube (PR 12870) ingress: 28.5s 33.9s 33.9s 28.4s 26.9s
Times for minikube ingress: 25.9s 26.9s 26.4s 27.5s 26.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12870) |
+----------------+----------+---------------------+
| minikube start | 40.1s    | 40.5s               |
| enable ingress | 31.9s    | 31.8s               |
+----------------+----------+---------------------+

Times for minikube start: 26.6s 43.6s 43.4s 43.7s 43.2s
Times for minikube (PR 12870) start: 42.9s 43.3s 30.2s 43.3s 43.0s

Times for minikube ingress: 32.9s 31.9s 31.9s 31.4s 31.4s
Times for minikube (PR 12870) ingress: 26.9s 31.4s 37.5s 31.4s 31.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
none_Linux TestFunctional/serial/ExtraConfig (gopogh) 0.00 (chart)
Hyper-V_Windows TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 3.74 (chart)
none_Linux TestFunctional/serial/ComponentHealth (gopogh) 4.91 (chart)
KVM_Linux_containerd TestStoppedBinaryUpgrade/Upgrade (gopogh) 6.17 (chart)
Hyper-V_Windows TestNetworkPlugins/group/flannel/Start (gopogh) 22.43 (chart)
Hyper-V_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 26.17 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/Start (gopogh) 28.57 (chart)
Hyper-V_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 28.97 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 75.40 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/DNS (gopogh) 82.26 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/DNS (gopogh) 83.87 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 84.92 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartNoArgs (gopogh) 86.21 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 100.00 (chart)
Docker_Windows TestMountStart/serial/RestartStopped (gopogh) 100.00 (chart)
Docker_Windows TestMountStart/serial/StartWithMountFirst (gopogh) 100.00 (chart)
Docker_Windows TestMountStart/serial/StartWithMountSecond (gopogh) 100.00 (chart)
Docker_Windows TestMountStart/serial/Stop (gopogh) 100.00 (chart)
Docker_Windows TestMountStart/serial/VerifyMountFirst (gopogh) 100.00 (chart)
Docker_Windows TestMountStart/serial/VerifyMountPostDelete (gopogh) 100.00 (chart)
Docker_Windows TestMountStart/serial/VerifyMountPostStop (gopogh) 100.00 (chart)
Docker_Windows TestMountStart/serial/VerifyMountSecond (gopogh) 100.00 (chart)
Docker_Windows TestPause/serial/VerifyDeletedResources (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) 100.00 (chart)
Hyper-V_Windows TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
Hyper-V_Windows TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [sharifelgamal,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit 739a16a into kubernetes:master Nov 9, 2021
@spowelljr spowelljr deleted the fixDockerEnvNewPowershell branch November 9, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minikube docker-env incorrectly recognizes shell type in PowerShell 7.1.5
4 participants