Support changing apiserver-ips when restarting minikube

[dimara]

After commit bee6815, we could not change the apiserver-ips after
initial minikube start. Revert to previous behavior where both
apiserver-ips and apiserver-names were taken always into account
and certs were updated accordingly.

Fixes #9818

NOTE: This is more or less #9876 rebased on top of current master.

[k8s-ci-robot]

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

• 4535640 Support changing apiserver-ips when restarting minikube

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Hi @dimara. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dimara
To complete the pull request process, please assign afbjorklund after the PR has been reviewed.
You can assign the PR to them by writing /assign @afbjorklund in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-bot]

Can one of the admins verify this patch?

[dimara]

@spowelljr @andriyDev I re-submitted the PR and again it appears that I don't have the CLA. This does not make much sense
since as I mentioned in #9876 (comment) copying from https://identity.linuxfoundation.org/projects/cncf/employee-signup:

You are already authorized to contribute code to this project through your membership with CNCF - Arrikto Inc..

Should the Arrikto email be the primary GH email? I cannot think of any other reason... Any advice is more than welcome.

Also one more question: I noticed the do-not-merge/invalid-commit-message label. Should I remove the Fixes # from the commit message? Looking at git log I saw lots of commits having it so I don't know what is the "proper" way to do that.

Thanks!

[spowelljr]

Hi @dimara, the author email of all the commits need to be the same email that has signed the CLA. Your commits are with the dimara@arrikto.com email, is that the email that you signed the CLA with?

[RA489]

/check-cla

[dimara]

Hi @spowelljr

Your commits are with the dimara@arrikto.com email, is that the email that you signed the CLA with?

Yes. Here is what my linuxfoundation profile reports at https://identity.linuxfoundation.org/user/me:

and in https://identity.linuxfoundation.org/projects/cncf/employee-signup:

That is why I don't get why the checks fail. Any other idea?

[medyagh]

thank you @dimara