renew minikube certs if expired #12534

sharifelgamal · 2021-09-21T01:14:54Z

(Finally) fixes #10122

This PR will renew any certs that have expired. If the global certs are expired, we assume the profile ones have as well and regen everything.

It also adds the --cert-expiration parameter to minikube start, which will set the certs to expire that far into to the future.

medyagh · 2021-09-21T18:11:57Z

/ok-to-test

medyagh · 2021-09-21T18:26:16Z

good work, let include it in 1.24.0 release, I would like us to put some miles on this PR after its merged to study all the corner cases

minikube-pr-bot · 2021-09-21T19:13:59Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12534) |
+----------------+----------+---------------------+
| minikube start | 49.6s    | 49.2s               |
| enable ingress | 31.9s    | 32.3s               |
+----------------+----------+---------------------+

Times for minikube start: 55.4s 48.7s 47.5s 48.3s 48.3s
Times for minikube (PR 12534) start: 48.8s 48.1s 49.6s 50.8s 48.6s

Times for minikube ingress: 34.4s 30.8s 30.9s 31.8s 31.3s
Times for minikube (PR 12534) ingress: 32.3s 32.4s 32.4s 32.7s 31.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12534) |
+----------------+----------+---------------------+
| minikube start | 21.6s    | 21.8s               |
| enable ingress | 30.0s    | 37.9s               |
+----------------+----------+---------------------+

Times for minikube ingress: 26.5s 28.0s 33.5s 35.5s 26.5s
Times for minikube (PR 12534) ingress: 82.5s 25.9s 27.0s 26.9s 27.0s

Times for minikube start: 21.7s 21.1s 22.1s 21.8s 21.0s
Times for minikube (PR 12534) start: 21.9s 22.3s 22.8s 21.5s 20.7s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12534) |
+----------------+----------+---------------------+
| minikube start | 39.6s    | 44.0s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 30.4s 43.9s 36.4s 43.2s 44.3s
Times for minikube (PR 12534) start: 44.6s 43.9s 43.9s 43.6s 44.1s

minikube-pr-bot · 2021-09-21T20:57:23Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux	TestStartStop/group/newest-cni/serial/SecondStart (gopogh)	0.62 (chart)
Docker_Linux	TestStartStop/group/newest-cni/serial/VerifyKubernetesImages (gopogh)	0.62 (chart)
Docker_Linux	TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh)	1.86 (chart)
KVM_Linux	TestDebPackageInstall/install_amd64_ubuntu_20.04/kvm2-driver (gopogh)	2.27 (chart)
Docker_Linux	TestStartStop/group/newest-cni/serial/Pause (gopogh)	3.73 (chart)
KVM_Linux	TestDebPackageInstall/install_amd64_ubuntu_18.04/kvm2-driver (gopogh)	4.55 (chart)
Docker_Linux_containerd	TestStoppedBinaryUpgrade/MinikubeLogs (gopogh)	7.41 (chart)
Docker_Linux_containerd	TestStoppedBinaryUpgrade/Upgrade (gopogh)	7.41 (chart)
Docker_Linux_containerd	TestFunctional/serial/LogsCmd (gopogh)	11.73 (chart)
Docker_Linux_containerd	TestFunctional/serial/LogsFileCmd (gopogh)	11.73 (chart)
Docker_Linux_containerd	TestPause/serial/Pause (gopogh)	21.60 (chart)
Docker_Linux_containerd	TestPause/serial/VerifyStatus (gopogh)	21.60 (chart)
Docker_Linux_containerd	TestPause/serial/PauseAgain (gopogh)	24.69 (chart)
Docker_Linux_containerd	TestScheduledStopUnix (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2021-09-22T00:29:54Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12534) |
+----------------+----------+---------------------+
| minikube start | 48.8s    | 48.2s               |
| enable ingress | 33.9s    | 32.8s               |
+----------------+----------+---------------------+

Times for minikube start: 50.2s 48.3s 47.7s 48.8s 49.1s
Times for minikube (PR 12534) start: 48.3s 48.7s 46.9s 48.4s 48.9s

Times for minikube ingress: 33.4s 39.9s 32.3s 32.3s 31.8s
Times for minikube (PR 12534) ingress: 32.4s 33.8s 32.8s 32.3s 32.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12534) |
+----------------+----------+---------------------+
| minikube start | 21.5s    | 21.3s               |
| enable ingress | 32.3s    | 31.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 36.4s 27.4s 35.0s 27.9s 34.9s
Times for minikube (PR 12534) ingress: 35.4s 28.4s 28.9s 28.4s 35.4s

Times for minikube start: 23.1s 21.2s 20.8s 21.0s 21.6s
Times for minikube (PR 12534) start: 21.8s 21.8s 20.8s 21.0s 21.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12534) |
+----------------+----------+---------------------+
| minikube start | 40.8s    | 43.2s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.0s 44.1s 42.9s 43.3s 42.5s
Times for minikube (PR 12534) start: 44.0s 42.5s 43.3s 42.8s 43.5s

minikube-pr-bot · 2021-09-22T01:20:38Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12534) |
+----------------+----------+---------------------+
| minikube start | 47.5s    | 47.8s               |
| enable ingress | 32.4s    | 32.8s               |
+----------------+----------+---------------------+

Times for minikube start: 48.6s 47.5s 47.0s 46.7s 47.8s
Times for minikube (PR 12534) start: 48.4s 48.1s 46.8s 47.9s 47.9s

Times for minikube ingress: 32.8s 32.3s 31.3s 32.8s 32.7s
Times for minikube (PR 12534) ingress: 33.3s 32.8s 32.9s 32.8s 32.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12534) |
+----------------+----------+---------------------+
| minikube start | 21.3s    | 20.9s               |
| enable ingress | 36.1s    | 27.8s               |
+----------------+----------+---------------------+

Times for minikube start: 21.9s 21.0s 20.9s 21.1s 21.4s
Times for minikube (PR 12534) start: 20.3s 20.2s 20.4s 22.5s 21.3s

Times for minikube ingress: 34.9s 41.5s 34.9s 33.9s 35.4s
Times for minikube (PR 12534) ingress: 27.4s 28.4s 28.9s 27.4s 26.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12534) |
+----------------+----------+---------------------+
| minikube start | 40.4s    | 43.7s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 42.8s 43.5s 36.5s 36.1s 43.3s
Times for minikube (PR 12534) start: 43.9s 43.5s 43.8s 43.2s 44.3s

minikube-pr-bot · 2021-09-22T02:01:07Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd	TestMissingContainerUpgrade (gopogh)	0.00 (chart)
Docker_Linux	TestMissingContainerUpgrade (gopogh)	0.00 (chart)
Docker_Linux	TestNetworkPlugins/group/auto/Start (gopogh)	0.00 (chart)
Docker_Linux	TestRunningBinaryUpgrade (gopogh)	0.00 (chart)
Docker_Linux	TestStoppedBinaryUpgrade/MinikubeLogs (gopogh)	0.00 (chart)
Docker_Linux	TestStoppedBinaryUpgrade/Upgrade (gopogh)	0.00 (chart)
none_Linux	TestRunningBinaryUpgrade (gopogh)	0.00 (chart)
none_Linux	TestStoppedBinaryUpgrade/MinikubeLogs (gopogh)	0.00 (chart)
none_Linux	TestStoppedBinaryUpgrade/Upgrade (gopogh)	0.00 (chart)
Docker_Windows	TestStoppedBinaryUpgrade/Upgrade (gopogh)	0.71 (chart)
Docker_Windows	TestMissingContainerUpgrade (gopogh)	1.43 (chart)
Docker_Windows	TestRunningBinaryUpgrade (gopogh)	1.43 (chart)
KVM_Linux	TestStoppedBinaryUpgrade/MinikubeLogs (gopogh)	1.96 (chart)
KVM_Linux	TestStoppedBinaryUpgrade/Upgrade (gopogh)	1.96 (chart)
Docker_Windows	TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh)	3.74 (chart)
Docker_Windows	TestStartStop/group/embed-certs/serial/VerifyKubernetesImages (gopogh)	3.74 (chart)
KVM_Linux	TestRunningBinaryUpgrade (gopogh)	3.92 (chart)
Docker_Windows	TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh)	4.63 (chart)
Docker_Windows	TestStartStop/group/embed-certs/serial/SecondStart (gopogh)	4.67 (chart)
Docker_Linux	TestPause/serial/PauseAgain (gopogh)	6.58 (chart)
Docker_Linux	TestStartStop/group/no-preload/serial/Pause (gopogh)	7.24 (chart)
Docker_Windows	TestStartStop/group/embed-certs/serial/Pause (gopogh)	17.76 (chart)
Docker_Windows	TestStoppedBinaryUpgrade/MinikubeLogs (gopogh)	28.57 (chart)
Docker_Windows	TestAddons/Setup (gopogh)	45.71 (chart)
Docker_Windows	TestNetworkPlugins/group/kubenet/DNS (gopogh)	86.05 (chart)
Docker_Linux_containerd	TestScheduledStopUnix (gopogh)	100.00 (chart)
Docker_Windows	TestCertOptions (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2021-09-22T03:33:22Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd	TestMissingContainerUpgrade (gopogh)	0.00 (chart)
Docker_Linux	TestMissingContainerUpgrade (gopogh)	0.00 (chart)
Docker_Linux	TestRunningBinaryUpgrade (gopogh)	0.00 (chart)
Docker_Linux	TestStoppedBinaryUpgrade/MinikubeLogs (gopogh)	0.00 (chart)
Docker_Linux	TestStoppedBinaryUpgrade/Upgrade (gopogh)	0.00 (chart)
none_Linux	TestRunningBinaryUpgrade (gopogh)	0.00 (chart)
none_Linux	TestStoppedBinaryUpgrade/MinikubeLogs (gopogh)	0.00 (chart)
none_Linux	TestStoppedBinaryUpgrade/Upgrade (gopogh)	0.00 (chart)
Docker_Windows	TestStoppedBinaryUpgrade/Upgrade (gopogh)	0.71 (chart)
Docker_Windows	TestMissingContainerUpgrade (gopogh)	1.43 (chart)
Docker_Windows	TestRunningBinaryUpgrade (gopogh)	1.43 (chart)
KVM_Linux	TestStoppedBinaryUpgrade/MinikubeLogs (gopogh)	1.96 (chart)
KVM_Linux	TestStoppedBinaryUpgrade/Upgrade (gopogh)	1.96 (chart)
Docker_Windows	TestNetworkPlugins/group/kindnet/NetCatPod (gopogh)	2.56 (chart)
KVM_Linux	TestRunningBinaryUpgrade (gopogh)	3.92 (chart)
Docker_Linux	TestStartStop/group/embed-certs/serial/Pause (gopogh)	9.87 (chart)
Docker_Windows	TestStartStop/group/old-k8s-version/serial/Pause (gopogh)	17.76 (chart)
Docker_Windows	TestScheduledStopWindows (gopogh)	21.43 (chart)
Docker_Windows	TestMultiNode/serial/CopyFile (gopogh)	25.00 (chart)
Docker_Windows	TestStoppedBinaryUpgrade/MinikubeLogs (gopogh)	28.57 (chart)
Docker_Windows	TestNetworkPlugins/group/false/Start (gopogh)	31.67 (chart)
Docker_Windows	TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh)	36.36 (chart)
Docker_Windows	TestPause/serial/DeletePaused (gopogh)	60.87 (chart)
Docker_Windows	TestNetworkPlugins/group/kubenet/Start (gopogh)	64.17 (chart)
Docker_Windows	TestNetworkPlugins/group/cilium/Start (gopogh)	65.00 (chart)
Docker_Windows	TestNetworkPlugins/group/custom-weave/Start (gopogh)	75.00 (chart)
Docker_Windows	TestNetworkPlugins/group/calico/Start (gopogh)	90.00 (chart)
Docker_Linux_containerd	TestScheduledStopUnix (gopogh)	100.00 (chart)
Docker_Windows	TestCertOptions (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2021-09-22T19:11:30Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12534) |
+----------------+----------+---------------------+
| minikube start | 49.5s    | 49.1s               |
| enable ingress | 32.8s    | 32.3s               |
+----------------+----------+---------------------+

Times for minikube start: 52.3s 49.1s 49.0s 48.8s 48.3s
Times for minikube (PR 12534) start: 51.5s 49.0s 49.1s 47.6s 48.4s

Times for minikube ingress: 33.8s 32.4s 32.3s 32.4s 33.3s
Times for minikube (PR 12534) ingress: 31.9s 32.4s 32.8s 31.8s 32.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12534) |
+----------------+----------+---------------------+
| minikube start | 22.1s    | 21.4s               |
| enable ingress | 33.0s    | 30.2s               |
+----------------+----------+---------------------+

Times for minikube (PR 12534) ingress: 35.0s 27.4s 34.5s 27.0s 26.9s
Times for minikube ingress: 27.5s 35.0s 34.4s 32.5s 35.4s

Times for minikube start: 23.9s 21.0s 21.1s 22.2s 22.1s
Times for minikube (PR 12534) start: 21.5s 21.1s 21.8s 21.5s 21.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12534) |
+----------------+----------+---------------------+
| minikube start | 39.0s    | 43.5s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 27.1s 44.0s 35.9s 43.5s 44.6s
Times for minikube (PR 12534) start: 44.7s 43.4s 43.4s 43.0s 43.2s

minikube-pr-bot · 2021-09-22T21:42:51Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd	TestDebPackageInstall/install_amd64_ubuntu_20.10/kvm2-driver (gopogh)	0.00 (chart)
Docker_Linux	TestDebPackageInstall/install_amd64_ubuntu_20.10/kvm2-driver (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestDebPackageInstall/install_amd64_ubuntu_20.10/kvm2-driver (gopogh)	0.00 (chart)
none_Linux	TestDebPackageInstall/install_amd64_ubuntu_20.04/kvm2-driver (gopogh)	1.00 (chart)
Docker_Linux_containerd	TestDebPackageInstall/install_amd64_ubuntu_20.04/kvm2-driver (gopogh)	1.02 (chart)
KVM_Linux_containerd	TestDebPackageInstall/install_amd64_ubuntu_20.04/kvm2-driver (gopogh)	2.04 (chart)
Docker_Linux	TestDebPackageInstall/install_amd64_ubuntu_20.04/kvm2-driver (gopogh)	2.06 (chart)
none_Linux	TestDebPackageInstall/install_amd64_ubuntu_18.04/kvm2-driver (gopogh)	3.00 (chart)
KVM_Linux_containerd	TestDebPackageInstall/install_amd64_ubuntu_18.04/kvm2-driver (gopogh)	3.06 (chart)
KVM_Linux	TestDebPackageInstall/install_amd64_ubuntu_20.04/kvm2-driver (gopogh)	3.06 (chart)
Docker_Linux_containerd	TestDebPackageInstall/install_amd64_ubuntu_18.04/kvm2-driver (gopogh)	5.10 (chart)
KVM_Linux	TestDebPackageInstall/install_amd64_ubuntu_18.04/kvm2-driver (gopogh)	5.10 (chart)
Docker_Linux	TestDebPackageInstall/install_amd64_ubuntu_18.04/kvm2-driver (gopogh)	5.15 (chart)
Docker_Linux	TestStartStop/group/no-preload/serial/Pause (gopogh)	8.12 (chart)
Docker_Windows	TestStartStop/group/old-k8s-version/serial/Pause (gopogh)	18.42 (chart)
Docker_Linux_containerd	TestPause/serial/Pause (gopogh)	22.36 (chart)
Docker_Linux_containerd	TestPause/serial/VerifyStatus (gopogh)	22.36 (chart)
KVM_Linux_containerd	TestPause/serial/SecondStartNoReconfiguration (gopogh)	23.46 (chart)
Docker_Linux_containerd	TestPause/serial/PauseAgain (gopogh)	26.09 (chart)
Docker_Windows	TestStoppedBinaryUpgrade/MinikubeLogs (gopogh)	28.57 (chart)
Docker_Windows	TestNetworkPlugins/group/false/Start (gopogh)	30.71 (chart)
Docker_Windows	TestPause/serial/VerifyStatus (gopogh)	56.46 (chart)
Docker_Windows	TestPause/serial/DeletePaused (gopogh)	60.69 (chart)
Docker_Windows	TestNetworkPlugins/group/kubenet/Start (gopogh)	64.57 (chart)
Docker_Windows	TestNetworkPlugins/group/cilium/Start (gopogh)	66.14 (chart)
Docker_Windows	TestNetworkPlugins/group/custom-weave/Start (gopogh)	75.59 (chart)
Docker_Windows	TestNetworkPlugins/group/calico/Start (gopogh)	90.55 (chart)
Docker_Linux_containerd	TestScheduledStopUnix (gopogh)	100.00 (chart)
Docker_Windows	TestCertOptions (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2021-09-23T21:53:44Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12534) |
+----------------+----------+---------------------+
| minikube start | 48.4s    | 48.7s               |
| enable ingress | 32.3s    | 32.6s               |
+----------------+----------+---------------------+

Times for minikube ingress: 32.3s 32.8s 32.3s 32.4s 31.8s
Times for minikube (PR 12534) ingress: 33.3s 33.3s 31.9s 32.3s 32.3s

Times for minikube start: 48.7s 47.9s 47.7s 48.8s 49.0s
Times for minikube (PR 12534) start: 48.4s 49.1s 48.1s 49.1s 48.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12534) |
+----------------+----------+---------------------+
| minikube start | 21.7s    | 21.1s               |
| enable ingress | 27.4s    | 31.9s               |
+----------------+----------+---------------------+

Times for minikube ingress: 27.0s 27.9s 27.4s 26.9s 28.0s
Times for minikube (PR 12534) ingress: 34.9s 34.4s 34.4s 28.0s 27.9s

Times for minikube start: 21.5s 21.7s 21.1s 22.9s 21.4s
Times for minikube (PR 12534) start: 21.0s 21.0s 21.1s 20.7s 21.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12534) |
+----------------+----------+---------------------+
| minikube start | 44.2s    | 41.8s               |
| enable ingress | 29.5s    | 33.4s               |
+----------------+----------+---------------------+

Times for minikube start: 43.7s 42.7s 43.6s 47.7s 43.5s
Times for minikube (PR 12534) start: 42.9s 42.0s 44.1s 43.6s 36.3s

Times for minikube (PR 12534) ingress: 32.9s 32.9s 28.4s 36.4s 36.4s
Times for minikube ingress: 28.9s 32.9s 32.9s 32.4s 20.4s

minikube-pr-bot · 2021-09-23T23:39:44Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
KVM_Linux	TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh)	0.00 (chart)
KVM_Linux	TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh)	0.00 (chart)
KVM_Linux	TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh)	0.00 (chart)
KVM_Linux	TestStartStop/group/no-preload/serial/Pause (gopogh)	1.85 (chart)
Docker_Windows	TestStartStop/group/default-k8s-different-port/serial/VerifyKubernetesImages (gopogh)	6.90 (chart)
Docker_Windows	TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh)	7.69 (chart)
Docker_Windows	TestNetworkPlugins/group/auto/NetCatPod (gopogh)	7.84 (chart)
Docker_Windows	TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh)	8.47 (chart)
Docker_Windows	TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh)	9.24 (chart)
Docker_Windows	TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh)	11.21 (chart)
KVM_Linux_containerd	TestPause/serial/SecondStartNoReconfiguration (gopogh)	25.15 (chart)
Docker_Windows	TestStartStop/group/newest-cni/serial/Pause (gopogh)	27.59 (chart)
Docker_Windows	TestStoppedBinaryUpgrade/MinikubeLogs (gopogh)	27.89 (chart)
Docker_Windows	TestPause/serial/VerifyStatus (gopogh)	55.78 (chart)
Docker_Windows	TestNetworkPlugins/group/bridge/Start (gopogh)	61.24 (chart)
Docker_Windows	TestPause/serial/DeletePaused (gopogh)	61.38 (chart)
Docker_Windows	TestNetworkPlugins/group/cilium/Start (gopogh)	65.12 (chart)
Docker_Windows	TestNetworkPlugins/group/kubenet/Start (gopogh)	65.12 (chart)
Docker_Windows	TestNetworkPlugins/group/kindnet/Start (gopogh)	67.44 (chart)
Docker_Windows	TestNetworkPlugins/group/custom-weave/Start (gopogh)	75.19 (chart)
Docker_Windows	TestNetworkPlugins/group/calico/Start (gopogh)	91.47 (chart)
Docker_Linux_containerd	TestScheduledStopUnix (gopogh)	100.00 (chart)
Docker_Windows	TestCertOptions (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

sharifelgamal · 2021-09-24T15:44:39Z

/ok-to-test

minikube-pr-bot · 2021-09-24T16:34:53Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12534) |
+----------------+----------+---------------------+
| minikube start | 48.6s    | 48.2s               |
| enable ingress | 32.8s    | 32.6s               |
+----------------+----------+---------------------+

Times for minikube ingress: 33.3s 33.2s 32.2s 32.8s 32.5s
Times for minikube (PR 12534) ingress: 32.4s 32.3s 33.3s 33.2s 31.8s

Times for minikube start: 49.2s 48.5s 48.9s 47.5s 49.1s
Times for minikube (PR 12534) start: 47.4s 47.9s 48.5s 48.0s 49.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12534) |
+----------------+----------+---------------------+
| minikube start | 21.8s    | 21.8s               |
| enable ingress | 32.2s    | 32.3s               |
+----------------+----------+---------------------+

Times for minikube start: 22.9s 21.1s 21.6s 21.6s 21.7s
Times for minikube (PR 12534) start: 21.2s 22.4s 21.0s 22.6s 21.7s

Times for minikube ingress: 27.4s 34.9s 36.9s 34.4s 27.4s
Times for minikube (PR 12534) ingress: 26.4s 35.9s 27.9s 35.9s 35.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12534) |
+----------------+----------+---------------------+
| minikube start | 37.5s    | 43.2s               |
| enable ingress | 29.3s    | 33.9s               |
+----------------+----------+---------------------+

Times for minikube start: 27.7s 43.3s 29.5s 43.6s 43.6s
Times for minikube (PR 12534) start: 44.7s 43.8s 41.3s 43.1s 42.9s

Times for minikube ingress: 38.4s 36.4s 29.4s 18.9s 23.5s
Times for minikube (PR 12534) ingress: 36.9s 32.9s 32.9s 33.9s 32.9s

minikube-pr-bot · 2021-09-24T18:01:11Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Windows	TestNetworkPlugins/group/false/DNS (gopogh)	8.14 (chart)
Docker_Windows	TestStartStop/group/no-preload/serial/Pause (gopogh)	15.45 (chart)
Docker_Windows	TestStoppedBinaryUpgrade/MinikubeLogs (gopogh)	28.97 (chart)
Docker_Windows	TestAddons/Setup (gopogh)	44.14 (chart)
Docker_Windows	TestNetworkPlugins/group/bridge/Start (gopogh)	60.63 (chart)
Docker_Windows	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	62.12 (chart)
Docker_Windows	TestNetworkPlugins/group/kubenet/Start (gopogh)	65.35 (chart)
Docker_Windows	TestNetworkPlugins/group/cilium/Start (gopogh)	66.93 (chart)
Docker_Windows	TestNetworkPlugins/group/kindnet/DNS (gopogh)	76.32 (chart)
Docker_Windows	TestNetworkPlugins/group/calico/Start (gopogh)	92.91 (chart)
Docker_Linux_containerd	TestScheduledStopUnix (gopogh)	100.00 (chart)
Docker_Windows	TestCertOptions (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

cmd/minikube/cmd/start_flags.go

pkg/minikube/bootstrapper/certs.go

minikube-pr-bot · 2021-09-24T19:35:16Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12534) |
+----------------+----------+---------------------+
| minikube start | 49.0s    | 47.9s               |
| enable ingress | 32.7s    | 32.9s               |
+----------------+----------+---------------------+

Times for minikube start: 50.4s 49.4s 48.1s 47.2s 49.7s
Times for minikube (PR 12534) start: 46.9s 47.7s 48.5s 48.4s 47.8s

Times for minikube ingress: 32.4s 32.4s 31.8s 34.3s 32.8s
Times for minikube (PR 12534) ingress: 33.4s 31.4s 32.8s 33.8s 33.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12534) |
+----------------+----------+---------------------+
| minikube start | 22.0s    | 21.8s               |
| enable ingress | 32.2s    | 29.2s               |
+----------------+----------+---------------------+

Times for minikube ingress: 34.9s 35.9s 35.5s 27.5s 27.4s
Times for minikube (PR 12534) ingress: 35.9s 26.4s 28.4s 28.0s 27.4s

Times for minikube start: 23.9s 21.2s 21.6s 21.3s 21.9s
Times for minikube (PR 12534) start: 22.8s 21.7s 22.5s 20.6s 21.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12534) |
+----------------+----------+---------------------+
| minikube start | 41.2s    | 40.5s               |
| enable ingress | 31.6s    | 34.7s               |
+----------------+----------+---------------------+

Times for minikube start: 27.7s 43.4s 43.4s 43.4s 48.2s
Times for minikube (PR 12534) start: 25.9s 46.0s 43.3s 43.6s 43.7s

Times for minikube (PR 12534) ingress: 42.4s 28.4s 31.9s 37.9s 32.9s
Times for minikube ingress: 35.9s 33.0s 32.9s 27.9s 28.4s

test/integration/cert_options_test.go

k8s-ci-robot · 2021-09-24T20:46:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [medyagh,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

minikube-pr-bot · 2021-09-24T21:38:36Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd	TestStoppedBinaryUpgrade/MinikubeLogs (gopogh)	6.88 (chart)
Docker_Linux_containerd	TestStoppedBinaryUpgrade/Upgrade (gopogh)	6.88 (chart)
Docker_Windows	TestStartStop/group/no-preload/serial/Pause (gopogh)	15.32 (chart)
Docker_Windows	TestStartStop/group/embed-certs/serial/Pause (gopogh)	18.80 (chart)
Docker_Windows	TestStoppedBinaryUpgrade/MinikubeLogs (gopogh)	28.77 (chart)
Docker_Windows	TestNetworkPlugins/group/enable-default-cni/Start (gopogh)	46.09 (chart)
Docker_Windows	TestFunctional/parallel/StatusCmd (gopogh)	46.58 (chart)
Docker_Windows	TestNetworkPlugins/group/bridge/Start (gopogh)	60.94 (chart)
Docker_Windows	TestPause/serial/DeletePaused (gopogh)	63.19 (chart)
Docker_Windows	TestNetworkPlugins/group/kubenet/Start (gopogh)	65.62 (chart)
Docker_Windows	TestNetworkPlugins/group/cilium/Start (gopogh)	67.19 (chart)
Docker_Windows	TestNetworkPlugins/group/kindnet/Start (gopogh)	69.53 (chart)
Docker_Windows	TestNetworkPlugins/group/custom-weave/Start (gopogh)	74.22 (chart)
Docker_Windows	TestNetworkPlugins/group/calico/Start (gopogh)	92.97 (chart)
Docker_Linux_containerd	TestScheduledStopUnix (gopogh)	100.00 (chart)
Docker_Windows	TestAddons/parallel/Registry (gopogh)	100.00 (chart)
Docker_Windows	TestCertOptions (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

renew minikube certs if expired

e5b8f65

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 21, 2021

k8s-ci-robot requested review from blueelvis and prezha September 21, 2021 01:15

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2021

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 21, 2021

make cert expiration configurable and add test

1212848

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 21, 2021

add docstring for TestCertExpiration

5ee889c

don't skip none driver, fix logging

2799f24

make sure to set expiration if not in existing config

77051a3

sharifelgamal mentioned this pull request Sep 22, 2021

Certificate Error #12159

Closed

remove pkg install tests

18d89d5

medyagh reviewed Sep 24, 2021

View reviewed changes

cmd/minikube/cmd/start_flags.go Outdated Show resolved Hide resolved

medyagh reviewed Sep 24, 2021

View reviewed changes

cmd/minikube/cmd/start_flags.go Outdated Show resolved Hide resolved

spowelljr reviewed Sep 24, 2021

View reviewed changes

cmd/minikube/cmd/start_flags.go Outdated Show resolved Hide resolved

spowelljr reviewed Sep 24, 2021

View reviewed changes

pkg/minikube/bootstrapper/certs.go Show resolved Hide resolved

address review comments

4307e83

medyagh reviewed Sep 24, 2021

View reviewed changes

test/integration/cert_options_test.go Show resolved Hide resolved

medyagh approved these changes Sep 24, 2021

View reviewed changes

sharifelgamal merged commit 73d66f0 into kubernetes:master Sep 24, 2021

sharifelgamal deleted the renew-certs branch September 24, 2021 21:53

This was referenced Oct 6, 2021

minikube not getting connect from client #11964

Closed

minikube start error #12646

Closed

medyagh mentioned this pull request Sep 18, 2024

After updating the certificates, all of my deployments were lost: #19134

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

renew minikube certs if expired #12534

renew minikube certs if expired #12534

sharifelgamal commented Sep 21, 2021 •

edited

Loading

medyagh commented Sep 21, 2021

medyagh commented Sep 21, 2021

minikube-pr-bot commented Sep 21, 2021

minikube-pr-bot commented Sep 21, 2021

minikube-pr-bot commented Sep 22, 2021

minikube-pr-bot commented Sep 22, 2021

minikube-pr-bot commented Sep 22, 2021

minikube-pr-bot commented Sep 22, 2021

minikube-pr-bot commented Sep 22, 2021

minikube-pr-bot commented Sep 22, 2021

minikube-pr-bot commented Sep 23, 2021

minikube-pr-bot commented Sep 23, 2021

sharifelgamal commented Sep 24, 2021

minikube-pr-bot commented Sep 24, 2021

minikube-pr-bot commented Sep 24, 2021

minikube-pr-bot commented Sep 24, 2021

k8s-ci-robot commented Sep 24, 2021

minikube-pr-bot commented Sep 24, 2021

renew minikube certs if expired #12534

renew minikube certs if expired #12534

Conversation

sharifelgamal commented Sep 21, 2021 • edited Loading

medyagh commented Sep 21, 2021

medyagh commented Sep 21, 2021

minikube-pr-bot commented Sep 21, 2021

minikube-pr-bot commented Sep 21, 2021

minikube-pr-bot commented Sep 22, 2021

minikube-pr-bot commented Sep 22, 2021

minikube-pr-bot commented Sep 22, 2021

minikube-pr-bot commented Sep 22, 2021

minikube-pr-bot commented Sep 22, 2021

minikube-pr-bot commented Sep 22, 2021

minikube-pr-bot commented Sep 23, 2021

minikube-pr-bot commented Sep 23, 2021

sharifelgamal commented Sep 24, 2021

minikube-pr-bot commented Sep 24, 2021

minikube-pr-bot commented Sep 24, 2021

minikube-pr-bot commented Sep 24, 2021

k8s-ci-robot commented Sep 24, 2021

minikube-pr-bot commented Sep 24, 2021

sharifelgamal commented Sep 21, 2021 •

edited

Loading