Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Ingress Addon #12443

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Fix Ingress Addon #12443

merged 2 commits into from
Sep 13, 2021

Conversation

sharifelgamal
Copy link
Collaborator

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 9, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2021
@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 9, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12443) |
+----------------+----------+---------------------+
| minikube start | 48.5s    | 47.8s               |
| enable ingress | 32.1s    | 32.1s               |
+----------------+----------+---------------------+

Times for minikube start: 52.7s 47.3s 47.3s 47.9s 47.4s
Times for minikube (PR 12443) start: 48.0s 48.0s 47.7s 47.1s 48.1s

Times for minikube ingress: 31.9s 32.8s 31.3s 30.8s 33.7s
Times for minikube (PR 12443) ingress: 31.8s 32.7s 31.7s 31.4s 32.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12443) |
+----------------+----------+---------------------+
| minikube start | 21.5s    | 21.1s               |
| enable ingress | 26.9s    | 26.7s               |
+----------------+----------+---------------------+

Times for minikube (PR 12443) start: 22.4s 21.2s 20.9s 20.5s 20.7s
Times for minikube start: 22.4s 21.3s 21.3s 21.4s 20.9s

Times for minikube (PR 12443) ingress: 26.9s 25.9s 26.9s 26.9s 26.9s
Times for minikube ingress: 26.4s 26.9s 26.4s 26.4s 28.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12443) |
+----------------+----------+---------------------+
| minikube start | 37.1s    | 39.3s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 25.7s 36.3s 43.4s 36.7s 43.4s
Times for minikube (PR 12443) start: 29.8s 43.8s 43.2s 43.2s 36.6s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestDebPackageInstall/install_amd64_debian (gopogh) 10/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_debian (gopogh) 9/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_debian (gopogh) latest/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_debian (gopogh) sid/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) 18.04/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) 20.04/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) 20.10/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) latest/kvm2-driver (chart)
Docker_Linux TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 1.32 (chart)
Docker_Linux_containerd_arm64 TestErrorSpam/setup (gopogh) 2.68 (chart)
KVM_Linux TestAddons/parallel/Ingress (gopogh) 2.78 (chart)
Docker_Linux_docker_arm64 TestFunctional/parallel/SaveImage (gopogh) 4.55 (chart)
Hyperkit_macOS TestNetworkPlugins/group/calico/ControllerPod (gopogh) 4.62 (chart)
Hyperkit_macOS TestMultiNode/serial/RestartMultiNode (gopogh) 5.80 (chart)
Docker_Linux_crio TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 5.92 (chart)
Hyperkit_macOS TestMultiNode/serial/DeleteNode (gopogh) 6.52 (chart)
Docker_Linux_crio TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 6.58 (chart)
KVM_Linux TestAddons/parallel/Olm (gopogh) 6.94 (chart)
Hyperkit_macOS TestMultiNode/serial/FreshStart2Nodes (gopogh) 7.19 (chart)
Hyperkit_macOS TestMultiNode/serial/RestartKeepsNodes (gopogh) 7.25 (chart)
Docker_Linux_docker_arm64 TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 7.58 (chart)
Docker_Linux_docker_arm64 TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) 7.58 (chart)
Hyperkit_macOS TestMultiNode/serial/DeployApp2Nodes (gopogh) 8.63 (chart)
Hyperkit_macOS TestMultiNode/serial/PingHostFrom2Pods (gopogh) 8.63 (chart)
Hyperkit_macOS TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 8.63 (chart)
Docker_Linux_docker_arm64 TestFunctional/parallel/PersistentVolumeClaim (gopogh) 9.09 (chart)
Docker_Linux_docker_arm64 TestMultiNode/serial/AddNode (gopogh) 9.09 (chart)
Docker_Linux_docker_arm64 TestMultiNode/serial/FreshStart2Nodes (gopogh) 9.09 (chart)
Docker_Linux_docker_arm64 TestMultiNode/serial/StartAfterStop (gopogh) 9.09 (chart)
Hyperkit_macOS TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 9.35 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12443) |
+----------------+----------+---------------------+
| minikube start | 50.3s    | 49.6s               |
| enable ingress | 31.2s    | 31.7s               |
+----------------+----------+---------------------+

Times for minikube (PR 12443) start: 48.9s 47.8s 49.4s 50.8s 51.0s
Times for minikube start: 53.8s 48.4s 49.1s 51.7s 48.4s

Times for minikube ingress: 31.3s 31.4s 30.8s 30.9s 31.8s
Times for minikube (PR 12443) ingress: 32.9s 31.3s 30.8s 31.8s 31.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12443) |
+----------------+----------+---------------------+
| minikube start | 21.4s    | 21.5s               |
| enable ingress | 26.5s    | 37.7s               |
+----------------+----------+---------------------+

Times for minikube start: 21.4s 21.3s 21.7s 21.1s 21.2s
Times for minikube (PR 12443) start: 20.8s 22.0s 21.5s 22.0s 21.0s

Times for minikube ingress: 25.9s 27.0s 25.9s 26.4s 27.4s
Times for minikube (PR 12443) ingress: 82.4s 26.0s 27.5s 26.9s 25.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12443) |
+----------------+----------+---------------------+
| minikube start | 43.5s    | 39.8s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 43.8s 43.6s 44.0s 43.4s 42.7s
Times for minikube (PR 12443) start: 25.7s 43.1s 43.2s 43.8s 43.1s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyperkit_macOS TestMultiNode/serial/StopMultiNode (gopogh) 0.00 (chart)
KVM_Linux_crio TestFunctional/parallel/DashboardCmd (gopogh) 0.00 (chart)
Hyperkit_macOS TestPreload (gopogh) 0.71 (chart)
Hyperkit_macOS TestMultiNode/serial/ProfileList (gopogh) 4.26 (chart)
Hyperkit_macOS TestMultiNode/serial/StopNode (gopogh) 4.26 (chart)
KVM_Linux_containerd TestScheduledStopUnix (gopogh) 5.84 (chart)
Docker_Linux_crio_arm64 TestFunctional/parallel/BuildImage (gopogh) 6.58 (chart)
Hyperkit_macOS TestMultiNode/serial/AddNode (gopogh) 7.09 (chart)
Hyperkit_macOS TestMultiNode/serial/StartAfterStop (gopogh) 7.09 (chart)
Hyperkit_macOS TestMultiNode/serial/DeleteNode (gopogh) 7.91 (chart)
KVM_Linux TestAddons/parallel/Olm (gopogh) 8.28 (chart)
Hyperkit_macOS TestNetworkPlugins/group/calico/Start (gopogh) 8.51 (chart)
Hyperkit_macOS TestMultiNode/serial/RestartKeepsNodes (gopogh) 8.63 (chart)
Hyperkit_macOS TestMultiNode/serial/FreshStart2Nodes (gopogh) 9.22 (chart)
Hyperkit_macOS TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 9.22 (chart)
Hyperkit_macOS TestFunctional/parallel/DashboardCmd (gopogh) 9.93 (chart)
Hyperkit_macOS TestFunctional/parallel/SaveImage (gopogh) 9.93 (chart)
Hyperkit_macOS TestMultiNode/serial/DeployApp2Nodes (gopogh) 11.35 (chart)
Hyperkit_macOS TestMultiNode/serial/PingHostFrom2Pods (gopogh) 11.35 (chart)
Hyperkit_macOS TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 12.06 (chart)
Hyperkit_macOS TestSkaffold (gopogh) 12.77 (chart)
KVM_Linux_containerd TestAddons/parallel/HelmTiller (gopogh) 15.86 (chart)
Docker_Linux_containerd TestPause/serial/Pause (gopogh) 16.45 (chart)
Docker_Linux_containerd TestPause/serial/VerifyStatus (gopogh) 16.45 (chart)
KVM_Linux_containerd TestPause/serial/PauseAgain (gopogh) 17.53 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/no-preload/serial/SecondStart (gopogh) 18.05 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/no-preload/serial/FirstStart (gopogh) 18.38 (chart)
Docker_Linux_containerd TestPause/serial/PauseAgain (gopogh) 19.08 (chart)
KVM_Linux_containerd TestAddons/parallel/CSI (gopogh) 20.00 (chart)
Docker_Linux_crio TestStartStop/group/default-k8s-different-port/serial/Stop (gopogh) 24.84 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [medyagh,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sharifelgamal sharifelgamal merged commit ced6e5a into kubernetes:master Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@blueelvis blueelvis Awaiting requested review from blueelvis

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sharifelgamal @spowelljr @minikube-pr-bot @k8s-ci-robot @medyagh