Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metallb addon: Ask user for config values even if already set #12437

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

spowelljr
Copy link
Member

Closes #12051

Problem:
Currently, once you configure the metallb addon you can't change the values unless you manully edit the config.json file or start a new cluster.

Solution:
Now asks user to enter config values every time minikube addons configure metallb is run.

Before (doesn't ask for values second time):

$ minikube addons configure metallb
-- Enter Load Balancer Start IP: 1.1.1.1
-- Enter Load Balancer End IP: 1.1.1.1
    ▪ Using image metallb/speaker:v0.9.6
    ▪ Using image metallb/controller:v0.9.6
✅  metallb was successfully configured

$ minikube addons configure metallb
    ▪ Using image metallb/speaker:v0.9.6
    ▪ Using image metallb/controller:v0.9.6
✅  metallb was successfully configured

After (asks for values second time):

$ minikube addons configure metallb
-- Enter Load Balancer Start IP: 1.1.1.1
-- Enter Load Balancer End IP: 1.1.1.1
    ▪ Using image metallb/speaker:v0.9.6
    ▪ Using image metallb/controller:v0.9.6
✅  metallb was successfully configured

$ minikube addons configure metallb
-- Enter Load Balancer Start IP: 1.1.1.1
-- Enter Load Balancer End IP: 1.1.1.1
    ▪ Using image metallb/speaker:v0.9.6
    ▪ Using image metallb/controller:v0.9.6
✅  metallb was successfully configured

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 8, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit 27465c3 into kubernetes:master Sep 8, 2021
@spowelljr spowelljr deleted the allowMetallbReconfigure branch September 8, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot reconfigure metallb addon
3 participants