Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #11348 zsh completion broken #12420

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Conversation

Keyhoh
Copy link
Contributor

@Keyhoh Keyhoh commented Sep 7, 2021

Fix #11348.

In GenerateZshCompletion changed GenBashCompletion to GenZshCompletion.

This is a minimal fix.
However, there is a much bigger and better fix.
Please consider #11329.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 7, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @Keyhoh!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @Keyhoh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 7, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@Keyhoh Keyhoh force-pushed the issue/11348 branch 2 times, most recently from bd29170 to 19cf354 Compare September 7, 2021 13:15
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 7, 2021
@medyagh medyagh self-requested a review September 28, 2021 02:07
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2021
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing please take a look

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2021
@Keyhoh
Copy link
Contributor Author

Keyhoh commented Sep 28, 2021

Build is failing please take a look

it seems to be due to timeout.
https://github.com/kubernetes/minikube/actions/runs/1209563749

build successful on my pc.

@spowelljr
Copy link
Member

I'll re-run the job

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Keyhoh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2021
@spowelljr
Copy link
Member

spowelljr commented Sep 29, 2021

@Keyhoh Because you have Fix #11348 in your PR description, upon merging this PR, that issue will be closed. Will this fully solve the issue listed? Just making sure you're aware, if you don't want merging this PR to close that issue just remove Fix and it won't close it.

@Keyhoh
Copy link
Contributor Author

Keyhoh commented Sep 29, 2021

@Keyhoh Because you have Fix #11348 in your PR description, upon merging this PR, that issue will be closed. Will this fully solve the issue listed?

yes, will solve.

@spowelljr spowelljr merged commit a502d3e into kubernetes:master Sep 29, 2021
@Keyhoh Keyhoh mentioned this pull request Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minikube image zsh completion broken
5 participants