Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for tcsh in docker-env subcommand #12332

Merged
merged 4 commits into from
Aug 25, 2021
Merged

Add support for tcsh in docker-env subcommand #12332

merged 4 commits into from
Aug 25, 2021

Conversation

andriyDev
Copy link
Contributor

fixes #12308.

Result:

$ SHELL=tcsh minikube -p minikube docker-env
setenv DOCKER_TLS_VERIFY "1";
setenv DOCKER_HOST "tcp://192.168.50.145:2376";
setenv DOCKER_CERT_PATH "/home/andriydzikh/.minikube/certs";
setenv MINIKUBE_ACTIVE_DOCKERD "minikube";

: "To point your shell to minikube's docker-daemon, run:"
: eval `minikube -p minikube docker-env`

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 23, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 23, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2021
@sharifelgamal
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 24, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12332) |
+----------------+----------+---------------------+
| minikube start | 49.5s    | 50.4s               |
| enable ingress | 35.4s    | 35.8s               |
+----------------+----------+---------------------+

Times for minikube start: 50.6s 48.8s 48.3s 50.9s 48.8s
Times for minikube (PR 12332) start: 50.8s 48.4s 49.6s 50.6s 52.7s

Times for minikube ingress: 40.3s 32.8s 40.4s 31.9s 31.4s
Times for minikube (PR 12332) ingress: 32.4s 32.9s 32.4s 39.8s 41.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12332) |
+----------------+----------+---------------------+
| minikube start | 22.7s    | 22.5s               |
| enable ingress | 33.9s    | 34.2s               |
+----------------+----------+---------------------+

Times for minikube start: 23.4s 23.1s 23.1s 22.5s 21.4s
Times for minikube (PR 12332) start: 21.7s 23.3s 22.3s 22.3s 22.9s

Times for minikube ingress: 31.5s 35.5s 35.0s 32.0s 35.5s
Times for minikube (PR 12332) ingress: 32.0s 35.5s 36.0s 31.5s 36.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12332) |
+----------------+----------+---------------------+
| minikube start | 41.6s    | 44.2s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 32.1s 45.1s 43.6s 43.8s 43.5s
Times for minikube (PR 12332) start: 45.6s 44.2s 43.4s 43.9s 43.7s

@sharifelgamal
Copy link
Collaborator

the integration test fails :(

functional_test.go:512: (dbg) Non-zero exit: /bin/tcsh -c "setenv SHELL /bin/tcsh && eval `out/minikube-linux-amd64 -p functional-20210824212146-7539 docker-env` && out/minikube-linux-amd64 status -p functional-20210824212146-7539": fork/exec /bin/tcsh: no such file or directory (342.239µs)

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux TestFunctional/parallel/DockerEnv/tcsh (gopogh) n/a
KVM_Linux TestFunctional/parallel/DockerEnv/tcsh (gopogh) n/a
KVM_Linux TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 0.00 (chart)
Docker_Linux_containerd_arm64 TestStartStop/group/no-preload/serial/EnableAddonWhileActive (gopogh) 0.73 (chart)
KVM_Linux_crio TestPause/serial/SecondStartNoReconfiguration (gopogh) 2.74 (chart)
KVM_Linux_crio TestPause/serial/Start (gopogh) 2.74 (chart)
Docker_Linux_containerd TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 2.78 (chart)
Docker_Linux_containerd TestStoppedBinaryUpgrade/Upgrade (gopogh) 4.76 (chart)
Docker_Windows TestPause/serial/Pause (gopogh) 5.22 (chart)
Docker_Windows TestPause/serial/PauseAgain (gopogh) 5.26 (chart)
Docker_Linux_containerd_arm64 TestNetworkPlugins/group/calico/Start (gopogh) 6.62 (chart)
Docker_Windows TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 8.65 (chart)
Docker_Windows TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 8.65 (chart)
Docker_Windows TestStartStop/group/old-k8s-version/serial/VerifyKubernetesImages (gopogh) 8.65 (chart)
Docker_macOS TestNetworkPlugins/group/false/DNS (gopogh) 10.64 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 11.11 (chart)
Docker_Windows TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 12.84 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/Pause (gopogh) 16.67 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/Start (gopogh) 17.02 (chart)
Docker_Windows TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 18.27 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/Ingress (gopogh) 18.84 (chart)
Hyperkit_macOS TestDebPackageInstall/install_amd64_debian (gopogh) 10/kvm2-driver (chart)
Hyperkit_macOS TestDebPackageInstall/install_amd64_debian (gopogh) 9/kvm2-driver (chart)
Hyperkit_macOS TestDebPackageInstall/install_amd64_debian (gopogh) latest/kvm2-driver (chart)
Hyperkit_macOS TestDebPackageInstall/install_amd64_debian (gopogh) sid/kvm2-driver (chart)
Hyperkit_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) 18.04/kvm2-driver (chart)
Hyperkit_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) 20.04/kvm2-driver (chart)
Hyperkit_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) 20.10/kvm2-driver (chart)
Hyperkit_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) latest/kvm2-driver (chart)
Hyperkit_macOS TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 19.82 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@andriyDev
Copy link
Contributor Author

I removed the tcsh test from the functional tests - but I kept the refactoring of the code, incase it can be used in the future.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12332) |
+----------------+----------+---------------------+
| minikube start | 53.1s    | 53.3s               |
| enable ingress | 35.0s    | 40.5s               |
+----------------+----------+---------------------+

Times for minikube start: 53.6s 53.1s 53.3s 52.6s 53.1s
Times for minikube (PR 12332) start: 54.7s 53.5s 52.4s 53.5s 52.5s

Times for minikube ingress: 33.9s 42.4s 32.0s 33.9s 32.9s
Times for minikube (PR 12332) ingress: 41.0s 37.5s 41.0s 41.5s 41.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12332) |
+----------------+----------+---------------------+
| minikube start | 23.5s    | 23.1s               |
| enable ingress | 33.4s    | 34.8s               |
+----------------+----------+---------------------+

Times for minikube start: 23.9s 24.0s 22.9s 22.7s 23.9s
Times for minikube (PR 12332) start: 23.4s 22.9s 23.7s 23.0s 22.6s

Times for minikube ingress: 35.1s 32.6s 31.6s 35.6s 32.1s
Times for minikube (PR 12332) ingress: 35.6s 35.6s 30.5s 36.6s 35.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12332) |
+----------------+----------+---------------------+
| minikube start | 41.3s    | 47.2s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 28.5s 44.1s 44.8s 44.6s 44.4s
Times for minikube (PR 12332) start: 47.2s 44.4s 48.2s 48.4s 47.6s

@sharifelgamal sharifelgamal merged commit 2bb50e4 into kubernetes:master Aug 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, andriyDev, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_crio TestNetworkPlugins/group/calico/DNS (gopogh) 5.10 (chart)
Docker_Linux_crio_arm64 TestKubernetesUpgrade (gopogh) 5.30 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/no-preload/serial/FirstStart (gopogh) 13.51 (chart)
Docker_Windows TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 18.35 (chart)
Docker_macOS TestFunctional/serial/ComponentHealth (gopogh) 20.34 (chart)
Docker_macOS TestFunctional/serial/ExtraConfig (gopogh) 20.34 (chart)
Docker_Linux_containerd_arm64 TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 27.66 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/Pause (gopogh) 32.74 (chart)
Docker_Windows TestAddons/Setup (gopogh) 50.00 (chart)
Docker_Linux_containerd TestStartStop/group/newest-cni/serial/Pause (gopogh) 55.41 (chart)
Docker_Linux_crio_arm64 TestAddons/parallel/GCPAuth (gopogh) 57.14 (chart)
Docker_Linux_crio_arm64 TestAddons/parallel/CSI (gopogh) 58.57 (chart)
Docker_Linux_crio_arm64 TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) 58.82 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 60.34 (chart)
Docker_Linux_crio_arm64 TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 60.71 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 61.15 (chart)
Docker_Linux_crio_arm64 TestFunctional/parallel/MountCmd/any-port (gopogh) 61.43 (chart)
Docker_Linux_crio_arm64 TestFunctional/parallel/PersistentVolumeClaim (gopogh) 62.14 (chart)
Docker_Linux_crio_arm64 TestMultiNode/serial/DeployApp2Nodes (gopogh) 62.86 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/DNS (gopogh) 63.33 (chart)
Docker_macOS TestNetworkPlugins/group/calico/Start (gopogh) 66.67 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 67.26 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 67.92 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/DNS (gopogh) 72.09 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 72.57 (chart)
Docker_Windows TestNetworkPlugins/group/custom-weave/Start (gopogh) 73.45 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 76.47 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/Start (gopogh) 82.30 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 87.61 (chart)
Docker_Linux_docker_arm64 TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 88.16 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbjorklund afbjorklund afbjorklund approved these changes

@sharifelgamal sharifelgamal sharifelgamal approved these changes

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker-env script for tcsh is not correct
5 participants
@andriyDev @sharifelgamal @minikube-pr-bot @k8s-ci-robot @afbjorklund