Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Buildroot to 2021.02 LTS with Linux 4.19 #12268

Merged
merged 2 commits into from
Aug 16, 2021

Conversation

afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Aug 14, 2021

Upgrade kernel minor version to distribution default

Add patch to allow building go inside minikube mod

Add sysctl override to revert systemd 245+ rp_filter

BR2_PACKAGE_LUAJIT
Make sure to build lua required for sysdig

BR2_PACKAGE_LZ4_PROGS
Make sure to build lz4 required for preload

BR2_PACKAGE_UTIL_LINUX_BINARIES
Make sure to build lsblk required for automount


Squashed version of PR #11688, but upgraded from 2021.02.3 to 2021.02.4 and with systemd patch for cilium

Go compiler upgraded from go1.15.13 to go1.15.15, rebased back-port to be able to build in minikube module

For #11652

Closes #11810

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 14, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 14, 2021
@afbjorklund

This comment has been minimized.

@afbjorklund

This comment has been minimized.

Upgrade kernel minor version to distribution default

Add patch to allow building go inside minikube mod

Add sysctl override to revert systemd 245+ rp_filter

BR2_PACKAGE_LUAJIT
    Make sure to build lua required for sysdig

BR2_PACKAGE_LZ4_PROGS
    Make sure to build lz4 required for preload

BR2_PACKAGE_UTIL_LINUX_BINARIES
    Make sure to build lsblk required for automount
@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, building a new ISO failed.
See the logs at: https://storage.cloud.google.com/minikube-builds/logs/12268/iso-80/iso_build.txt

@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Aug 14, 2021

ok-to-build-iso

@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Aug 14, 2021

Built OK here

                         _             _            
            _         _ ( )           ( )           
  ___ ___  (_)  ___  (_)| |/')  _   _ | |_      __  
/' _ ` _ `\| |/' _ `\| || , <  ( ) ( )| '_`\  /'__`\
| ( ) ( ) || || ( ) || || |\`\ | (_) || |_) )(  ___/
(_) (_) (_)(_)(_) (_)(_)(_) (_)`\___/'(_,__/'`\____)

$ uname -a
Linux minikube 4.19.202 #1 SMP Sat Aug 14 21:54:23 CEST 2021 x86_64 GNU/Linux
$ grep PRETTY /etc/os-release 
PRETTY_NAME="Buildroot 2021.02.4"

Seems to work OK, with --cni=cilium

@minikube-bot

This comment has been minimized.

@afbjorklund

This comment has been minimized.

@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 14, 2021
@medyagh
Copy link
Member

medyagh commented Aug 15, 2021

ok-to-test

@afbjorklund
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 16, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12268) |
+----------------+----------+---------------------+
| minikube start | 49.4s    | 47.9s               |
| enable ingress | 31.4s    | 31.3s               |
+----------------+----------+---------------------+

Times for minikube start: 52.6s 50.0s 49.0s 47.7s 47.7s
Times for minikube (PR 12268) start: 50.3s 47.1s 47.0s 47.5s 47.6s

Times for minikube (PR 12268) ingress: 31.3s 30.3s 31.9s 31.4s 31.8s
Times for minikube ingress: 31.8s 32.7s 31.3s 30.8s 30.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12268) |
+----------------+----------+---------------------+
| minikube start | 21.8s    | 22.0s               |
| enable ingress | 33.6s    | 29.2s               |
+----------------+----------+---------------------+

Times for minikube start: 21.1s 22.4s 21.5s 23.2s 20.6s
Times for minikube (PR 12268) start: 22.6s 21.9s 22.0s 22.1s 21.2s

Times for minikube ingress: 35.0s 29.5s 27.5s 35.0s 41.0s
Times for minikube (PR 12268) ingress: 26.5s 35.0s 30.0s 27.5s 27.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12268) |
+----------------+----------+---------------------+
| minikube start | 41.6s    | 43.8s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 32.2s 44.4s 42.8s 44.4s 44.1s
Times for minikube (PR 12268) start: 43.3s 44.0s 44.0s 44.4s 43.2s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_crio TestNetworkPlugins/group/custom-weave/Start (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/newest-cni/serial/SecondStart (gopogh) 1.11 (chart)
KVM_Linux_crio TestAddons/parallel/Olm (gopogh) 3.92 (chart)
Docker_Linux_crio TestNetworkPlugins/group/bridge/DNS (gopogh) 5.03 (chart)
Docker_Windows TestStartStop/group/no-preload/serial/SecondStart (gopogh) 15.25 (chart)
Hyperkit_macOS TestDebPackageInstall/install_amd64_debian (gopogh) 10/kvm2-driver (chart)
Hyperkit_macOS TestDebPackageInstall/install_amd64_debian (gopogh) 9/kvm2-driver (chart)
Hyperkit_macOS TestDebPackageInstall/install_amd64_debian (gopogh) latest/kvm2-driver (chart)
Hyperkit_macOS TestDebPackageInstall/install_amd64_debian (gopogh) sid/kvm2-driver (chart)
Hyperkit_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) 18.04/kvm2-driver (chart)
Hyperkit_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) 20.04/kvm2-driver (chart)
Hyperkit_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) 20.10/kvm2-driver (chart)
Hyperkit_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) latest/kvm2-driver (chart)
KVM_Linux_containerd TestStartStop/group/newest-cni/serial/Pause (gopogh) 19.25 (chart)
Docker_Linux_crio TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 23.89 (chart)
KVM_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 24.22 (chart)
KVM_Linux_containerd TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 24.22 (chart)
KVM_Linux_containerd TestPause/serial/Pause (gopogh) 24.84 (chart)
KVM_Linux_containerd TestPause/serial/VerifyStatus (gopogh) 24.84 (chart)
KVM_Linux_containerd TestStartStop/group/embed-certs/serial/Pause (gopogh) 24.84 (chart)
KVM_Linux_containerd TestStartStop/group/no-preload/serial/Pause (gopogh) 24.84 (chart)
KVM_Linux_crio TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 25.17 (chart)
KVM_Linux_crio TestStartStop/group/newest-cni/serial/Pause (gopogh) 25.32 (chart)
KVM_Linux_crio TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 25.49 (chart)
Docker_Windows TestInsufficientStorage (gopogh) 25.53 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 25.62 (chart)
KVM_Linux_crio TestStartStop/group/embed-certs/serial/Pause (gopogh) 25.97 (chart)
Docker_Linux_containerd TestStartStop/group/newest-cni/serial/Pause (gopogh) 26.25 (chart)
KVM_Linux_crio TestPause/serial/Pause (gopogh) 26.32 (chart)
KVM_Linux_crio TestPause/serial/VerifyStatus (gopogh) 26.32 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@medyagh
Copy link
Member

medyagh commented Aug 16, 2021

the failures are not related to this PR

@medyagh medyagh merged commit 7dc8836 into kubernetes:master Aug 16, 2021
pkalever pushed a commit to pkalever/ceph-csi that referenced this pull request Nov 9, 2021
Assuming kubernetes/minikube#12268 introduced
bugs in NBD kernel driver.

updates: ceph#2610
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KVM: Cilium CNI not working with buildroot 2021.02 systemd
5 participants