Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto start buildkit daemon on image build for containerd #12076

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

spowelljr
Copy link
Member

Closes #11195

Implemented automatically starting buildkit daemon when image build ran with containerd.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 29, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2021
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 29, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12076) |
+----------------+----------+---------------------+
| minikube start | 48.0s    | 48.6s               |
| enable ingress | 33.9s    | 33.9s               |
+----------------+----------+---------------------+

Times for minikube start: 49.6s 47.8s 47.3s 47.5s 48.0s
Times for minikube (PR 12076) start: 49.4s 48.5s 46.6s 49.2s 49.1s

Times for minikube ingress: 31.3s 39.8s 34.3s 31.3s 32.8s
Times for minikube (PR 12076) ingress: 31.7s 31.9s 33.8s 32.2s 39.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12076) |
+----------------+----------+---------------------+
| minikube start | 22.6s    | 21.9s               |
| enable ingress | 34.9s    | 35.1s               |
+----------------+----------+---------------------+

Times for minikube start: 23.7s 22.3s 22.1s 23.1s 21.9s
Times for minikube (PR 12076) start: 21.5s 21.6s 22.2s 21.8s 22.2s

Times for minikube ingress: 35.5s 36.5s 31.5s 35.5s 35.5s
Times for minikube (PR 12076) ingress: 36.0s 36.0s 32.0s 36.0s 35.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12076) |
+----------------+----------+---------------------+
| minikube start | 41.2s    | 43.5s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 32.1s 43.5s 43.8s 43.6s 42.9s
Times for minikube (PR 12076) start: 43.6s 43.7s 43.0s 44.0s 43.1s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_crio TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 0.00 (chart)
Docker_Linux_docker_arm64 TestNetworkPlugins/group/false/Start (gopogh) 2.56 (chart)
Docker_Linux TestFunctional/serial/ComponentHealth (gopogh) 3.77 (chart)
Docker_Linux_docker_arm64 TestNetworkPlugins/group/custom-weave/Start (gopogh) 5.13 (chart)
Docker_Linux_crio TestKubernetesUpgrade (gopogh) 6.00 (chart)
Docker_Linux_containerd_arm64 TestFunctional/serial/LogsCmd (gopogh) 6.06 (chart)
Docker_Linux_containerd_arm64 TestFunctional/serial/LogsFileCmd (gopogh) 6.06 (chart)
Docker_macOS TestStartStop/group/newest-cni/serial/Pause (gopogh) 6.38 (chart)
Docker_Linux_crio TestAddons/parallel/GCPAuth (gopogh) 8.00 (chart)
Docker_Linux_crio_arm64 TestPause/serial/Pause (gopogh) 11.36 (chart)
Docker_Linux_crio_arm64 TestPause/serial/PauseAgain (gopogh) 11.36 (chart)
Docker_Linux_crio_arm64 TestPause/serial/VerifyStatus (gopogh) 11.36 (chart)
Docker_Linux_docker_arm64 TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 12.82 (chart)
KVM_Linux_containerd TestPause/serial/PauseAgain (gopogh) 15.91 (chart)
Hyperkit_macOS TestFunctional/parallel/DashboardCmd (gopogh) 17.39 (chart)
Docker_Linux_docker_arm64 TestNetworkPlugins/group/bridge/Start (gopogh) 17.95 (chart)
Docker_Linux_docker_arm64 TestNetworkPlugins/group/kubenet/Start (gopogh) 17.95 (chart)
Docker_Linux_crio TestStartStop/group/no-preload/serial/Stop (gopogh) 20.00 (chart)
Docker_Linux_docker_arm64 TestNetworkPlugins/group/kindnet/Start (gopogh) 20.51 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/DNS (gopogh) 30.77 (chart)
Docker_Linux_crio_arm64 TestAddons/parallel/GCPAuth (gopogh) 38.64 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 40.00 (chart)
Docker_Windows TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 40.71 (chart)
Docker_Linux_crio_arm64 TestAddons/parallel/CSI (gopogh) 43.18 (chart)
Docker_Linux_crio TestMultiNode/serial/PingHostFrom2Pods (gopogh) 44.00 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/Pause (gopogh) 44.44 (chart)
Docker_macOS TestFunctional/serial/ComponentHealth (gopogh) 45.10 (chart)
Docker_macOS TestFunctional/serial/ExtraConfig (gopogh) 45.10 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh) 45.45 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/DNS (gopogh) 46.88 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit 7ddcb94 into kubernetes:master Aug 2, 2021
@spowelljr spowelljr deleted the autoStartBuildkit branch August 2, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically start buildkit for minikube image build for containerd
4 participants