Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Non-Active Containers Runtimes #11516

Merged
merged 8 commits into from
May 27, 2021
Merged

Disable Non-Active Containers Runtimes #11516

merged 8 commits into from
May 27, 2021

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented May 26, 2021 •
edited
Loading

before this PR

$ mk start --driver=docker --container-runtime=containerd
$ mk ssh
docker@minikube:~$ sudo systemctl status docker
● docker.service - Docker Application Container Engine
   Loaded: loaded (/lib/systemd/system/docker.service; enabled; vendor preset: enabled)
   Active: active (running)

after this PR


$ mk ssh
Last login: Wed May 26 19:09:56 2021 from 192.168.49.1
docker@minikube:~$ sudo systemctl status docker
● docker.service
     Loaded: masked (Reason: Unit docker.service is masked.)
     Active: inactive (dead) since Wed 2021-05-26 19:08:14 UTC; 4min 43s ago
   Main PID: 229 (code=exited, status=0/SUCCESS)

May 26 19:08:10 minikube dockerd[229]: time="2021-05-26T19:08:10.495789000Z" level=info msg="Default bridge (docker0) is assigned with an IP address 172.17.0.0/16. Daemon option --bip can be used to set a preferred IP address"
May 26 19:08:11 minikube dockerd[229]: time="2021-05-26T19:08:11.006386600Z" level=info msg="Processing signal 'terminated'"
May 26 19:08:14 minikube dockerd[229]: time="2021-05-26T19:08:14.516776200Z" level=info msg="Loading containers: done."
May 26 19:08:14 minikube dockerd[229]: time="2021-05-26T19:08:14.546569100Z" level=info msg="Docker daemon" commit=8728dd2 graphdriver(s)=overlay2 version=20.10.6
May 26 19:08:14 minikube dockerd[229]: time="2021-05-26T19:08:14.546700800Z" level=info msg="Daemon has completed initialization"
May 26 19:08:14 minikube dockerd[229]: time="2021-05-26T19:08:14.588089700Z" level=info msg="API listen on /run/docker.sock"
May 26 19:08:14 minikube dockerd[229]: time="2021-05-26T19:08:14.589758400Z" level=info msg="stopping event stream following graceful shutdown" error="<nil>" module=libcontainerd namespace=moby
May 26 19:08:14 minikube dockerd[229]: time="2021-05-26T19:08:14.591363800Z" level=info msg="Daemon shutdown complete"
May 26 19:08:14 minikube systemd[1]: docker.service: Succeeded.
May 26 19:08:14 minikube systemd[1]: Stopped Docker Application Container Engine.

closes #11515

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 26, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2021
@medyagh
Copy link
Member Author

medyagh commented May 26, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 26, 2021
@medyagh medyagh requested a review from ilya-zuyev May 26, 2021 19:18
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 27, 2021
@medyagh medyagh changed the title disable docker service when containerd Disable Non-Active Containers Runtimes May 27, 2021
@medyagh
Copy link
Member Author

medyagh commented May 27, 2021

ok-to-test

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11516) |
+----------------+----------+---------------------+
| minikube start | 50.2s    | 49.5s               |
| enable ingress | 34.7s    | 34.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 33.8s 35.8s 34.3s 35.3s 34.4s
Times for minikube (PR 11516) ingress: 32.8s 33.8s 35.3s 35.3s 34.3s

Times for minikube start: 52.8s 48.0s 49.9s 50.0s 50.2s
Times for minikube (PR 11516) start: 48.4s 51.2s 48.1s 52.2s 47.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11516) |
+----------------+----------+---------------------+
| minikube start | 23.2s    | 22.4s               |
| enable ingress | 28.7s    | 29.9s               |
+----------------+----------+---------------------+

Times for minikube start: 23.7s 22.9s 22.9s 22.6s 23.7s
Times for minikube (PR 11516) start: 21.3s 22.9s 23.4s 21.8s 22.4s

Times for minikube (PR 11516) ingress: 31.5s 28.5s 32.0s 28.5s 29.0s
Times for minikube ingress: 27.0s 29.0s 28.5s 28.0s 31.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11516) |
+----------------+----------+---------------------+
| minikube start | 42.6s    | 45.4s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 32.0s 49.1s 43.7s 44.3s 43.7s
Times for minikube (PR 11516) start: 47.4s 47.9s 43.7s 44.3s 44.0s

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11516) |
+----------------+----------+---------------------+
| minikube start | 50.5s    | 51.1s               |
| enable ingress | 35.1s    | 34.7s               |
+----------------+----------+---------------------+

Times for minikube start: 50.4s 50.4s 54.3s 50.0s 47.4s
Times for minikube (PR 11516) start: 47.1s 50.4s 48.6s 55.6s 53.7s

Times for minikube (PR 11516) ingress: 34.3s 35.3s 33.9s 35.2s 34.8s
Times for minikube ingress: 34.2s 35.3s 35.3s 34.2s 36.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11516) |
+----------------+----------+---------------------+
| minikube start | 23.0s    | 22.4s               |
| enable ingress | 31.9s    | 34.0s               |
+----------------+----------+---------------------+

Times for minikube ingress: 28.5s 29.6s 31.5s 37.1s 33.0s
Times for minikube (PR 11516) ingress: 33.5s 34.5s 32.5s 33.6s 36.0s

Times for minikube start: 24.8s 23.0s 22.7s 22.3s 22.0s
Times for minikube (PR 11516) start: 22.3s 21.6s 23.0s 22.5s 22.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11516) |
+----------------+----------+---------------------+
| minikube start | 41.2s    | 45.0s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 29.4s 43.6s 44.1s 44.5s 44.6s
Times for minikube (PR 11516) start: 48.9s 43.2s 43.8s 44.7s 44.6s

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11516) |
+----------------+----------+---------------------+
| minikube start | 48.5s    | 47.8s               |
| enable ingress | 37.1s    | 39.5s               |
+----------------+----------+---------------------+

Times for minikube start: 52.1s 47.9s 46.9s 48.0s 47.7s
Times for minikube (PR 11516) start: 48.9s 45.6s 49.3s 47.6s 47.8s

Times for minikube ingress: 36.8s 36.7s 35.2s 35.2s 41.6s
Times for minikube (PR 11516) ingress: 42.2s 34.7s 43.2s 35.2s 42.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11516) |
+----------------+----------+---------------------+
| minikube start | 22.7s    | 22.3s               |
| enable ingress | 34.4s    | 33.8s               |
+----------------+----------+---------------------+

Times for minikube ingress: 37.5s 33.5s 32.0s 34.0s 35.0s
Times for minikube (PR 11516) ingress: 32.5s 31.0s 34.5s 36.5s 34.5s

Times for minikube start: 22.8s 23.5s 22.0s 22.5s 22.4s
Times for minikube (PR 11516) start: 21.9s 22.5s 21.7s 22.9s 22.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11516) |
+----------------+----------+---------------------+
| minikube start | 38.3s    | 42.7s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 32.0s 29.5s 43.0s 44.0s 43.1s
Times for minikube (PR 11516) start: 43.7s 44.2s 29.7s 48.8s 47.2s

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [medyagh,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh merged commit 89604fc into kubernetes:master May 27, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11516) |
+----------------+----------+---------------------+
| minikube start | 50.9s    | 51.1s               |
| enable ingress | 35.2s    | 33.9s               |
+----------------+----------+---------------------+

Times for minikube start: 50.6s 47.5s 51.8s 53.2s 51.2s
Times for minikube (PR 11516) start: 48.9s 52.4s 54.8s 51.8s 47.5s

Times for minikube ingress: 34.9s 34.9s 34.8s 35.3s 35.9s
Times for minikube (PR 11516) ingress: 33.4s 33.8s 34.4s 33.3s 34.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11516) |
+----------------+----------+---------------------+
| minikube start | 23.4s    | 23.4s               |
| enable ingress | 29.2s    | 40.6s               |
+----------------+----------+---------------------+

Times for minikube start: 22.9s 23.6s 23.4s 23.7s 23.2s
Times for minikube (PR 11516) start: 22.9s 23.9s 22.7s 22.8s 24.6s

Times for minikube ingress: 29.0s 29.0s 28.5s 31.5s 28.1s
Times for minikube (PR 11516) ingress: 29.0s 89.5s 29.5s 27.6s 27.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11516) |
+----------------+----------+---------------------+
| minikube start | 45.1s    | 41.8s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 45.4s 44.2s 48.6s 43.3s 43.9s
Times for minikube (PR 11516) start: 44.0s 45.1s 44.4s 44.2s 31.4s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-zuyev ilya-zuyev ilya-zuyev left review comments

@sharifelgamal sharifelgamal sharifelgamal approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@RA489 RA489 Awaiting requested review from RA489

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker service is still running for contianed
5 participants
@medyagh @minikube-pr-bot @k8s-ci-robot @sharifelgamal @ilya-zuyev