gcp-auth addon: do not reapply gcp-auth yamls on minikube restart

[sharifelgamal]

Fixes #9465

The source of that race condition is that we occasionally try to reapply certs that already exist and things break. Avoiding applying at all seems to be the safest course of action. Note this will still allow users to refresh their creds if they need to.

[medyagh]

lets add an entry to the site with example of using refresh and when they would need to do it
in the gcp auth site

https://minikube.sigs.k8s.io/docs/handbook/addons/gcp-auth/

[sharifelgamal]

lets add an entry to the site with example of using refresh and when they would need to do it
in the gcp auth site

https://minikube.sigs.k8s.io/docs/handbook/addons/gcp-auth/

done.

[sharifelgamal]

/ok-to-test

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11486) |
+----------------+----------+---------------------+
| minikube start | 54.5s    | 54.2s               |
| enable ingress | 36.9s    | 38.2s               |
+----------------+----------+---------------------+

Times for minikube ingress: 35.4s 42.9s 34.9s 36.9s 34.4s
Times for minikube (PR 11486) ingress: 36.4s 37.9s 44.9s 34.9s 36.8s

Times for minikube start: 54.6s 58.2s 52.8s 53.9s 52.8s
Times for minikube (PR 11486) start: 53.6s 58.4s 53.6s 54.1s 51.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11486) |
+----------------+----------+---------------------+
| minikube start | 23.5s    | 23.4s               |
| enable ingress | 33.8s    | 33.9s               |
+----------------+----------+---------------------+

Times for minikube start: 23.9s 23.2s 24.0s 23.4s 23.1s
Times for minikube (PR 11486) start: 23.1s 23.6s 23.3s 24.0s 22.9s

Times for minikube ingress: 32.6s 33.1s 33.6s 36.1s 33.6s
Times for minikube (PR 11486) ingress: 34.1s 35.1s 33.6s 31.6s 35.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11486) |
+----------------+----------+---------------------+
| minikube start | 49.0s    | 48.5s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 50.0s 49.0s 47.8s 48.9s 49.4s
Times for minikube (PR 11486) start: 49.3s 49.8s 49.3s 44.3s 49.9s

[medyagh]

looks good just a few nits...

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11486) |
+----------------+----------+---------------------+
| minikube start | 48.6s    | 47.9s               |
| enable ingress | 34.1s    | 34.4s               |
+----------------+----------+---------------------+

Times for minikube start: 47.1s 51.8s 46.7s 48.0s 49.4s
Times for minikube (PR 11486) start: 47.8s 48.2s 46.5s 49.9s 47.3s

Times for minikube (PR 11486) ingress: 34.7s 32.8s 34.8s 34.3s 35.2s
Times for minikube ingress: 34.3s 33.9s 33.7s 34.3s 34.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11486) |
+----------------+----------+---------------------+
| minikube start | 22.0s    | 21.9s               |
| enable ingress | 31.5s    | 29.0s               |
+----------------+----------+---------------------+

Times for minikube start: 22.1s 21.7s 22.7s 21.5s 21.8s
Times for minikube (PR 11486) start: 22.9s 21.9s 21.7s 21.6s 21.3s

Times for minikube ingress: 27.5s 31.0s 29.0s 37.0s 33.0s
Times for minikube (PR 11486) ingress: 28.5s 27.5s 31.0s 28.5s 29.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11486) |
+----------------+----------+---------------------+
| minikube start | 45.2s    | 46.8s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 46.0s 47.1s 47.0s 43.3s 42.7s
Times for minikube (PR 11486) start: 43.3s 47.5s 47.5s 48.2s 47.5s

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11486) |
+----------------+----------+---------------------+
| minikube start | 48.9s    | 48.1s               |
| enable ingress | 36.3s    | 34.4s               |
+----------------+----------+---------------------+

Times for minikube start: 49.4s 50.5s 46.4s 48.1s 50.0s
Times for minikube (PR 11486) start: 46.5s 51.4s 47.6s 48.5s 46.3s

Times for minikube ingress: 43.2s 33.8s 34.3s 33.7s 36.3s
Times for minikube (PR 11486) ingress: 33.8s 35.4s 33.8s 34.8s 34.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11486) |
+----------------+----------+---------------------+
| minikube start | 21.9s    | 21.9s               |
| enable ingress | 33.3s    | 32.6s               |
+----------------+----------+---------------------+

Times for minikube start: 21.9s 21.9s 22.5s 21.8s 21.6s
Times for minikube (PR 11486) start: 21.6s 21.7s 21.8s 22.4s 21.8s

Times for minikube ingress: 34.0s 33.0s 34.0s 33.0s 32.5s
Times for minikube (PR 11486) ingress: 32.0s 29.0s 34.5s 31.0s 36.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11486) |
+----------------+----------+---------------------+
| minikube start | 46.3s    | 46.0s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube (PR 11486) start: 47.6s 47.3s 44.0s 47.8s 43.1s
Times for minikube start: 49.4s 43.2s 47.6s 43.6s 48.0s