Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warn about performance for certain versions of kubernetes #11217

Merged
merged 6 commits into from
May 3, 2021
Merged

warn about performance for certain versions of kubernetes #11217

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
661e62a
warn about performance for certain versions of kubernetes
sharifelgamal Apr 27, 2021
7afe98b
add 1.21.0
sharifelgamal Apr 28, 2021
fb5f275
abstract kubernetes issues away
sharifelgamal Apr 28, 2021
8657b72
address comments
sharifelgamal Apr 29, 2021
9dbe957
Merge branch 'master' of github.com:kubernetes/minikube into warn-k8s
sharifelgamal May 3, 2021
e27e9a1
return pointer to k8sissue
sharifelgamal May 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion cmd/minikube/cmd/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,15 @@ var (
apiServerNames []string
apiServerIPs []net.IP
hostRe = regexp.MustCompile(`^[^-][\w\.-]+$`)
slowK8sVersions = map[string]struct{}{
sharifelgamal marked this conversation as resolved.
Show resolved Hide resolved
"1.18.16": {},
sharifelgamal marked this conversation as resolved.
Show resolved Hide resolved
"1.18.17": {},
"1.19.8": {},
"1.19.9": {},
"1.20.3": {},
"1.20.4": {},
"1.20.5": {},
sharifelgamal marked this conversation as resolved.
Show resolved Hide resolved
}
)

func init() {
Expand Down Expand Up @@ -394,7 +403,7 @@ func startWithDriver(cmd *cobra.Command, starter node.Starter, existing *config.
}

func warnAboutMultiNodeCNI() {
out.WarningT("Cluster was created without any CNI, adding node to it might cause broken network.")
out.WarningT("Cluster was created without any CNI, adding a node to it might cause broken networking.")
}

func updateDriver(driverName string) {
Expand Down Expand Up @@ -1370,6 +1379,11 @@ func validateKubernetesVersion(old *config.ClusterConfig) {
exitIfNotForced(reason.KubernetesTooOld, "Kubernetes {{.version}} is not supported by this release of minikube", out.V{"version": nvs})
}

if _, ok := slowK8sVersions[nvs.String()]; ok {
sharifelgamal marked this conversation as resolved.
Show resolved Hide resolved
out.WarningT("The requested version of Kubernetes has a known performance issue on cluster startup. It might take 2 to 3 minutes for a cluster to start.")
out.WarningT("For more info, see https://github.com/kubernetes/kubeadm/issues/2395")
}

if old == nil || old.KubernetesConfig.KubernetesVersion == "" {
return
}
Expand Down