-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cri: Add API for saving an image to a local path #11128
Conversation
This function SaveImage is the opposite of LoadImage, useful for saving built images to the cache directory. This is an alternative to using the push functionality, which requires a registry similar to the pull function.
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 53.2s 47.1s 49.2s 52.1s 51.0s Times for minikube ingress: 36.4s 35.3s 34.3s 36.4s 33.8s docker driver with docker runtime
Times for minikube ingress: 31.0s 28.5s 28.5s 29.0s 33.0s Times for minikube start: 22.2s 21.2s 22.7s 21.4s 21.4s docker driver with containerd runtime |
Looks good to me |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This function SaveImage is the opposite of LoadImage,
useful for saving built images to the cache directory.
This is an alternative to using the push functionality,
which requires a registry (similar to the pull function).
For #11130