Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-pause: initialize the pause state from the current state #10958

Conversation

azhao155
Copy link
Contributor

  1. restart auto-pause service while paused:
Mar 30 08:23:21 minikube auto-pause[7411]: W0330 08:23:21.278673    7411 out.go:154] [unset outFile]: * Paused 13 containers
Mar 30 08:24:15 minikube systemd[1]: Stopping Auto Pause Service...
Mar 30 08:24:15 minikube systemd[1]: auto-pause.service: Succeeded.
Mar 30 08:24:15 minikube systemd[1]: Stopped Auto Pause Service.
Mar 30 08:24:15 minikube systemd[1]: Started Auto Pause Service.
Mar 30 08:24:15 minikube auto-pause[7879]: I0330 08:24:15.290659    7879 exec_runner.go:52] Run: systemctl --version
Mar 30 08:24:15 minikube auto-pause[7879]: I0330 08:24:15.293778    7879 exec_runner.go:52] Run: docker ps --filter status=paused --filter=name=k8s_.*_(kube-system)_ --format={{.ID}}
Mar 30 08:24:15 minikube auto-pause[7879]: W0330 08:24:15.344897    7879 out.go:154] [unset outFile]: * containers paused status: true
Mar 30 08:24:15 minikube auto-pause[7879]: Starting auto-pause server 0.0.1 at port 8080

pause doesn't run anymore.

  1. restart auto-pause service while unpaused:
Mar 30 08:22:20 minikube systemd[1]: Stopping Auto Pause Service...
Mar 30 08:22:20 minikube systemd[1]: auto-pause.service: Succeeded.
Mar 30 08:22:20 minikube systemd[1]: Stopped Auto Pause Service.
Mar 30 08:22:20 minikube systemd[1]: Started Auto Pause Service.
Mar 30 08:22:20 minikube auto-pause[7411]: I0330 08:22:20.677704    7411 exec_runner.go:52] Run: systemctl --version
Mar 30 08:22:20 minikube auto-pause[7411]: I0330 08:22:20.680873    7411 exec_runner.go:52] Run: docker ps --filter status=paused --filter=name=k8s_.*_(kube-system)_ --format={{.ID}}
Mar 30 08:22:20 minikube auto-pause[7411]: W0330 08:22:20.727186    7411 out.go:154] [unset outFile]: * containers paused status: false
Mar 30 08:22:20 minikube auto-pause[7411]: Starting auto-pause server 0.0.1 at port 8080
Mar 30 08:23:20 minikube auto-pause[7411]: I0330 08:23:20.728371    7411 exec_runner.go:52] Run: sudo systemctl disable kubelet
Mar 30 08:23:20 minikube sudo[7739]:     root : TTY=unknown ; PWD=/ ; USER=root ; COMMAND=/usr/bin/systemctl disable kubelet
Mar 30 08:23:20 minikube sudo[7739]: pam_env(sudo:session): Unable to open env file: /etc/default/locale: No such file or directory
Mar 30 08:23:20 minikube sudo[7739]: pam_unix(sudo:session): session opened for user root by (uid=0)
Mar 30 08:23:20 minikube sudo[7739]: pam_unix(sudo:session): session closed for user root
Mar 30 08:23:20 minikube auto-pause[7411]: I0330 08:23:20.921073    7411 exec_runner.go:52] Run: sudo systemctl stop kubelet
Mar 30 08:23:20 minikube sudo[7754]:     root : TTY=unknown ; PWD=/ ; USER=root ; COMMAND=/usr/bin/systemctl stop kubelet
Mar 30 08:23:20 minikube sudo[7754]: pam_env(sudo:session): Unable to open env file: /etc/default/locale: No such file or directory
Mar 30 08:23:20 minikube sudo[7754]: pam_unix(sudo:session): session opened for user root by (uid=0)
Mar 30 08:23:21 minikube sudo[7754]: pam_unix(sudo:session): session closed for user root
Mar 30 08:23:21 minikube auto-pause[7411]: I0330 08:23:21.002208    7411 exec_runner.go:52] Run: docker ps --filter status=running --filter=name=k8s_.*_(kube-system)_ --format={{.I
D}}
Mar 30 08:23:21 minikube auto-pause[7411]: I0330 08:23:21.050375    7411 docker.go:291] Pausing containers: [244d97ee5c1c 1791784cb1ad b67f5187424d 299dad827593 bdb40b5332bb f48898
288d6b 768161befb01 fe0be987cfc4 740035d2dbba b7e0a02d4ece d2e17547b25f 1b393e735268 cce5f1ff772b]
Mar 30 08:23:21 minikube auto-pause[7411]: I0330 08:23:21.050494    7411 exec_runner.go:52] Run: docker pause 244d97ee5c1c 1791784cb1ad b67f5187424d 299dad827593 bdb40b5332bb f4889
8288d6b 768161befb01 fe0be987cfc4 740035d2dbba b7e0a02d4ece d2e17547b25f 1b393e735268 cce5f1ff772b
Mar 30 08:23:21 minikube auto-pause[7411]: W0330 08:23:21.278673    7411 out.go:154] [unset outFile]: * Paused 13 containers

pause run

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 30, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 30, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz see comments and also fix the lint

cmd/auto-pause/auto-pause.go Outdated Show resolved Hide resolved
cmd/auto-pause/auto-pause.go Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: azhao155, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh
Copy link
Member

medyagh commented Mar 30, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Mar 30, 2021
@kubernetes kubernetes deleted a comment from minikube-pr-bot Mar 30, 2021
@medyagh
Copy link
Member

medyagh commented Apr 1, 2021

/retest-this-please

@kubernetes kubernetes deleted a comment from minikube-pr-bot Apr 1, 2021
@medyagh
Copy link
Member

medyagh commented Apr 5, 2021

/retest-this-please

@kubernetes kubernetes deleted a comment from minikube-pr-bot Apr 5, 2021
@kubernetes kubernetes deleted a comment from minikube-pr-bot Apr 5, 2021
@medyagh medyagh merged commit 18dacff into kubernetes:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants