Update olm addon to v0.17.0 #10947

kadel · 2021-03-29T09:58:06Z

update olm addon to use OLM v0.17.0

k8s-ci-robot · 2021-03-29T09:58:19Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kadel
To complete the pull request process, please assign tstromberg after the PR has been reviewed.
You can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

minikube-bot · 2021-03-29T09:59:03Z

Can one of the admins verify this patch?

medyagh

the crds.yaml.tmpl diff says

11,302 additions, 10,357 deletions not shown because the diff is too large. Please use a local Git client to view these changes.

this doesnt sound right, do u mind clarifying what is inside that file?

medyagh · 2021-03-30T02:17:22Z

deploy/addons/olm/olm.yaml.tmpl

@@ -78,9 +78,9 @@ spec:
          command:
          - /bin/olm
          args:
-          - -namespace
+          - --namespace


what is the reason for the additional -- ?

old OLM versions were using flags at some point they switched to github.com/spf13/pflag library, hence move from - to --

kadel · 2021-03-30T12:55:47Z

the crds.yaml.tmpl diff says
11,302 additions, 10,357 deletions not shown because the diff is too large. Please use a local Git client to view these changes.
this doesnt sound right, do u mind clarifying what is inside that file?

This is correct. It contains all CustomeResourceDefinitions used by OLM. This is taken from the official v0.17.0 release artifcats. You can check it at https://github.com/operator-framework/operator-lifecycle-manager/releases/tag/v0.17.0

sharifelgamal · 2021-04-01T19:35:57Z

Hey @kadel, we have a test (in test/integration/addons_test.go) that currently skips testing the OLM addon. Could you remove the skip so that we can properly test this PR?

Thanks!

kadel · 2021-04-02T20:47:24Z

Hey @kadel, we have a test (in test/integration/addons_test.go) that currently skips testing the OLM addon. Could you remove the skip so that we can properly test this PR?

Thanks!

oh, I haven't noticed the integration test.
Done.

sharifelgamal · 2021-04-02T21:19:44Z

/ok-to-test

minikube-pr-bot · 2021-04-02T21:21:57Z

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10947): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10947/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10947/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10947): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10947/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10947/minikube: exec format error

medyagh · 2021-04-08T00:02:24Z

deploy/addons/olm/olm.yaml.tmpl

@@ -326,8 +328,16 @@ spec:
                  requests:
                    cpu: 10m
                    memory: 50Mi
+                securityContext:
+                  runAsUser: 1000


is this required ? this seems to give Root Access to the addon,
do u mind clarifying why we need to run with more special access ?

I don't work on OLM directly I'm just a user and I did not write this definition. This comes from the official OLM release artifacts.

But If I'm not mistaken root has uid 0. This is not giving any special access to the container, it is doing quite the opposite. It ensures that the container can't run anything as root.
1000 is the first non-root user. Even if the image is built in a way that it runs as root inside the container, this will force it to be non-root.

that makes sense ! thanks for the clarifying, I mistakenly thought it was user 1

medyagh · 2021-04-08T00:02:44Z

deploy/addons/olm/olm.yaml.tmpl

@@ -308,7 +310,7 @@ spec:
                - --global-namespace
                - olm
                image: {{.CustomRegistries.OLM  | default .ImageRepository | default .Registries.OLM }}{{.Images.OLM}}
-                imagePullPolicy: IfNotPresent
+                imagePullPolicy: Always


is this change related to bumping the version ?

minikube-pr-bot · 2021-04-13T09:54:45Z

kvm2 Driver
Times for minikube start: 50.3s 48.5s 48.3s 49.9s 52.1s
Average time for minikube start: 49.8s

Times for minikube ingress: 43.3s 36.4s 46.3s 43.8s 36.4s
Average time for minikube ingress: 41.2s

Times for minikube (PR 10947) start: 47.8s 51.8s 52.5s 48.9s 48.7s
Average time for minikube (PR 10947) start: 49.9s

Times for minikube (PR 10947) ingress: 43.3s 43.3s 45.0s 36.7s 34.8s
Average time for minikube (PR 10947) ingress: 40.6s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10947) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.19.0 on Debian               | 0.0s     | 0.0s                |
| 9.13 (kvm/amd64)                           |          |                     |
|   - MINIKUBE_LOCATION=10947                | 0.0s     | 0.0s                |
| * Using the kvm2 driver based              | 0.0s     |                     |
| on existing profile                        |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 30.2s    | 30.4s               |
| Memory=6000MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 14.2s    | 8.0s                |
| on Docker 20.10.4 ...                      |          |                     |
|   - Generating certificates                | 0.6s     | 1.8s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 2.4s     | 7.2s                |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.1s     | 1.3s                |
| * Verifying Kubernetes                     | 0.0s     | 0.0s                |
| components...                              |          |                     |
|   - Using image                            | 1.0s     | 1.0s                |
| gcr.io/k8s-minikube/storage-provisioner:v5 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.2s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube start: 22.3s 21.3s 22.9s 21.2s 21.3s
Average time for minikube start: 21.8s

Times for minikube ingress: 37.0s 35.0s 37.0s 31.0s 34.0s
Average time for minikube ingress: 34.8s

Times for minikube (PR 10947) start: 21.5s 22.5s 21.0s 21.8s 22.0s
Average time for minikube (PR 10947) start: 21.8s

Times for minikube (PR 10947) ingress: 32.5s 35.0s 33.5s 33.5s 38.0s
Average time for minikube (PR 10947) ingress: 34.5s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10947) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.19.0 on Debian               | 0.0s     | 0.0s                |
| 9.13 (kvm/amd64)                           |          |                     |
|   - MINIKUBE_LOCATION=10947                | 0.1s     | 0.1s                |
| * Using the docker driver                  | 0.1s     |                     |
| based on existing profile                  |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 6.9s     | 6.7s                |
| (CPUs=2, Memory=8000MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 4.2s     | 4.0s                |
| on Docker 20.10.5 ...                      |          |                     |
|   - Generating certificates                | 1.7s     | 2.0s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 6.8s     | 6.9s                |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.1s     | 1.2s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 0.5s     | 0.5s                |
| gcr.io/k8s-minikube/storage-provisioner:v5 |          |                     |
| * Enabled addons:                          | 0.0s     | 0.0s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

medyagh · 2021-05-03T20:19:55Z

/ok-to-test

minikube-pr-bot · 2021-05-03T21:04:32Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 10947) |
+----------------+----------+---------------------+
| minikube start | 56.5s    | 56.2s               |
| enable ingress | 38.9s    | 40.7s               |
+----------------+----------+---------------------+

Times for minikube start: 57.7s 58.2s 54.4s 58.7s 53.4s
Times for minikube (PR 10947) start: 58.3s 54.1s 56.1s 56.8s 55.9s

Times for minikube ingress: 36.9s 43.5s 38.5s 36.4s 39.4s
Times for minikube (PR 10947) ingress: 44.4s 38.5s 38.4s 37.4s 44.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 10947) |
+----------------+----------+---------------------+
| minikube start | 23.4s    | 22.8s               |
| enable ingress | 44.4s    | 30.6s               |
+----------------+----------+---------------------+

Times for minikube ingress: 32.1s 32.6s 91.1s 32.6s 33.6s
Times for minikube (PR 10947) ingress: 36.5s 30.5s 28.0s 28.7s 29.1s

Times for minikube start: 23.5s 23.0s 23.6s 23.5s 23.2s
Times for minikube (PR 10947) start: 22.0s 23.3s 22.8s 22.9s 23.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 10947) |
+----------------+----------+---------------------+
| minikube start | 45.4s    | 45.1s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 44.8s 48.5s 43.8s 45.6s 44.4s
Times for minikube (PR 10947) start: 44.4s 44.0s 44.6s 48.5s 43.8s

medyagh · 2021-05-03T22:04:56Z

Looks good to me @kadel , Thank you for this PR and improving olm addon

look forward for more PRs for you

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 29, 2021

k8s-ci-robot requested review from medyagh and sharifelgamal March 29, 2021 09:58

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 29, 2021

medyagh requested changes Mar 30, 2021

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2021

kadel force-pushed the update-olm-addon-0.17.0 branch from f62cf49 to 63ed2c5 Compare March 30, 2021 14:20

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2021

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 2, 2021

medyagh requested changes Apr 8, 2021

View reviewed changes

kadel force-pushed the update-olm-addon-0.17.0 branch from 63af485 to 1e8a841 Compare April 13, 2021 09:15

kadel added 2 commits May 3, 2021 13:17

olm addon: update OLM to 0.17.0

08cb1c1

remove skip from olm integration test

a3be004

medyagh force-pushed the update-olm-addon-0.17.0 branch from 1e8a841 to a3be004 Compare May 3, 2021 20:19

medyagh added the pr_verified label May 3, 2021

medyagh merged commit 114e826 into kubernetes:master May 3, 2021

kadel mentioned this pull request May 4, 2021

update the Outdated catalog in OLM addon #10768

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update olm addon to v0.17.0 #10947

Update olm addon to v0.17.0 #10947

kadel commented Mar 29, 2021 •

edited

Loading

k8s-ci-robot commented Mar 29, 2021

minikube-bot commented Mar 29, 2021

medyagh left a comment

medyagh Mar 30, 2021

kadel Mar 30, 2021

kadel commented Mar 30, 2021 •

edited

Loading

sharifelgamal commented Apr 1, 2021 •

edited

Loading

kadel commented Apr 2, 2021

sharifelgamal commented Apr 2, 2021

minikube-pr-bot commented Apr 2, 2021

medyagh Apr 8, 2021

kadel Apr 8, 2021

medyagh May 3, 2021 •

edited

Loading

medyagh Apr 8, 2021

kadel Apr 8, 2021

minikube-pr-bot commented Apr 13, 2021

medyagh commented May 3, 2021

minikube-pr-bot commented May 3, 2021

medyagh commented May 3, 2021

Update olm addon to v0.17.0 #10947

Update olm addon to v0.17.0 #10947

Conversation

kadel commented Mar 29, 2021 • edited Loading

k8s-ci-robot commented Mar 29, 2021

minikube-bot commented Mar 29, 2021

medyagh left a comment

Choose a reason for hiding this comment

medyagh Mar 30, 2021

Choose a reason for hiding this comment

kadel Mar 30, 2021

Choose a reason for hiding this comment

kadel commented Mar 30, 2021 • edited Loading

sharifelgamal commented Apr 1, 2021 • edited Loading

kadel commented Apr 2, 2021

sharifelgamal commented Apr 2, 2021

minikube-pr-bot commented Apr 2, 2021

medyagh Apr 8, 2021

Choose a reason for hiding this comment

kadel Apr 8, 2021

Choose a reason for hiding this comment

medyagh May 3, 2021 • edited Loading

Choose a reason for hiding this comment

medyagh Apr 8, 2021

Choose a reason for hiding this comment

kadel Apr 8, 2021

Choose a reason for hiding this comment

minikube-pr-bot commented Apr 13, 2021

medyagh commented May 3, 2021

minikube-pr-bot commented May 3, 2021

medyagh commented May 3, 2021

kadel commented Mar 29, 2021 •

edited

Loading

kadel commented Mar 30, 2021 •

edited

Loading

sharifelgamal commented Apr 1, 2021 •

edited

Loading

medyagh May 3, 2021 •

edited

Loading