add additional options to avoid node drain or delete getting stuck

[prezha]

fixes: #10925

an example error condition is given in the issue's description

add additional options to avoid kubectl node drain or api node delete processes getting stuck

[medyagh]

/ok-to-test

[medyagh]

@prezha do u mind link to the documentation of these flags and evaluate what they exaclty do and what are the possible side effects of these ?

[minikube-pr-bot]

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10926): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10926/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10926/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10926): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10926/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10926/minikube: exec format error

[prezha]

@prezha do u mind link to the documentation of these flags and evaluate what they exaclty do and what are the possible side effects of these ?

@medyagh in the comments just above those changed/added lines there are references to the docs and an explanation of what are they're for: ie, the old lines 107-108 and new line 124:

minikube/pkg/minikube/node/node.go

Lines 107 to 108 in b1353c5

	// kubectl drain with extra options to prevent ending up stuck in the process
	// ref: https://kubernetes.io/docs/reference/generated/kubectl/kubectl-commands#drain

minikube/pkg/minikube/node/node.go

Line 124 in b1353c5

// set 'GracePeriodSeconds: 0' option to delete node immediately (ie, w/o waiting)

do you think more details should be added?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, prezha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment